)]}'
{"nova/api/openstack/compute/deferred_delete.py":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"fbcc8e2ae0533bd597c5b3fc4377caf07f0e6f1f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                            \u0027project_id\u0027: instance.project_id})"},{"line_number":63,"context_line":"        try:"},{"line_number":64,"context_line":"            self.compute_api.force_delete(context, instance)"},{"line_number":65,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":66,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.format_message())"},{"line_number":67,"context_line":"        except exception.InstanceUnknownCell as e:"},{"line_number":68,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.format_message())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_79230d06","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":41},"updated":"2016-11-15 06:49:35.000000000","message":"This issue doesn\u0027t raise any exception, so there is no point in catching exception here. It just logs a info message when any delete/force-delete request comes if instance is already in deleting task state.\n\nI have submitted a patch for this fix.","commit_id":"813dbcc4c52e984de7959da14fb367776f63eeaf"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e4d1c6c4bb239ee25d8ef2295fecae0f3aeb841f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                            \u0027project_id\u0027: instance.project_id})"},{"line_number":63,"context_line":"        try:"},{"line_number":64,"context_line":"            self.compute_api.force_delete(context, instance)"},{"line_number":65,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":66,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.format_message())"},{"line_number":67,"context_line":"        except exception.InstanceUnknownCell as e:"},{"line_number":68,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.format_message())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_b4e2fc01","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":41},"in_reply_to":"7a77a97e_494af184","updated":"2016-11-15 12:28:18.000000000","message":"yea, agree with Timofey","commit_id":"813dbcc4c52e984de7959da14fb367776f63eeaf"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"e6f4188e5749d794d71922f4cdf6153eece0acdb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                            \u0027project_id\u0027: instance.project_id})"},{"line_number":63,"context_line":"        try:"},{"line_number":64,"context_line":"            self.compute_api.force_delete(context, instance)"},{"line_number":65,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":66,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.format_message())"},{"line_number":67,"context_line":"        except exception.InstanceUnknownCell as e:"},{"line_number":68,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.format_message())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_494af184","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":41},"in_reply_to":"7a77a97e_79230d06","updated":"2016-11-15 12:19:37.000000000","message":"It\u0027s possible to have a race here, so catching these exceptions seems to be valid","commit_id":"813dbcc4c52e984de7959da14fb367776f63eeaf"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f49a4b502243dbfaaf4f2afd4cdd4180990dbd2f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                            \u0027project_id\u0027: instance.project_id})"},{"line_number":63,"context_line":"        try:"},{"line_number":64,"context_line":"            self.compute_api.force_delete(context, instance)"},{"line_number":65,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":66,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.format_message())"},{"line_number":67,"context_line":"        except exception.InstanceUnknownCell as e:"},{"line_number":68,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.format_message())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_c1cb3571","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":41},"in_reply_to":"7a77a97e_b4e2fc01","updated":"2016-11-15 13:18:10.000000000","message":"e.g https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1725 ?","commit_id":"813dbcc4c52e984de7959da14fb367776f63eeaf"}]}