)]}'
{"nova/compute/api.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"2e9448660f293709947d297175037dcf77ca4edf","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"            self.db.block_device_mapping_destroy(context, bdm[\u0027id\u0027])"},{"line_number":1362,"context_line":"        instance \u003d cb(context, instance, bdms, local\u003dTrue)"},{"line_number":1363,"context_line":"        self.db.instance_destroy(context, instance_uuid)"},{"line_number":1364,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1365,"context_line":"            context, instance, \"delete.end\", system_metadata\u003dsystem_meta)"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"    def _do_delete(self, context, instance, bdms, reservations\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FVgE%3D","line":1364,"updated":"2013-08-01 19:51:25.000000000","message":"Slightly outside the jurisdiction of this patch, but I think this should emit a \u0027soft_delete.end\u0027 notification for consistency.","commit_id":"9f8f0dbde6ef14c4a46c16cd00e038a72c026e6c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e92d0f4101fc3add8e79b7e95be10c2ce012cc4f","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"            self.db.block_device_mapping_destroy(context, bdm[\u0027id\u0027])"},{"line_number":1362,"context_line":"        instance \u003d cb(context, instance, bdms, local\u003dTrue)"},{"line_number":1363,"context_line":"        self.db.instance_destroy(context, instance_uuid)"},{"line_number":1364,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1365,"context_line":"            context, instance, \"delete.end\", system_metadata\u003dsystem_meta)"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"    def _do_delete(self, context, instance, bdms, reservations\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FUow%3D","line":1364,"in_reply_to":"AAAAQn%2F%2FVgE%3D","updated":"2013-08-01 23:16:31.000000000","message":"Yeah, that\u0027s fair, will change.","commit_id":"9f8f0dbde6ef14c4a46c16cd00e038a72c026e6c"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"2e9448660f293709947d297175037dcf77ca4edf","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1365,"context_line":"            context, instance, \"delete.end\", system_metadata\u003dsystem_meta)"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"    def _do_delete(self, context, instance, bdms, reservations\u003dNone,"},{"line_number":1368,"context_line":"                   local\u003dFalse):"},{"line_number":1369,"context_line":"        if local:"},{"line_number":1370,"context_line":"            return self.update(context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FVgI%3D","line":1367,"updated":"2013-08-01 19:51:25.000000000","message":"Tiny nitpick, but it feels a little wonky that sometimes an instance is returned and sometimes it\u0027s not.\n\nIt might be cleaner to refactor slightly and have make one callback for remote delete a second for local delete.  Each could handle either soft or \"hard\" deletes.","commit_id":"9f8f0dbde6ef14c4a46c16cd00e038a72c026e6c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e92d0f4101fc3add8e79b7e95be10c2ce012cc4f","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"        compute_utils.notify_about_instance_usage("},{"line_number":1365,"context_line":"            context, instance, \"delete.end\", system_metadata\u003dsystem_meta)"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"    def _do_delete(self, context, instance, bdms, reservations\u003dNone,"},{"line_number":1368,"context_line":"                   local\u003dFalse):"},{"line_number":1369,"context_line":"        if local:"},{"line_number":1370,"context_line":"            return self.update(context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FUo0%3D","line":1367,"in_reply_to":"AAAAQn%2F%2FVgI%3D","updated":"2013-08-01 23:16:31.000000000","message":"So, does it make you feel any better that this is just for this patch and it\u0027s removed/unified in the next? :)\n\nThis is a temporary measure to keep the existing behavior, but objects makes it smoother anyway, so it\u0027s not needed in the next patch...","commit_id":"9f8f0dbde6ef14c4a46c16cd00e038a72c026e6c"}]}