)]}'
{"nova/conf/key_manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"46f19ad087f433582c6186df8f401732a65b84ea","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    # post Newton"},{"line_number":78,"context_line":"    conf.register_group(barbican_group)"},{"line_number":79,"context_line":"    conf.register_opts(barbican_opts, group\u003dbarbican_group)"},{"line_number":80,"context_line":"    ks_loading.register_session_conf_options(conf, barbican_group.name)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_0e4c1f9d","side":"PARENT","line":80,"updated":"2016-11-25 15:07:20.000000000","message":"Its not clear if castellan is doing this correct, but I guess thats not really our problem.","commit_id":"fb693f07f0f0024cd3ae007812594c4992d25ada"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"04b433c968f1ce11e94c7a818312e5f75ab32e25","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # one group as duplicate and only one group (either from this file or"},{"line_number":87,"context_line":"    # Castellan library) will show up. So fix is to merge options of same"},{"line_number":88,"context_line":"    # group name from this file and Castellan library"},{"line_number":89,"context_line":"    opts \u003d {barbican_group.name: barbican_opts,"},{"line_number":90,"context_line":"            key_manager_group.name: key_manager_opts}"},{"line_number":91,"context_line":"    for group, options in castellan_opts.list_opts():"},{"line_number":92,"context_line":"        if group not in opts.keys():"},{"line_number":93,"context_line":"            opts[group] \u003d options"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            opts[group] \u003d opts[group] + options"},{"line_number":96,"context_line":"    return opts"},{"line_number":97,"context_line":"    # TODO(raj_singh): Post Newton delete code block from above and comment in"},{"line_number":98,"context_line":"    # line below. Castellan already returned a list which can be returned"},{"line_number":99,"context_line":"    # directly from list_opts()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_e4fe3437","side":"PARENT","line":96,"range":{"start_line":89,"start_character":4,"end_line":96,"end_character":15},"updated":"2016-11-16 19:37:08.000000000","message":"So we still have one key_manager option left in this file. That means we need a code block to merge key_manager option from this file and Castellan library.\nopts \u003d {key_manager_group.name: key_manager_opts}\n    for group, options in castellan_opts.list_opts():\n        if group not in opts.keys():\n            opts[group] \u003d options\n        else:\n            opts[group] \u003d opts[group] + options\n    return opts","commit_id":"fb693f07f0f0024cd3ae007812594c4992d25ada"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"46f19ad087f433582c6186df8f401732a65b84ea","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # one group as duplicate and only one group (either from this file or"},{"line_number":87,"context_line":"    # Castellan library) will show up. So fix is to merge options of same"},{"line_number":88,"context_line":"    # group name from this file and Castellan library"},{"line_number":89,"context_line":"    opts \u003d {barbican_group.name: barbican_opts,"},{"line_number":90,"context_line":"            key_manager_group.name: key_manager_opts}"},{"line_number":91,"context_line":"    for group, options in castellan_opts.list_opts():"},{"line_number":92,"context_line":"        if group not in opts.keys():"},{"line_number":93,"context_line":"            opts[group] \u003d options"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            opts[group] \u003d opts[group] + options"},{"line_number":96,"context_line":"    return opts"},{"line_number":97,"context_line":"    # TODO(raj_singh): Post Newton delete code block from above and comment in"},{"line_number":98,"context_line":"    # line below. Castellan already returned a list which can be returned"},{"line_number":99,"context_line":"    # directly from list_opts()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_8eb2ef92","side":"PARENT","line":96,"range":{"start_line":89,"start_character":4,"end_line":96,"end_character":15},"in_reply_to":"7a77a97e_e4fe3437","updated":"2016-11-25 15:07:20.000000000","message":"+1","commit_id":"fb693f07f0f0024cd3ae007812594c4992d25ada"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"494cc32eca30a477b1c8218921eed698805de194","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"key_manager_opts \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt("},{"line_number":25,"context_line":"        \u0027fixed_key\u0027,"},{"line_number":26,"context_line":"        deprecated_group\u003d\u0027keymgr\u0027,"},{"line_number":27,"context_line":"        help\u003d\"\"\""},{"line_number":28,"context_line":"Fixed key returned by key manager, specified in hex."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_1f31bdec","line":25,"range":{"start_line":25,"start_character":9,"end_line":25,"end_character":18},"updated":"2016-11-16 19:37:56.000000000","message":"Maybe we should think of moving this option to Castellan?","commit_id":"adf12168076a8ee60ccd87abd5030c44617ddee3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"46f19ad087f433582c6186df8f401732a65b84ea","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"key_manager_opts \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt("},{"line_number":25,"context_line":"        \u0027fixed_key\u0027,"},{"line_number":26,"context_line":"        deprecated_group\u003d\u0027keymgr\u0027,"},{"line_number":27,"context_line":"        help\u003d\"\"\""},{"line_number":28,"context_line":"Fixed key returned by key manager, specified in hex."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_b9dc5774","line":25,"range":{"start_line":25,"start_character":9,"end_line":25,"end_character":18},"in_reply_to":"7a77a97e_1f31bdec","updated":"2016-11-25 15:07:20.000000000","message":"So it turns out this is only used by ConfKeyManager, which is the default I believe.\n\nTurns out there is a whole load of configuration nastyness hidden over here that we really need to sort out:\nhttps://github.com/openstack/nova/blob/4f91ed3a547965ed96a22520edcfb783e7936e95/nova/keymgr/__init__.py#L28\n\nIt feels like ConfKeyManager should move to castellan, or we should just deprecate it.\n\nYuck.","commit_id":"adf12168076a8ee60ccd87abd5030c44617ddee3"}],"releasenotes/notes/remove_deprecated_barbican_config_opts-7eb4e801d0ac252f.yaml":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"04b433c968f1ce11e94c7a818312e5f75ab32e25","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration options related to Barbican have been removed. They were"},{"line_number":5,"context_line":"    makred as deprecated because this configuration has been moved to the"},{"line_number":6,"context_line":"    Castellan library. Listed below are the affected options:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``barbican.catalog_info``"},{"line_number":9,"context_line":"    - ``barbican.endpoint_template``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a77a97e_3f003901","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":43},"updated":"2016-11-16 19:37:08.000000000","message":"Following are","commit_id":"adf12168076a8ee60ccd87abd5030c44617ddee3"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"04b433c968f1ce11e94c7a818312e5f75ab32e25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration options related to Barbican have been removed. They were"},{"line_number":5,"context_line":"    makred as deprecated because this configuration has been moved to the"},{"line_number":6,"context_line":"    Castellan library. Listed below are the affected options:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``barbican.catalog_info``"},{"line_number":9,"context_line":"    - ``barbican.endpoint_template``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a77a97e_44328811","line":6,"range":{"start_line":4,"start_character":46,"end_line":6,"end_character":21},"updated":"2016-11-16 19:37:08.000000000","message":"were deprecated and now completely removed. These options are available in Castellan library.","commit_id":"adf12168076a8ee60ccd87abd5030c44617ddee3"}]}