)]}'
{"nova/api/metadata/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e31bcf651473a51cac9a07d1acad7568317d8678","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        # contain the admin password for the instance, and we shouldn\u0027t"},{"line_number":207,"context_line":"        # pass that to external services."},{"line_number":208,"context_line":"        self.vendordata_providers \u003d {"},{"line_number":209,"context_line":"            \u0027StaticJSON\u0027: vendordata_json.JsonFileVendorData("},{"line_number":210,"context_line":"                instance\u003dinstance, address\u003daddress,"},{"line_number":211,"context_line":"                extra_md\u003dextra_md, network_info\u003dnetwork_info),"},{"line_number":212,"context_line":"            \u0027DynamicJSON\u0027: vendordata_dynamic.DynamicVendorData("},{"line_number":213,"context_line":"                instance\u003dinstance, address\u003daddress,"},{"line_number":214,"context_line":"                network_info\u003dnetwork_info, context\u003drequest_context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_45ae0be8","line":211,"range":{"start_line":209,"start_character":12,"end_line":211,"end_character":62},"updated":"2017-09-22 15:47:33.000000000","message":"The above seems redundant with this.\n\nMaybe that means the default value for vendordata_providers should be StaticJSON now?\n\nWe should talk to mikal.","commit_id":"12e7d8e68ce06d576d9f1897b99d4b99eded2913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed303b509845c8c9b8941458f54742faf7ef0077","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        # contain the admin password for the instance, and we shouldn\u0027t"},{"line_number":207,"context_line":"        # pass that to external services."},{"line_number":208,"context_line":"        self.vendordata_providers \u003d {"},{"line_number":209,"context_line":"            \u0027StaticJSON\u0027: vendordata_json.JsonFileVendorData("},{"line_number":210,"context_line":"                instance\u003dinstance, address\u003daddress,"},{"line_number":211,"context_line":"                extra_md\u003dextra_md, network_info\u003dnetwork_info),"},{"line_number":212,"context_line":"            \u0027DynamicJSON\u0027: vendordata_dynamic.DynamicVendorData("},{"line_number":213,"context_line":"                instance\u003dinstance, address\u003daddress,"},{"line_number":214,"context_line":"                network_info\u003dnetwork_info, context\u003drequest_context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_a23b6ecf","line":211,"range":{"start_line":209,"start_character":12,"end_line":211,"end_character":62},"in_reply_to":"7f515b1d_45ae0be8","updated":"2017-10-19 08:55:39.000000000","message":"Done","commit_id":"12e7d8e68ce06d576d9f1897b99d4b99eded2913"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1d81b2e90e0555131842dede20d38aa77d8f8f7e","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            # NOTE(mikal): backwards compatibility... If the deployer has"},{"line_number":504,"context_line":"            # specified providers, and one of those providers is StaticJSON,"},{"line_number":505,"context_line":"            # then do that thing here. Otherwise, if the deployer has"},{"line_number":506,"context_line":"            # specified an old style driver here, then use that. This second"},{"line_number":507,"context_line":"            # bit can be removed once old style vendordata is fully deprecated"},{"line_number":508,"context_line":"            # and removed."},{"line_number":509,"context_line":"            if (CONF.api.vendordata_providers and"},{"line_number":510,"context_line":"                \u0027StaticJSON\u0027 in CONF.api.vendordata_providers):"},{"line_number":511,"context_line":"                return jsonutils.dump_as_bytes("}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_055493c9","line":508,"range":{"start_line":506,"start_character":65,"end_line":508,"end_character":26},"updated":"2017-09-22 15:49:11.000000000","message":"yeah","commit_id":"12e7d8e68ce06d576d9f1897b99d4b99eded2913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed303b509845c8c9b8941458f54742faf7ef0077","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            # NOTE(mikal): backwards compatibility... If the deployer has"},{"line_number":504,"context_line":"            # specified providers, and one of those providers is StaticJSON,"},{"line_number":505,"context_line":"            # then do that thing here. Otherwise, if the deployer has"},{"line_number":506,"context_line":"            # specified an old style driver here, then use that. This second"},{"line_number":507,"context_line":"            # bit can be removed once old style vendordata is fully deprecated"},{"line_number":508,"context_line":"            # and removed."},{"line_number":509,"context_line":"            if (CONF.api.vendordata_providers and"},{"line_number":510,"context_line":"                \u0027StaticJSON\u0027 in CONF.api.vendordata_providers):"},{"line_number":511,"context_line":"                return jsonutils.dump_as_bytes("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_823872d3","line":508,"range":{"start_line":506,"start_character":65,"end_line":508,"end_character":26},"in_reply_to":"7f515b1d_055493c9","updated":"2017-10-19 08:55:39.000000000","message":"Done","commit_id":"12e7d8e68ce06d576d9f1897b99d4b99eded2913"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e31bcf651473a51cac9a07d1acad7568317d8678","unresolved":false,"context_lines":[{"line_number":511,"context_line":"                return jsonutils.dump_as_bytes("},{"line_number":512,"context_line":"                    self.vendordata_providers[\u0027StaticJSON\u0027].get())"},{"line_number":513,"context_line":"            else:"},{"line_number":514,"context_line":"                # TODO(mikal): when we removed the old style vendordata"},{"line_number":515,"context_line":"                # drivers, we need to remove self.vddriver as well."},{"line_number":516,"context_line":"                return jsonutils.dump_as_bytes(self.vddriver.get())"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        raise KeyError(path)"},{"line_number":519,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_857d2370","line":516,"range":{"start_line":514,"start_character":16,"end_line":516,"end_character":67},"updated":"2017-09-22 15:47:33.000000000","message":"here?","commit_id":"12e7d8e68ce06d576d9f1897b99d4b99eded2913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed303b509845c8c9b8941458f54742faf7ef0077","unresolved":false,"context_lines":[{"line_number":511,"context_line":"                return jsonutils.dump_as_bytes("},{"line_number":512,"context_line":"                    self.vendordata_providers[\u0027StaticJSON\u0027].get())"},{"line_number":513,"context_line":"            else:"},{"line_number":514,"context_line":"                # TODO(mikal): when we removed the old style vendordata"},{"line_number":515,"context_line":"                # drivers, we need to remove self.vddriver as well."},{"line_number":516,"context_line":"                return jsonutils.dump_as_bytes(self.vddriver.get())"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        raise KeyError(path)"},{"line_number":519,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_623576da","line":516,"range":{"start_line":514,"start_character":16,"end_line":516,"end_character":67},"in_reply_to":"7f515b1d_857d2370","updated":"2017-10-19 08:55:39.000000000","message":"Done","commit_id":"12e7d8e68ce06d576d9f1897b99d4b99eded2913"}],"nova/conf/api.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e9d1fc31c0373ebfd18f6b7b3679631878f48a59","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"def list_opts():"},{"line_number":371,"context_line":"    return {api_group: API_OPTS}{"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_0bd14558","line":371,"range":{"start_line":371,"start_character":32,"end_line":371,"end_character":33},"updated":"2017-10-30 08:08:58.000000000","message":"typo","commit_id":"c7b235c287f0427bbb3c3d4ce96d6e9b6f70df2e"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"8af7ea95223b3df700a10c52be24564179f110d8","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"def list_opts():"},{"line_number":371,"context_line":"    return {api_group: API_OPTS}{"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_0fb13be2","line":371,"range":{"start_line":371,"start_character":32,"end_line":371,"end_character":33},"in_reply_to":"3f4b6375_0bd14558","updated":"2017-10-30 22:03:08.000000000","message":"Yes.","commit_id":"c7b235c287f0427bbb3c3d4ce96d6e9b6f70df2e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d16b3c63277cf6ecfb1840eba6146efb0fe2e533","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"def list_opts():"},{"line_number":371,"context_line":"    return {api_group: API_OPTS}{"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_6f5df313","line":371,"range":{"start_line":371,"start_character":32,"end_line":371,"end_character":33},"in_reply_to":"3f4b6375_0fb13be2","updated":"2017-11-02 15:07:49.000000000","message":"Damn, done.","commit_id":"c7b235c287f0427bbb3c3d4ce96d6e9b6f70df2e"}],"releasenotes/notes/remove-deprecated-vendordata_driver-opt-3ececc051e581070.yaml":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"0e87ab53ce67f3e931bf0dee890ac824d2baed76","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The ``vendordata_driver`` option was deprecated in Mitaka and has now been"},{"line_number":4,"context_line":"    removed. The default JSON driver provides enough configurability"},{"line_number":5,"context_line":"    out-of-the-box."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a77a97e_59bd1567","line":3,"updated":"2016-11-16 19:12:04.000000000","message":"nit: in ``api`` group","commit_id":"0c9a415f1d6894262afda42b0bde49aadfb11301"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f4801bfffc7479d1bacfed636393a9a66416f16","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The ``vendordata_driver`` option was deprecated in Mitaka and has now been"},{"line_number":4,"context_line":"    removed. The default JSON driver provides enough configurability"},{"line_number":5,"context_line":"    out-of-the-box."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f287b81_f673f44c","line":5,"range":{"start_line":3,"start_character":3,"end_line":5,"end_character":19},"updated":"2017-09-07 16:30:21.000000000","message":"This should point to the vendordata docs but I can\u0027t find those now after the shuffle.","commit_id":"6fb54af3517ffeaa259de395948a80d88496a901"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"848134604138fca1a11bbe5e6f555f1638686e58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The ``vendordata_driver`` option was deprecated in Mitaka and has now been"},{"line_number":4,"context_line":"    removed. The default JSON driver provides enough configurability"},{"line_number":5,"context_line":"    out-of-the-box."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f287b81_b6068c85","line":5,"range":{"start_line":3,"start_character":3,"end_line":5,"end_character":19},"in_reply_to":"7f287b81_f673f44c","updated":"2017-09-07 16:32:37.000000000","message":"https://docs.openstack.org/nova/latest/user/vendordata.html","commit_id":"6fb54af3517ffeaa259de395948a80d88496a901"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5bb84919a8e655e6e0d8470aa0b2b30dd7870e2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``vendordata_driver`` option was deprecated in Mitaka and has now been"},{"line_number":5,"context_line":"    removed. The default JSON driver provides enough configurability"},{"line_number":6,"context_line":"    out-of-the-box. For more information, refer to the `vendordata"},{"line_number":7,"context_line":"    documentation`__"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_8521a3a2","line":5,"range":{"start_line":5,"start_character":46,"end_line":5,"end_character":52},"updated":"2017-09-22 15:43:04.000000000","message":"I\u0027d probably drop this, as it\u0027s totally dependent on what you need, and people could just argue it.","commit_id":"2def026ca40bbee9de8005347aa7e7435d085c7a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f226a16d1b527b836473acd13c15b344071030cf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[DEFAULT] vendordata_driver`` option was deprecated in Mitaka and has"},{"line_number":5,"context_line":"    now been removed. Configuration of vendordata drivers should now be done by"},{"line_number":6,"context_line":"    using the `[api] vendordata_providers`` option. For more information, refer"},{"line_number":7,"context_line":"    to the `vendordata documentation`__."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    __ https://docs.openstack.org/nova/latest/user/vendordata.html"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f93b717_648f2e75","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":15},"updated":"2018-01-30 15:47:15.000000000","message":"Oops. However, this has been tagged so I\u0027m not sure fixing the release note is worth it now.","commit_id":"a3b445c0ef5c7473b60bcf9d44b082e73aeb5690"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"612b52e44435820d4592c36525f902b6db9a511c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[DEFAULT] vendordata_driver`` option was deprecated in Mitaka and has"},{"line_number":5,"context_line":"    now been removed. Configuration of vendordata drivers should now be done by"},{"line_number":6,"context_line":"    using the `[api] vendordata_providers`` option. For more information, refer"},{"line_number":7,"context_line":"    to the `vendordata documentation`__."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    __ https://docs.openstack.org/nova/latest/user/vendordata.html"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f93b717_ee13025b","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":15},"in_reply_to":"5f93b717_648f2e75","updated":"2018-01-31 10:37:40.000000000","message":"Damn. If we fix this, I _think_ the fix will appear in the final version. Might want to confirm with Doug though","commit_id":"a3b445c0ef5c7473b60bcf9d44b082e73aeb5690"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5678747541af5b4fd46cd41f88abdaef28c42b64","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[DEFAULT] vendordata_driver`` option was deprecated in Mitaka and has"},{"line_number":5,"context_line":"    now been removed. Configuration of vendordata drivers should now be done by"},{"line_number":6,"context_line":"    using the `[api] vendordata_providers`` option. For more information, refer"},{"line_number":7,"context_line":"    to the `vendordata documentation`__."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    __ https://docs.openstack.org/nova/latest/user/vendordata.html"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f93b717_4e5eb676","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":15},"in_reply_to":"5f93b717_ee13025b","updated":"2018-01-31 10:51:58.000000000","message":"Yup, works fine. This issue and a few more are resolved here:\n\n  https://review.openstack.org/539490","commit_id":"a3b445c0ef5c7473b60bcf9d44b082e73aeb5690"}]}