)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b6242570308591b23637a7d72acba6baae973b84","unresolved":false,"context_lines":[{"line_number":6712,"context_line":""},{"line_number":6713,"context_line":""},{"line_number":6714,"context_line":"@pick_context_manager_reader"},{"line_number":6715,"context_line":"def instance_group_members_get(context, group_uuid):"},{"line_number":6716,"context_line":"    id \u003d _instance_group_id(context, group_uuid)"},{"line_number":6717,"context_line":"    instances \u003d model_query(context,"},{"line_number":6718,"context_line":"                            models.InstanceGroupMember,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_99e05b98","line":6715,"updated":"2016-11-17 17:19:58.000000000","message":"These are in the api database now, so not sure it really makes sense to have these switch. However, maybe we can remove these now?\n\nRegardless, I think we can probably split this change out to its own patch and try to get it landed right?","commit_id":"92a023d7e1036bd23e2c4fabb5de0a050bf024d4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"113ae23257f99683c6907e84e3b02d3c23132fc9","unresolved":false,"context_lines":[{"line_number":6712,"context_line":""},{"line_number":6713,"context_line":""},{"line_number":6714,"context_line":"@pick_context_manager_reader"},{"line_number":6715,"context_line":"def instance_group_members_get(context, group_uuid):"},{"line_number":6716,"context_line":"    id \u003d _instance_group_id(context, group_uuid)"},{"line_number":6717,"context_line":"    instances \u003d model_query(context,"},{"line_number":6718,"context_line":"                            models.InstanceGroupMember,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_058695da","line":6715,"in_reply_to":"7a77a97e_99e05b98","updated":"2016-11-17 18:48:38.000000000","message":"Yeah, since we\u0027re at a point where instance groups are guaranteed to be in the API database, these could be removed and also need to be removed from the object code (that\u0027s where they\u0027re being called presently for things like get_all).\n\nYeah, these switch changes (this file and the objects files) should be separated to go forward.","commit_id":"92a023d7e1036bd23e2c4fabb5de0a050bf024d4"}],"nova/tests/fixtures.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b6242570308591b23637a7d72acba6baae973b84","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        # local accesses i.e. non target_cell accesses."},{"line_number":276,"context_line":"        return self._last_ctxt_mgr"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def add_cell_database(self, connection_str):"},{"line_number":279,"context_line":"        ctxt_mgr \u003d session.create_context_manager()"},{"line_number":280,"context_line":"        self._ctxt_mgrs[connection_str] \u003d ctxt_mgr"},{"line_number":281,"context_line":"        # NOTE(melwitt): The first DB access through service start is"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_3fd3a705","line":278,"range":{"start_line":278,"start_character":32,"end_line":278,"end_character":47},"updated":"2016-11-17 17:19:58.000000000","message":"Is this effectively an idenitifier or an actual sqlalchemy url thing?","commit_id":"92a023d7e1036bd23e2c4fabb5de0a050bf024d4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"113ae23257f99683c6907e84e3b02d3c23132fc9","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        # local accesses i.e. non target_cell accesses."},{"line_number":276,"context_line":"        return self._last_ctxt_mgr"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def add_cell_database(self, connection_str):"},{"line_number":279,"context_line":"        ctxt_mgr \u003d session.create_context_manager()"},{"line_number":280,"context_line":"        self._ctxt_mgrs[connection_str] \u003d ctxt_mgr"},{"line_number":281,"context_line":"        # NOTE(melwitt): The first DB access through service start is"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_45532d6b","line":278,"range":{"start_line":278,"start_character":32,"end_line":278,"end_character":47},"in_reply_to":"7a77a97e_3fd3a705","updated":"2016-11-17 18:48:38.000000000","message":"As you you later saw, yes this is just an identifier that the fixture uses to route to the corresponding in-memory DB.","commit_id":"92a023d7e1036bd23e2c4fabb5de0a050bf024d4"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b6242570308591b23637a7d72acba6baae973b84","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _setup_cells(self):"},{"line_number":108,"context_line":"        fix \u003d nova_fixtures.CellDatabases()"},{"line_number":109,"context_line":"        fix.add_cell_database(\u0027cell0connection\u0027)"},{"line_number":110,"context_line":"        fix.add_cell_database(\u0027cell1connection\u0027)"},{"line_number":111,"context_line":"        self.useFixture(fix)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_313e7b28","line":109,"updated":"2016-11-17 17:19:58.000000000","message":"Okay thought so.","commit_id":"92a023d7e1036bd23e2c4fabb5de0a050bf024d4"}]}