)]}'
{"requirements.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d7b9b6a195b858218aeebd01384cf30878a599a4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"castellan\u003e\u003d0.4.0 # Apache-2.0"},{"line_number":60,"context_line":"microversion-parse\u003e\u003d0.1.2 # Apache-2.0"},{"line_number":61,"context_line":"os-xenapi\u003e\u003d0.1.1 # Apache-2.0"},{"line_number":62,"context_line":"tooz\u003e\u003d1.47.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"fa31d9ce_6670fc72","line":62,"updated":"2017-02-16 02:11:00.000000000","message":"python-ironicclient is in test-requirements.txt since ironic is optional when deploying nova. Should we also move tooz into test-requirements.txt?","commit_id":"91243e3e100bc9c2477cf637b07fb30a93015cbf"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0a08b10d6b6a2868b187f146cb0fe9a9e402b305","unresolved":false,"context_lines":[{"line_number":59,"context_line":"castellan\u003e\u003d0.4.0 # Apache-2.0"},{"line_number":60,"context_line":"microversion-parse\u003e\u003d0.1.2 # Apache-2.0"},{"line_number":61,"context_line":"os-xenapi\u003e\u003d0.1.1 # Apache-2.0"},{"line_number":62,"context_line":"tooz\u003e\u003d1.47.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"fa31d9ce_7fa6b354","line":62,"in_reply_to":"fa31d9ce_6670fc72","updated":"2017-02-16 11:08:57.000000000","message":"I personally don\u0027t think it\u0027s worth it, we\u0027d have to dynamically load it and whatnot, and it\u0027s extra cognitive load for deployer. I can do it if that\u0027s what y\u0027all want to do, though.\n\n(I also don\u0027t think ironicclient being optional is worth it, but don\u0027t feel like fighting that battle)","commit_id":"91243e3e100bc9c2477cf637b07fb30a93015cbf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6035c18959042de6724fcfa11829d95d60986c20","unresolved":false,"context_lines":[{"line_number":59,"context_line":"castellan\u003e\u003d0.4.0 # Apache-2.0"},{"line_number":60,"context_line":"microversion-parse\u003e\u003d0.1.2 # Apache-2.0"},{"line_number":61,"context_line":"os-xenapi\u003e\u003d0.1.1 # Apache-2.0"},{"line_number":62,"context_line":"tooz\u003e\u003d1.47.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"fa31d9ce_8c1fb5b6","line":62,"in_reply_to":"fa31d9ce_7fa6b354","updated":"2017-02-16 15:32:47.000000000","message":"That\u0027s an interesting question. So if we leave the code IN nova, it is fine. But if we try to clean things up and move the code into a library, this question comes up :) I guess I\u0027d say what is nova\u0027s policy on these things? (I also don\u0027t think it is worth moving to test_requirements, but I might be biased.)","commit_id":"91243e3e100bc9c2477cf637b07fb30a93015cbf"}]}