)]}'
{"nova/scheduler/host_manager.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"40891f4aec870396e5ddfd491645356c62ae8300","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return dict((st[\u0027key\u0027], st[\u0027value\u0027]) for st in stats)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def __repr__(self):"},{"line_number":244,"context_line":"        return (\"(%s, %s) ram:%s disk:%s io_ops:%s instances:%s\" %"},{"line_number":245,"context_line":"                (self.host, self.nodename, self.free_ram_mb, self.free_disk_mb,"},{"line_number":246,"context_line":"                 self.num_io_ops, self.num_instances))"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FBdY%3D","line":244,"updated":"2013-08-08 10:31:50.000000000","message":"Don\u0027t use more then one %s. Pls use named parameters.","commit_id":"ed4432da4388b54e099dbf23000639f45e486803"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"339f0bcacbac8e48f48d0e1d0f5f10fe2fc5fad3","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return dict((st[\u0027key\u0027], st[\u0027value\u0027]) for st in stats)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def __repr__(self):"},{"line_number":244,"context_line":"        return (\"(%s, %s) ram:%s disk:%s io_ops:%s instances:%s\" %"},{"line_number":245,"context_line":"                (self.host, self.nodename, self.free_ram_mb, self.free_disk_mb,"},{"line_number":246,"context_line":"                 self.num_io_ops, self.num_instances))"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2B%2FwI%3D","line":244,"in_reply_to":"AAAAQn%2F%2FAgk%3D","updated":"2013-08-08 18:06:48.000000000","message":"Why change this?  This isn\u0027t being passed into gettext for translation, so whats the benefit of changing it?","commit_id":"ed4432da4388b54e099dbf23000639f45e486803"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"a9c96cf42841712eb70fa0cb3f1d3c7e5c36fa91","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return dict((st[\u0027key\u0027], st[\u0027value\u0027]) for st in stats)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def __repr__(self):"},{"line_number":244,"context_line":"        return (\"(%s, %s) ram:%s disk:%s io_ops:%s instances:%s\" %"},{"line_number":245,"context_line":"                (self.host, self.nodename, self.free_ram_mb, self.free_disk_mb,"},{"line_number":246,"context_line":"                 self.num_io_ops, self.num_instances))"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FAgk%3D","line":244,"in_reply_to":"AAAAQn%2F%2FBF4%3D","updated":"2013-08-08 15:07:28.000000000","message":"I also think it\u0027s unnecessary","commit_id":"ed4432da4388b54e099dbf23000639f45e486803"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"01954000d5abee668f84c3dfb1d14cd1c3b77723","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return dict((st[\u0027key\u0027], st[\u0027value\u0027]) for st in stats)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def __repr__(self):"},{"line_number":244,"context_line":"        return (\"(%s, %s) ram:%s disk:%s io_ops:%s instances:%s\" %"},{"line_number":245,"context_line":"                (self.host, self.nodename, self.free_ram_mb, self.free_disk_mb,"},{"line_number":246,"context_line":"                 self.num_io_ops, self.num_instances))"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FBFE%3D","line":244,"in_reply_to":"AAAAQn%2F%2FBF4%3D","updated":"2013-08-08 12:44:25.000000000","message":"Joe would you fix it in another patch?","commit_id":"ed4432da4388b54e099dbf23000639f45e486803"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"a4462e53df4cd771a5367342a13a708b269cbf76","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return dict((st[\u0027key\u0027], st[\u0027value\u0027]) for st in stats)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def __repr__(self):"},{"line_number":244,"context_line":"        return (\"(%s, %s) ram:%s disk:%s io_ops:%s instances:%s\" %"},{"line_number":245,"context_line":"                (self.host, self.nodename, self.free_ram_mb, self.free_disk_mb,"},{"line_number":246,"context_line":"                 self.num_io_ops, self.num_instances))"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FBF4%3D","line":244,"in_reply_to":"AAAAQn%2F%2FBIk%3D","updated":"2013-08-08 12:42:50.000000000","message":"I\u0027m with Andrew ;-)","commit_id":"ed4432da4388b54e099dbf23000639f45e486803"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"9e76f70de21355b7c9b616302f724be91a65e4df","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return dict((st[\u0027key\u0027], st[\u0027value\u0027]) for st in stats)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def __repr__(self):"},{"line_number":244,"context_line":"        return (\"(%s, %s) ram:%s disk:%s io_ops:%s instances:%s\" %"},{"line_number":245,"context_line":"                (self.host, self.nodename, self.free_ram_mb, self.free_disk_mb,"},{"line_number":246,"context_line":"                 self.num_io_ops, self.num_instances))"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FBIk%3D","line":244,"in_reply_to":"AAAAQn%2F%2FBdY%3D","updated":"2013-08-08 12:27:48.000000000","message":"This should definitely use named parameters, but I don\u0027t think that change needs to be in this patch.  I prefer to see changes kept to a minimum as this patch has done.","commit_id":"ed4432da4388b54e099dbf23000639f45e486803"}]}
