)]}'
{"nova/api/openstack/compute/simple_tenant_usage.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"d945d2d760fb5c427f8012658c78bb31e574acdc","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            except exception.InstanceNotFound:"},{"line_number":130,"context_line":"                # This is rare case, instance disappear during analysis"},{"line_number":131,"context_line":"                # As it\u0027s just info collection, we can try next one"},{"line_number":132,"context_line":"                continue"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            # NOTE(mriedem): We need to normalize the start/end times back"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_c9b96cee","line":132,"range":{"start_line":132,"start_character":16,"end_line":132,"end_character":24},"updated":"2016-11-22 18:05:30.000000000","message":"I think if we change the current code to catch this exception too, we should log this fact. How do you think about it ?","commit_id":"7d4465c4c443ec687552656cf39086023898297c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ce063b5afc25fee703200c08775801a271bb14ff","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            except exception.InstanceNotFound:"},{"line_number":130,"context_line":"                # This is rare case, instance disappear during analysis"},{"line_number":131,"context_line":"                # As it\u0027s just info collection, we can try next one"},{"line_number":132,"context_line":"                continue"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            # NOTE(mriedem): We need to normalize the start/end times back"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_1098debf","line":132,"range":{"start_line":132,"start_character":16,"end_line":132,"end_character":24},"in_reply_to":"5a74a57a_03627aad","updated":"2016-11-24 19:07:44.000000000","message":"@Kevin\nbecause those instance.flavor might trigger instance\u0027s _load_flavor function objects/instance.py\nfrom log as it might not be used before\nI guess others won\u0027t ?","commit_id":"7d4465c4c443ec687552656cf39086023898297c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d6314a6b2c45dc28590d8862d485440d39c1f8e0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            except exception.InstanceNotFound:"},{"line_number":130,"context_line":"                # This is rare case, instance disappear during analysis"},{"line_number":131,"context_line":"                # As it\u0027s just info collection, we can try next one"},{"line_number":132,"context_line":"                continue"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            # NOTE(mriedem): We need to normalize the start/end times back"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_e92d48fe","line":132,"range":{"start_line":132,"start_character":16,"end_line":132,"end_character":24},"in_reply_to":"7a77a97e_c9b96cee","updated":"2016-11-22 18:08:28.000000000","message":"maybe or may not\nas this is a just go through the list , any one disappear doesn\u0027t matter, we don\u0027t need to know the detail :)","commit_id":"7d4465c4c443ec687552656cf39086023898297c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"e2bf8c0339596421fba4057f93acb20d36370d27","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            except exception.InstanceNotFound:"},{"line_number":130,"context_line":"                # This is rare case, instance disappear during analysis"},{"line_number":131,"context_line":"                # As it\u0027s just info collection, we can try next one"},{"line_number":132,"context_line":"                continue"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            # NOTE(mriedem): We need to normalize the start/end times back"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_03627aad","line":132,"range":{"start_line":132,"start_character":16,"end_line":132,"end_character":24},"in_reply_to":"7a77a97e_e92d48fe","updated":"2016-11-24 03:19:26.000000000","message":"why we only \"try\" those fields, not all the fields?","commit_id":"7d4465c4c443ec687552656cf39086023898297c"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"16b4c593796e1d08ab7ca09133d73e2e8e6b4c13","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            info[\u0027hours\u0027] \u003d self._hours_for(instance,"},{"line_number":112,"context_line":"                                            period_start,"},{"line_number":113,"context_line":"                                            period_stop)"},{"line_number":114,"context_line":"            flavor \u003d self._get_flavor(context, instance, flavors)"},{"line_number":115,"context_line":"            if not flavor:"},{"line_number":116,"context_line":"                info[\u0027flavor\u0027] \u003d \u0027\u0027"},{"line_number":117,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_ad0d5139","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":18},"updated":"2016-11-30 09:00:41.000000000","message":"why not to use this object instead? _get_flavor already cover the case you are trying to fix.","commit_id":"89f3f464ce8e0e6ea652c95e4d3879690140bdb0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c9df2c1baa08add0aadb18a04779f610adc2fa9f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            info[\u0027hours\u0027] \u003d self._hours_for(instance,"},{"line_number":112,"context_line":"                                            period_start,"},{"line_number":113,"context_line":"                                            period_stop)"},{"line_number":114,"context_line":"            flavor \u003d self._get_flavor(context, instance, flavors)"},{"line_number":115,"context_line":"            if not flavor:"},{"line_number":116,"context_line":"                info[\u0027flavor\u0027] \u003d \u0027\u0027"},{"line_number":117,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_f8167e4a","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":18},"in_reply_to":"5a74a57a_ad0d5139","updated":"2016-12-06 13:41:53.000000000","message":"commit b52876f912156be3f55d1c78898f9050ec498b5a\nAuthor: Dan Smith \u003cdansmith@redhat.com\u003e\nDate:   Tue Jul 12 09:16:35 2016 -0700\n\n    Fix up legacy resource fields in simple-tenant-usage\n\n    This follows the previous patch and makes simple-tenant-usage use\n    the bundled flavor for basic instance resource usage like everything\n    else. This is an important step to being able to remove those fields\n    at some point.\n\n    Also, this often-neglected API\u0027s tests were still mocking at the\n    DB layer, so this converts those to be object-friendly as well.\n\n    Change-Id: Icf7d87021ea59e0197e4b15595c58550093ecdf9\n\n\nthis commit added the code below ,so I think it\u0027s inapproriate to use it","commit_id":"89f3f464ce8e0e6ea652c95e4d3879690140bdb0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08c0ca54d16d50dbb17fcaa5c4df1b1eb62f71b3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            info[\u0027hours\u0027] \u003d self._hours_for(instance,"},{"line_number":112,"context_line":"                                            period_start,"},{"line_number":113,"context_line":"                                            period_stop)"},{"line_number":114,"context_line":"            flavor \u003d self._get_flavor(context, instance, flavors)"},{"line_number":115,"context_line":"            if not flavor:"},{"line_number":116,"context_line":"                info[\u0027flavor\u0027] \u003d \u0027\u0027"},{"line_number":117,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_26ff77ab","line":114,"range":{"start_line":114,"start_character":26,"end_line":114,"end_character":37},"updated":"2017-06-12 13:31:54.000000000","message":"This already handles the NotFound case for the instance, and attempts to lookup the flavor by it\u0027s instance type ID from the instance - why not just re-use this flavor object if it\u0027s not None?","commit_id":"83e6dbf5815e2b0920e3afa404efbc46c09077e9"}]}