)]}'
{"nova/tests/unit/network/test_network_info.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"583ab103b3fa2ab86b0ce42cf4e2a2daa5facbb6","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        super(TestNetworkMetadata, self).setUp()"},{"line_number":859,"context_line":"        self.netinfo \u003d self.new_netinfo()"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def new_netinfo(self, vif_type\u003d\u0027ethernet\u0027):"},{"line_number":862,"context_line":"        netinfo \u003d model.NetworkInfo([fake_network_cache_model.new_vif("},{"line_number":863,"context_line":"            {\u0027type\u0027: vif_type})])"},{"line_number":864,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_94730616","line":861,"updated":"2017-04-06 12:48:47.000000000","message":"nit: method name should start with underscore","commit_id":"b3bb055ffdd0ed0b27111652e5ce297792ad7402"},{"author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"change_message_id":"2acb15738d7c6fdaff21b5dc9af785e9d9069b68","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        super(TestNetworkMetadata, self).setUp()"},{"line_number":859,"context_line":"        self.netinfo \u003d self.new_netinfo()"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def new_netinfo(self, vif_type\u003d\u0027ethernet\u0027):"},{"line_number":862,"context_line":"        netinfo \u003d model.NetworkInfo([fake_network_cache_model.new_vif("},{"line_number":863,"context_line":"            {\u0027type\u0027: vif_type})])"},{"line_number":864,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_289f3d04","line":861,"in_reply_to":"bff0334d_94730616","updated":"2017-04-06 14:19:44.000000000","message":"Done","commit_id":"b3bb055ffdd0ed0b27111652e5ce297792ad7402"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fc5d9aa26cfb8de6f91dfd5326a0676c990a2930","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"        self.assertEqual(legacy_types, link_types)"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"    def test_new_vif_types_get_type_phy(self):"},{"line_number":1221,"context_line":"        new_types \u003d [\"whizbang_nvf\", \"vswitch9\"]"},{"line_number":1222,"context_line":"        link_types \u003d []"},{"line_number":1223,"context_line":"        for vif_type in new_types:"},{"line_number":1224,"context_line":"            network_json \u003d netutils.get_network_metadata("}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_11f481ce","line":1221,"updated":"2017-04-07 08:03:38.000000000","message":"I\u0027d suggest you add \"ethernet\" here in order to also explicitly test the one case that got remapped before your patch.","commit_id":"f559be35a03f5801f527355895a97c89cdc3c336"}],"nova/virt/netutils.py":[{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"b50f98e87a90592b9e4996da48c095d01659d2f4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    # for any other nic device, the guest should be told it"},{"line_number":241,"context_line":"    # is \u0027phy\u0027."},{"line_number":242,"context_line":"    legacy_exposed_types \u003d ("},{"line_number":243,"context_line":"        \u0027vif\u0027,"},{"line_number":244,"context_line":"        model.VIF_TYPE_BRIDGE,"},{"line_number":245,"context_line":"        model.VIF_TYPE_DVS,"},{"line_number":246,"context_line":"        model.VIF_TYPE_HW_VEB,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_45a028f5","line":243,"range":{"start_line":243,"start_character":9,"end_line":243,"end_character":12},"updated":"2017-04-01 03:32:03.000000000","message":"In my opinion, move it to model.py is better. And you can use \u0027model.VIF_TYPE_VIF\u0027 here.","commit_id":"705db9879a201147fcea3faff44e8573248002b9"},{"author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"change_message_id":"bf874b8cd9650956bd0e1b963f44366787b2cf7e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    # for any other nic device, the guest should be told it"},{"line_number":241,"context_line":"    # is \u0027phy\u0027."},{"line_number":242,"context_line":"    legacy_exposed_types \u003d ("},{"line_number":243,"context_line":"        \u0027vif\u0027,"},{"line_number":244,"context_line":"        model.VIF_TYPE_BRIDGE,"},{"line_number":245,"context_line":"        model.VIF_TYPE_DVS,"},{"line_number":246,"context_line":"        model.VIF_TYPE_HW_VEB,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_e6c96178","line":243,"range":{"start_line":243,"start_character":9,"end_line":243,"end_character":12},"in_reply_to":"dfeb2761_45a028f5","updated":"2017-04-03 13:43:34.000000000","message":"Done","commit_id":"705db9879a201147fcea3faff44e8573248002b9"}]}