)]}'
{"nova/objects/build_request.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0de95f9780cde1f574ce4b68ec0d7a2719a1f5ae","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        self.block_device_mappings \u003d ("},{"line_number":117,"context_line":"            objects.BlockDeviceMappingList.obj_from_primitive("},{"line_number":118,"context_line":"                jsonutils.loads(db_bdms), context\u003dself._context))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @staticmethod"},{"line_number":121,"context_line":"    def _from_db_object(context, req, db_req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_0a0e4734","line":118,"updated":"2016-11-23 02:05:57.000000000","message":"Do we want to do the same thing for the Instance object in _load_instance? I know you don\u0027t immediately need it, but it might be nice to be consistent.\n\nI\u0027m actually not totally sure you even need this anymore as you\u0027re overwriting this here now anyway:\n\nhttps://review.openstack.org/#/c/374267/22/nova/compute/api.py@980","commit_id":"15fef614dd2c8c1b09eb1d145d4aacb9c119dc61"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7bf176b6b8285f66d30714d9d618bfbe848fc2b","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        self.block_device_mappings \u003d ("},{"line_number":117,"context_line":"            objects.BlockDeviceMappingList.obj_from_primitive("},{"line_number":118,"context_line":"                jsonutils.loads(db_bdms), context\u003dself._context))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @staticmethod"},{"line_number":121,"context_line":"    def _from_db_object(context, req, db_req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_7fb6838b","line":118,"in_reply_to":"5a74a57a_0a0e4734","updated":"2016-11-23 14:45:08.000000000","message":"I\u0027m confused.. this is the *reason* we need this patch. Without it, the create() on buildrequest will kill the context.","commit_id":"15fef614dd2c8c1b09eb1d145d4aacb9c119dc61"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1ed7175abd009f818c18fc23344ae2a178e18a1a","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        self.block_device_mappings \u003d ("},{"line_number":117,"context_line":"            objects.BlockDeviceMappingList.obj_from_primitive("},{"line_number":118,"context_line":"                jsonutils.loads(db_bdms), context\u003dself._context))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @staticmethod"},{"line_number":121,"context_line":"    def _from_db_object(context, req, db_req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_cd0c4d45","line":118,"in_reply_to":"5a74a57a_4de91d1a","updated":"2016-11-23 15:25:36.000000000","message":"Sorry, I just should have clicked the link because I was seeing old code.\n\nYes, I guess you\u0027re right. This is still the right thing to do, IMHO, because it means that we get a useful BDM object (and instance in the latest update). I\u0027m not sure if you\u0027re suggesting dropping this patch or not.","commit_id":"15fef614dd2c8c1b09eb1d145d4aacb9c119dc61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a850a0c275a30857c2095672ee4c5c8c93c30512","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        self.block_device_mappings \u003d ("},{"line_number":117,"context_line":"            objects.BlockDeviceMappingList.obj_from_primitive("},{"line_number":118,"context_line":"                jsonutils.loads(db_bdms), context\u003dself._context))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @staticmethod"},{"line_number":121,"context_line":"    def _from_db_object(context, req, db_req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_4de91d1a","line":118,"in_reply_to":"5a74a57a_7fb6838b","updated":"2016-11-23 15:11:27.000000000","message":"If we still used the one from build_request.block_device_mapping that was used in create(), yeah, but in https://review.openstack.org/#/c/374267/22/nova/compute/api.py@980 you overwrite that one that doesn\u0027t have the context with the one from _bdm_validate_set_size_and_instance which does, which makes this unnecessary.","commit_id":"15fef614dd2c8c1b09eb1d145d4aacb9c119dc61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5f2ccffad0042f891505cc9f8b293c94c9a18a07","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        self.block_device_mappings \u003d ("},{"line_number":117,"context_line":"            objects.BlockDeviceMappingList.obj_from_primitive("},{"line_number":118,"context_line":"                jsonutils.loads(db_bdms), context\u003dself._context))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @staticmethod"},{"line_number":121,"context_line":"    def _from_db_object(context, req, db_req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_c8c43b94","line":118,"in_reply_to":"5a74a57a_cd0c4d45","updated":"2016-11-23 15:29:43.000000000","message":"I was suggesting dropping this yeah. If this is something we do elsewhere with our objects, then I\u0027d be OK with it as a common pattern.","commit_id":"15fef614dd2c8c1b09eb1d145d4aacb9c119dc61"}]}