)]}'
{"nova/tests/unit/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f6029a3b509376bd651da21f9c5656168f817496","unresolved":false,"context_lines":[{"line_number":2752,"context_line":"        self.assertTrue(security_group_chain,"},{"line_number":2753,"context_line":"                        \"The security group chain wasn\u0027t added\")"},{"line_number":2754,"context_line":""},{"line_number":2755,"context_line":"        match_rules \u003d []"},{"line_number":2756,"context_line":"        regex \u003d re.compile(\u0027\\[0\\:0\\] -A .* -j ACCEPT -p icmp\u0027"},{"line_number":2757,"context_line":"                           \u0027 -s 192.168.11.0/24\u0027)"},{"line_number":2758,"context_line":"        match_rules \u003d [rule for rule in self._out_rules if regex.match(rule)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_d690cb45","line":2755,"range":{"start_line":2755,"start_character":0,"end_line":2755,"end_character":24},"updated":"2016-11-28 13:07:13.000000000","message":"I don\u0027t see why we need this. match_rules will be at least an empty list below","commit_id":"9e9ae877542f9587feb7df6693b2814c300d8412"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"41fe711a436c343df61b3eefbf300b94d797d9bf","unresolved":false,"context_lines":[{"line_number":2752,"context_line":"        self.assertTrue(security_group_chain,"},{"line_number":2753,"context_line":"                        \"The security group chain wasn\u0027t added\")"},{"line_number":2754,"context_line":""},{"line_number":2755,"context_line":"        match_rules \u003d []"},{"line_number":2756,"context_line":"        regex \u003d re.compile(\u0027\\[0\\:0\\] -A .* -j ACCEPT -p icmp\u0027"},{"line_number":2757,"context_line":"                           \u0027 -s 192.168.11.0/24\u0027)"},{"line_number":2758,"context_line":"        match_rules \u003d [rule for rule in self._out_rules if regex.match(rule)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_14bcd6b9","line":2755,"range":{"start_line":2755,"start_character":0,"end_line":2755,"end_character":24},"in_reply_to":"5a74a57a_d690cb45","updated":"2016-11-29 05:15:54.000000000","message":"will remove this line","commit_id":"9e9ae877542f9587feb7df6693b2814c300d8412"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a12dd11b10693038a6b1173c95c39a7a1c6c9280","unresolved":false,"context_lines":[{"line_number":2756,"context_line":"        regex \u003d re.compile(\u0027\\[0\\:0\\] -A .* -j ACCEPT -p icmp\u0027"},{"line_number":2757,"context_line":"                           \u0027 -s 192.168.11.0/24\u0027)"},{"line_number":2758,"context_line":"        match_rules \u003d [rule for rule in self._out_rules if regex.match(rule)]"},{"line_number":2759,"context_line":"        self.assertGreater(len(match_rules), 0,"},{"line_number":2760,"context_line":"                           \"ICMP acceptance rule wasn\u0027t added\")"},{"line_number":2761,"context_line":""},{"line_number":2762,"context_line":"        regex \u003d re.compile(\u0027\\[0\\:0\\] -A .* -j ACCEPT -p icmp -m icmp\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_f2fefc36","line":2759,"range":{"start_line":2759,"start_character":31,"end_line":2759,"end_character":42},"updated":"2016-11-25 07:42:17.000000000","message":"or you could just do list(filter(regex.match, self._out_rules))","commit_id":"9e9ae877542f9587feb7df6693b2814c300d8412"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"41fe711a436c343df61b3eefbf300b94d797d9bf","unresolved":false,"context_lines":[{"line_number":2756,"context_line":"        regex \u003d re.compile(\u0027\\[0\\:0\\] -A .* -j ACCEPT -p icmp\u0027"},{"line_number":2757,"context_line":"                           \u0027 -s 192.168.11.0/24\u0027)"},{"line_number":2758,"context_line":"        match_rules \u003d [rule for rule in self._out_rules if regex.match(rule)]"},{"line_number":2759,"context_line":"        self.assertGreater(len(match_rules), 0,"},{"line_number":2760,"context_line":"                           \"ICMP acceptance rule wasn\u0027t added\")"},{"line_number":2761,"context_line":""},{"line_number":2762,"context_line":"        regex \u003d re.compile(\u0027\\[0\\:0\\] -A .* -j ACCEPT -p icmp -m icmp\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_e9a94225","line":2759,"range":{"start_line":2759,"start_character":31,"end_line":2759,"end_character":42},"in_reply_to":"5a74a57a_f2fefc36","updated":"2016-11-29 05:15:54.000000000","message":"yes, this way is also okay.\n\nI followed the section \u0027Common patterns\u0027 in  https://wiki.openstack.org/wiki/Python3.","commit_id":"9e9ae877542f9587feb7df6693b2814c300d8412"}],"nova/virt/xenapi/agent.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f6029a3b509376bd651da21f9c5656168f817496","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            ctxt \u003d context.get_admin_context()"},{"line_number":252,"context_line":"            enc \u003d crypto.ssh_encrypt_text(sshkey, new_pass)"},{"line_number":253,"context_line":"            self.instance.system_metadata.update("},{"line_number":254,"context_line":"                    password.convert_password(ctxt,"},{"line_number":255,"context_line":"                                              base64.encode_as_text(enc)))"},{"line_number":256,"context_line":"            self.instance.save()"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_96f01393","line":254,"range":{"start_line":254,"start_character":16,"end_line":254,"end_character":20},"updated":"2016-11-28 13:07:13.000000000","message":"I don\u0027t know why you changed the indentation here","commit_id":"9e9ae877542f9587feb7df6693b2814c300d8412"}]}