)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"93194d54709107b13a71b3cdc6c0b488d4bc48b7","unresolved":false,"context_lines":[{"line_number":3814,"context_line":"        return migration"},{"line_number":3815,"context_line":""},{"line_number":3816,"context_line":""},{"line_number":3817,"context_line":"@require_admin_context"},{"line_number":3818,"context_line":"def _migration_get(context, id, session\u003dNone):"},{"line_number":3819,"context_line":"    result \u003d model_query(context, models.Migration, session\u003dsession,"},{"line_number":3820,"context_line":"                         read_deleted\u003d\"yes\").\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FKco%3D","line":3817,"updated":"2013-08-06 06:08:44.000000000","message":"this decorator shouldn\u0027t be needed","commit_id":"de92084a0cf820a072d6daa9c1cecff9e1ec9515"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"212f25f3855077142b71a40f952d82fcecac7a96","unresolved":false,"context_lines":[{"line_number":3814,"context_line":"        return migration"},{"line_number":3815,"context_line":""},{"line_number":3816,"context_line":""},{"line_number":3817,"context_line":"@require_admin_context"},{"line_number":3818,"context_line":"def _migration_get(context, id, session\u003dNone):"},{"line_number":3819,"context_line":"    result \u003d model_query(context, models.Migration, session\u003dsession,"},{"line_number":3820,"context_line":"                         read_deleted\u003d\"yes\").\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FKY0%3D","line":3817,"in_reply_to":"AAAAQn%2F%2FKco%3D","updated":"2013-08-06 06:34:49.000000000","message":"agree, fixed","commit_id":"de92084a0cf820a072d6daa9c1cecff9e1ec9515"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c37a0b2368d2c8c417774841e0c0ce578fd42bd9","unresolved":false,"context_lines":[{"line_number":3815,"context_line":""},{"line_number":3816,"context_line":""},{"line_number":3817,"context_line":"@require_admin_context"},{"line_number":3818,"context_line":"def _migration_get(context, id, session\u003dNone):"},{"line_number":3819,"context_line":"    result \u003d model_query(context, models.Migration, session\u003dsession,"},{"line_number":3820,"context_line":"                         read_deleted\u003d\"yes\").\\"},{"line_number":3821,"context_line":"                     filter_by(id\u003did).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FKYk%3D","line":3818,"updated":"2013-08-06 06:36:07.000000000","message":"If this the only place calling this does not use session, then why pass the parameter?\nAm I missing something?","commit_id":"de92084a0cf820a072d6daa9c1cecff9e1ec9515"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"31f28446e502c1071919467292fa95bfcb03604a","unresolved":false,"context_lines":[{"line_number":3813,"context_line":"        return migration"},{"line_number":3814,"context_line":""},{"line_number":3815,"context_line":""},{"line_number":3816,"context_line":"def _migration_get(context, id, session\u003dNone):"},{"line_number":3817,"context_line":"    result \u003d model_query(context, models.Migration, session\u003dsession,"},{"line_number":3818,"context_line":"                         read_deleted\u003d\"yes\").\\"},{"line_number":3819,"context_line":"                     filter_by(id\u003did).\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FKYc%3D","line":3816,"updated":"2013-08-06 06:37:01.000000000","message":"Why session\u003dNone? when the parameter is not passed when using migration_get?","commit_id":"58be3dab69f05b76c8f541fa347611bcf81f82dd"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9d3d7cb8b4333be8edc44ba1559b4237cdc2d54f","unresolved":false,"context_lines":[{"line_number":3813,"context_line":"        return migration"},{"line_number":3814,"context_line":""},{"line_number":3815,"context_line":""},{"line_number":3816,"context_line":"def _migration_get(context, id, session\u003dNone):"},{"line_number":3817,"context_line":"    result \u003d model_query(context, models.Migration, session\u003dsession,"},{"line_number":3818,"context_line":"                         read_deleted\u003d\"yes\").\\"},{"line_number":3819,"context_line":"                     filter_by(id\u003did).\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FKX8%3D","line":3816,"in_reply_to":"AAAAQn%2F%2FKYE%3D","updated":"2013-08-06 06:40:04.000000000","message":"in line*","commit_id":"58be3dab69f05b76c8f541fa347611bcf81f82dd"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a1de030299443a565bfa236669ec24900b41365a","unresolved":false,"context_lines":[{"line_number":3813,"context_line":"        return migration"},{"line_number":3814,"context_line":""},{"line_number":3815,"context_line":""},{"line_number":3816,"context_line":"def _migration_get(context, id, session\u003dNone):"},{"line_number":3817,"context_line":"    result \u003d model_query(context, models.Migration, session\u003dsession,"},{"line_number":3818,"context_line":"                         read_deleted\u003d\"yes\").\\"},{"line_number":3819,"context_line":"                     filter_by(id\u003did).\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FKYE%3D","line":3816,"in_reply_to":"AAAAQn%2F%2FKYc%3D","updated":"2013-08-06 06:39:27.000000000","message":"Thanks for review. \n\n_migartion_get is used on line 3830 without session parameter, and on line 3810 with session parameter, so we are usually using session\u003dNone in this cases (to be able to pass or not session parameter)","commit_id":"58be3dab69f05b76c8f541fa347611bcf81f82dd"}]}