)]}'
{"nova/quota.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"10577b9f62bbac771203426bb50f2c41064e00d1","unresolved":false,"context_lines":[{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        Countable resources are those resources which directly"},{"line_number":1118,"context_line":"        correspond to objects in the database, i.e., instances, cores,"},{"line_number":1119,"context_line":"        etc., but for which a count by project ID is inappropriate.  A"},{"line_number":1120,"context_line":"        CountableResource must be constructed with a counting"},{"line_number":1121,"context_line":"        function, which will be called to determine the current counts"},{"line_number":1122,"context_line":"        of the resource."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_44dc8812","side":"PARENT","line":1119,"updated":"2016-12-02 02:23:06.000000000","message":"I don\u0027t think this comment is incorrect, but perhaps it\u0027s unclear to some people. It\u0027s using instances and cores as examples of resources that correspond to objects in the database. Not as examples of countable resources.","commit_id":"852baf103708ded34a8b25f2981a36fb2a8cc3fd"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b2158ef26422e8b86bb3d44234eee24be4ed35d7","unresolved":false,"context_lines":[{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        Countable resources are those resources which directly"},{"line_number":1118,"context_line":"        correspond to objects in the database, i.e., instances, cores,"},{"line_number":1119,"context_line":"        etc., but for which a count by project ID is inappropriate.  A"},{"line_number":1120,"context_line":"        CountableResource must be constructed with a counting"},{"line_number":1121,"context_line":"        function, which will be called to determine the current counts"},{"line_number":1122,"context_line":"        of the resource."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_c259d38f","side":"PARENT","line":1119,"in_reply_to":"3a71b18c_44dc8812","updated":"2016-12-06 13:09:19.000000000","message":"the logic here is incorrect \n\nI think it\u0027s \n\nCountable resources are those resources which *IS NOT* directly correspond to objects in the database,","commit_id":"852baf103708ded34a8b25f2981a36fb2a8cc3fd"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"569cbf42fc2409e2668761aadc68668fa5710877","unresolved":false,"context_lines":[{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        Countable resources are those resources which directly"},{"line_number":1118,"context_line":"        correspond to objects in the database, i.e., instances, cores,"},{"line_number":1119,"context_line":"        etc., but for which a count by project ID is inappropriate.  A"},{"line_number":1120,"context_line":"        CountableResource must be constructed with a counting"},{"line_number":1121,"context_line":"        function, which will be called to determine the current counts"},{"line_number":1122,"context_line":"        of the resource."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_bd087829","side":"PARENT","line":1119,"in_reply_to":"3a71b18c_c259d38f","updated":"2016-12-06 13:17:35.000000000","message":"ok, misunderstood, forget above comments, and maybe use another sample will make it more clear","commit_id":"852baf103708ded34a8b25f2981a36fb2a8cc3fd"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"a0867a29c4e573530e05eec806c754ed8577ca98","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"        \"\"\"Initializes a CountableResource."},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        Countable resources are those resources which directly"},{"line_number":1118,"context_line":"        correspond to objects in the database, i.e., instances, cores,"},{"line_number":1119,"context_line":"        etc., but for which a count by project ID is inappropriate.  A"},{"line_number":1120,"context_line":"        CountableResource must be constructed with a counting"},{"line_number":1121,"context_line":"        function, which will be called to determine the current counts"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_b33136ef","side":"PARENT","line":1118,"updated":"2017-03-07 10:02:41.000000000","message":"For me, examples of countable resources look more appropriate here than reservable.","commit_id":"4c5955930fb2afe2e1d245727247ab421ea633eb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"19c5a38a6d69b0e650df013db7c59a735d364239","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"    def __init__(self, name, count_as_dict, flag\u003dNone):"},{"line_number":1401,"context_line":"        \"\"\"Initializes a CountableResource."},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"        Countable resources are those resources which directly"},{"line_number":1404,"context_line":"        correspond to objects in the database, i.e., security_group_rules"},{"line_number":1405,"context_line":"        keypairs, etc., but for which a count by project ID is inappropriate."},{"line_number":1406,"context_line":"        A CountableResource must be constructed with a counting"},{"line_number":1407,"context_line":"        function, which will be called to determine the current counts"},{"line_number":1408,"context_line":"        of the resource."}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_ef5a534e","line":1405,"range":{"start_line":1403,"start_character":0,"end_line":1405,"end_character":77},"updated":"2017-06-13 10:11:42.000000000","message":"To me it sounds like we are implying that keypairs can be counted by project ID, but that is not true.\n\nMaybe:\n\n  Countable resources are those resources which directly\n  correspond to objects in the database,\n  but for which a count by project ID is inappropriate\n  e.g. security_group_rules, keypairs, etc.","commit_id":"d4c34f44e6be10ade8fc1d2dfb4bc028c7ddd90a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a996fcf01973f80e1654fd647054e3d18b80cc31","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"    def __init__(self, name, count_as_dict, flag\u003dNone):"},{"line_number":1401,"context_line":"        \"\"\"Initializes a CountableResource."},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"        Countable resources are those resources which directly"},{"line_number":1404,"context_line":"        correspond to objects in the database, i.e., security_group_rules"},{"line_number":1405,"context_line":"        keypairs, etc., but for which a count by project ID is inappropriate."},{"line_number":1406,"context_line":"        A CountableResource must be constructed with a counting"},{"line_number":1407,"context_line":"        function, which will be called to determine the current counts"},{"line_number":1408,"context_line":"        of the resource."}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_2596df40","line":1405,"range":{"start_line":1403,"start_character":0,"end_line":1405,"end_character":77},"in_reply_to":"7f231b9d_ef5a534e","updated":"2017-06-15 09:32:19.000000000","message":"ok, thanks, will modify it","commit_id":"d4c34f44e6be10ade8fc1d2dfb4bc028c7ddd90a"}]}