)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b38d4873bbd42bd1e12e104770ba04a5e036094d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add host to vif.py set_config_* functions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change extends the function signture"},{"line_number":10,"context_line":"  of the vif.py set_config_* functions to"},{"line_number":11,"context_line":"  optionally accepth the host object."},{"line_number":12,"context_line":"- This is required to support host specifc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_b56af318","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":43},"updated":"2016-12-01 20:20:48.000000000","message":"signature","commit_id":"4b5b3c2e667f719cf9dcbd7c0b5b4ba05e2e5def"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6fa2bc64f7bdffc191edb96bb9832ecff0206117","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change extends the function signture"},{"line_number":10,"context_line":"  of the vif.py set_config_* functions to"},{"line_number":11,"context_line":"  optionally accepth the host object."},{"line_number":12,"context_line":"- This is required to support host specifc"},{"line_number":13,"context_line":"  features that depend on the vif type chosen"},{"line_number":14,"context_line":"  e.g. vhost-user and multiqueue"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_8100b667","line":11,"updated":"2016-12-06 14:32:35.000000000","message":"s/accepth/accept/","commit_id":"4b5b3c2e667f719cf9dcbd7c0b5b4ba05e2e5def"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b38d4873bbd42bd1e12e104770ba04a5e036094d","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        conf.target_dev \u003d vif.vif_name"},{"line_number":446,"context_line":"        self._set_config_VIFPortProfile(instance, vif, conf)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _set_config_VIFPortProfileOpenVSwitch(self, profile, conf):"},{"line_number":449,"context_line":"        conf.vporttype \u003d \"openvswitch\""},{"line_number":450,"context_line":"        conf.add_vport_param(\"interfaceid\","},{"line_number":451,"context_line":"                             profile.interface_id)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def _set_config_VIFPortProfile(self, instance, vif, conf):"},{"line_number":454,"context_line":"        # Set any port profile that may be required"},{"line_number":455,"context_line":"        profilefunc \u003d \"_set_config_\" + vif.port_profile.obj_name()"},{"line_number":456,"context_line":"        func \u003d getattr(self, profilefunc, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_55b6ff8a","line":453,"range":{"start_line":448,"start_character":4,"end_line":453,"end_character":62},"updated":"2016-12-01 20:20:48.000000000","message":"So I guess even though these look similar, we don\u0027t care about them because they won\u0027t be called from L489? i.e. _set_config_VIFOpenVSwitch calls _set_config_VIFPortProfile which calls _set_config_VIFPortProfileOpenVSwitch.","commit_id":"4b5b3c2e667f719cf9dcbd7c0b5b4ba05e2e5def"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dc1f271317d4e957d6ba5c3774b93f5a8f3fbbf5","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        conf.target_dev \u003d vif.vif_name"},{"line_number":446,"context_line":"        self._set_config_VIFPortProfile(instance, vif, conf)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _set_config_VIFPortProfileOpenVSwitch(self, profile, conf):"},{"line_number":449,"context_line":"        conf.vporttype \u003d \"openvswitch\""},{"line_number":450,"context_line":"        conf.add_vport_param(\"interfaceid\","},{"line_number":451,"context_line":"                             profile.interface_id)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def _set_config_VIFPortProfile(self, instance, vif, conf):"},{"line_number":454,"context_line":"        # Set any port profile that may be required"},{"line_number":455,"context_line":"        profilefunc \u003d \"_set_config_\" + vif.port_profile.obj_name()"},{"line_number":456,"context_line":"        func \u003d getattr(self, profilefunc, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_15180784","line":453,"range":{"start_line":448,"start_character":4,"end_line":453,"end_character":62},"in_reply_to":"3a71b18c_55b6ff8a","updated":"2016-12-01 20:27:10.000000000","message":"yes that is correct.\nas they wont be called on 489 i did not extend them as currently they dont require the host object","commit_id":"4b5b3c2e667f719cf9dcbd7c0b5b4ba05e2e5def"}]}