)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4430240d11003cbc365fed8c0b8f2fbda71c0aac","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        LOG.debug(\"attach device xml: %s\", device_xml)"},{"line_number":300,"context_line":"        self._domain.attachDeviceFlags(device_xml, flags\u003dflags)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def get_disk_by_target_device(self, target_device):"},{"line_number":303,"context_line":"        \"\"\"Returns the disk mounted at device"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        :returns LivirtConfigGuestDisk: Found at the target device or None"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_dc9084ef","line":302,"updated":"2017-01-13 11:44:30.000000000","message":"Incidentally, I\u0027m in favour of this name change because it\u0027s more explicit about what it does. As discussed on IRC, this won\u0027t work for filesystems. This name change makes that more obvious. I\u0027d probably put it in a separate little cleanup patch, though, esp as it\u0027s a non-functional change.","commit_id":"efa7a5cfd2ad62284d81920f2d3f8977d51ab920"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4439a055d79d46463d7e64fd128785fde91d1484","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        except Exception:"},{"line_number":310,"context_line":"            return None"},{"line_number":311,"context_line":"        node \u003d doc.find(\"./devices/disk/target[@dev\u003d\u0027%s\u0027]..\" % target_device)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if node is not None:"},{"line_number":314,"context_line":"            conf \u003d vconfig.LibvirtConfigGuestDisk()"},{"line_number":315,"context_line":"            conf.parse_dom(node)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_1c792c94","line":312,"updated":"2017-01-13 11:28:25.000000000","message":"Random whitespace change.","commit_id":"efa7a5cfd2ad62284d81920f2d3f8977d51ab920"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4439a055d79d46463d7e64fd128785fde91d1484","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            conf \u003d vconfig.LibvirtConfigGuestDisk()"},{"line_number":315,"context_line":"            conf.parse_dom(node)"},{"line_number":316,"context_line":"            return conf"},{"line_number":317,"context_line":"        return None"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def get_all_disks(self):"},{"line_number":320,"context_line":"        \"\"\"Returns all the disks for a guest"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_9c3efcb6","line":317,"updated":"2017-01-13 11:28:25.000000000","message":"Not strictly required as return None is implicit, but explicit (ie this) is best imho. Not sure my view is universal, though.","commit_id":"efa7a5cfd2ad62284d81920f2d3f8977d51ab920"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"3d57a3d201aecdbc42cd1ed0e32994f3cff3c866","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def __init__(self, guest, target_dev):"},{"line_number":653,"context_line":"        self._guest \u003d guest"},{"line_number":654,"context_line":"        self.target_dev \u003d target_dev"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def abort_job(self, async\u003dFalse, pivot\u003dFalse):"},{"line_number":657,"context_line":"        \"\"\"Request to cancel a live block device job"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_72ced784","line":654,"updated":"2017-01-13 12:07:55.000000000","message":"LibvirtDriver callers previously called get_block_device() with either a target device name or a path. With your change, they all now use a target device name. While the underlying libvirt api allows either, I think this approach of robustly encouraging just one is good.","commit_id":"efa7a5cfd2ad62284d81920f2d3f8977d51ab920"}]}