)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10511,"name":"Ligong Duan","email":"duanlg@live.cn","username":"duanlg"},"change_message_id":"6a3c1711a7db7b1be34eb4642189ab0950df5fbe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"it\u0027s like \"root_disk+\"-\"+\"*.vmdk\"."},{"line_number":14,"context_line":"so i add the conditional verify two scene."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"and the old code not follow pep8 style,i change to pep8 style"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"closes-bug: 1634340"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a74a57a_3b40a407","line":16,"range":{"start_line":16,"start_character":56,"end_line":16,"end_character":61},"updated":"2016-11-30 06:04:26.000000000","message":"How about changing the commit messages into the following:\n\"Add condition check for getting root device to accommodate itself for the case of VM snapshot of VMware, because the format is like \"root_disk_\u003cnumber\u003e.vmdk\". And also fix the pep8 style check error in the same file\"","commit_id":"19c326f2755a87ec41d83096c5bc35c51268d78f"},{"author":{"_account_id":10511,"name":"Ligong Duan","email":"duanlg@live.cn","username":"duanlg"},"change_message_id":"6a3c1711a7db7b1be34eb4642189ab0950df5fbe","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"and the old code not follow pep8 style,i change to pep8 style"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"closes-bug: 1634340"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib5a0ac7dcaf2568f2aa75dbbda8c24addfb50291"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a74a57a_9bab78d6","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":19},"updated":"2016-11-30 06:04:26.000000000","message":"The conventional format is \"Closes-Bug: #1634340\".","commit_id":"19c326f2755a87ec41d83096c5bc35c51268d78f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8e9e064cdc044e6ab379c217b9b68ba0c24740d5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     YuYang \u003cyuyangwang1985@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-08 17:42:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware:fix get vm\u0027root deivce conditional verify"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the old code in \"class /nova/virt/vmwareapi/vm_util.py method : get_vmdk_info \","},{"line_number":10,"context_line":"verify is the root deivce only use \"path.basename \u003d\u003d root_disk+\".vmdk\","}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a71b18c_b9436912","line":7,"updated":"2016-12-10 13:42:25.000000000","message":"s/vm\u0027root deivce/VM root device/","commit_id":"749a252544145f417d60a8b4f22656ad71794c78"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8e9e064cdc044e6ab379c217b9b68ba0c24740d5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware:fix get vm\u0027root deivce conditional verify"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the old code in \"class /nova/virt/vmwareapi/vm_util.py method : get_vmdk_info \","},{"line_number":10,"context_line":"verify is the root deivce only use \"path.basename \u003d\u003d root_disk+\".vmdk\","},{"line_number":11,"context_line":"but when i use vm task snapshot ,"},{"line_number":12,"context_line":"the root deivce not like \"disk name +.vmdk\","},{"line_number":13,"context_line":"it\u0027s like \"root_disk+\"-\"+\"*.vmdk\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a71b18c_19537de3","line":10,"updated":"2016-12-10 13:42:25.000000000","message":"s/verify is/verifies/\n\ns/deivce only use/device uses/","commit_id":"749a252544145f417d60a8b4f22656ad71794c78"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8e9e064cdc044e6ab379c217b9b68ba0c24740d5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the old code in \"class /nova/virt/vmwareapi/vm_util.py method : get_vmdk_info \","},{"line_number":10,"context_line":"verify is the root deivce only use \"path.basename \u003d\u003d root_disk+\".vmdk\","},{"line_number":11,"context_line":"but when i use vm task snapshot ,"},{"line_number":12,"context_line":"the root deivce not like \"disk name +.vmdk\","},{"line_number":13,"context_line":"it\u0027s like \"root_disk+\"-\"+\"*.vmdk\"."},{"line_number":14,"context_line":"so Add condition check for getting root device to accommodate itself"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a71b18c_595fb5e4","line":11,"updated":"2016-12-10 13:42:25.000000000","message":"s/i use vm task snapshot ,/one snapshots a VM/","commit_id":"749a252544145f417d60a8b4f22656ad71794c78"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8e9e064cdc044e6ab379c217b9b68ba0c24740d5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"the old code in \"class /nova/virt/vmwareapi/vm_util.py method : get_vmdk_info \","},{"line_number":10,"context_line":"verify is the root deivce only use \"path.basename \u003d\u003d root_disk+\".vmdk\","},{"line_number":11,"context_line":"but when i use vm task snapshot ,"},{"line_number":12,"context_line":"the root deivce not like \"disk name +.vmdk\","},{"line_number":13,"context_line":"it\u0027s like \"root_disk+\"-\"+\"*.vmdk\"."},{"line_number":14,"context_line":"so Add condition check for getting root device to accommodate itself"},{"line_number":15,"context_line":"for the case of VM snapshot of VMware, because the format is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a71b18c_b95a89f0","line":12,"updated":"2016-12-10 13:42:25.000000000","message":"s/deivce not like \"disk name + .vmdk\"/device has an different filepath from a normal image filepath/","commit_id":"749a252544145f417d60a8b4f22656ad71794c78"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8e9e064cdc044e6ab379c217b9b68ba0c24740d5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"but when i use vm task snapshot ,"},{"line_number":12,"context_line":"the root deivce not like \"disk name +.vmdk\","},{"line_number":13,"context_line":"it\u0027s like \"root_disk+\"-\"+\"*.vmdk\"."},{"line_number":14,"context_line":"so Add condition check for getting root device to accommodate itself"},{"line_number":15,"context_line":"for the case of VM snapshot of VMware, because the format is"},{"line_number":16,"context_line":"like \"root_disk_\u003cnumber\u003e.vmdk\"."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a71b18c_d973c57e","line":14,"updated":"2016-12-10 13:42:25.000000000","message":"s/so Add condition check .../This patch enables get_root_device() to work for both normal and snapshot filepaths./","commit_id":"749a252544145f417d60a8b4f22656ad71794c78"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":10511,"name":"Ligong Duan","email":"duanlg@live.cn","username":"duanlg"},"change_message_id":"cf05d8cd1a816d55c15e896b2ccb5c9dae1b8ac1","unresolved":false,"context_lines":[{"line_number":646,"context_line":"            if device.backing.__class__.__name__ \u003d\u003d \\"},{"line_number":647,"context_line":"                    \"VirtualDiskFlatVer2BackingInfo\":"},{"line_number":648,"context_line":"                path \u003d ds_obj.DatastorePath.parse(device.backing.fileName)"},{"line_number":649,"context_line":"\t\tif root_disk and (path.basename \u003d\u003d root_disk+\".vmdk\" or path.basename.startswith(root_disk+\"-\")):"},{"line_number":650,"context_line":"                    root_device \u003d device"},{"line_number":651,"context_line":"                vmdk_device \u003d device"},{"line_number":652,"context_line":"        elif device.__class__.__name__ \u003d\u003d \"VirtualLsiLogicController\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_3e220401","line":649,"range":{"start_line":649,"start_character":92,"end_line":649,"end_character":99},"updated":"2016-11-25 03:10:16.000000000","message":"The source code must comply with python pep8 style, and otherwise pep8 check will report errors. \nhttps://www.python.org/dev/peps/pep-0008/","commit_id":"26992b3412f8c4eb1454ac4258f23efe0ef28d5c"},{"author":{"_account_id":10511,"name":"Ligong Duan","email":"duanlg@live.cn","username":"duanlg"},"change_message_id":"0aa4782292fd96c1a4fe713fbcabe16a99eb7a90","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            if device.backing.__class__.__name__ \u003d\u003d \\"},{"line_number":652,"context_line":"                    \"VirtualDiskFlatVer2BackingInfo\":"},{"line_number":653,"context_line":"                path \u003d ds_obj.DatastorePath.parse(device.backing.fileName)"},{"line_number":654,"context_line":"                if root_disk and (path.basename \u003d\u003d root_disk+\".vmdk\""},{"line_number":655,"context_line":"                                  or"},{"line_number":656,"context_line":"                                  path.basename.startswith(root_disk + \"-\")):"},{"line_number":657,"context_line":"                    root_device \u003d device"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_3b0ee4e5","line":654,"range":{"start_line":654,"start_character":51,"end_line":654,"end_character":60},"updated":"2016-11-30 06:08:04.000000000","message":"There should be an pep8 check error:\n  missing whitespace around arithmetic operator\n\nPlease fix it","commit_id":"19c326f2755a87ec41d83096c5bc35c51268d78f"},{"author":{"_account_id":24248,"name":"mingyong_chan","email":"chenmy@winhong.com","username":"ChenMingyong"},"change_message_id":"c84a9810c555ef788babdc36da8b0f2aaae3a0dc","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            if device.backing.__class__.__name__ \u003d\u003d \\"},{"line_number":652,"context_line":"                    \"VirtualDiskFlatVer2BackingInfo\":"},{"line_number":653,"context_line":"                path \u003d ds_obj.DatastorePath.parse(device.backing.fileName)"},{"line_number":654,"context_line":"                if root_disk and (path.basename \u003d\u003d root_disk + \".vmdk\""},{"line_number":655,"context_line":"                                  or"},{"line_number":656,"context_line":"                                  path.basename.startswith(root_disk + \"-\")):"},{"line_number":657,"context_line":"                    root_device \u003d device"},{"line_number":658,"context_line":"                vmdk_device \u003d device"},{"line_number":659,"context_line":"        elif device.__class__.__name__ \u003d\u003d \"VirtualLsiLogicController\":"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_88dbec1a","line":656,"range":{"start_line":654,"start_character":0,"end_line":656,"end_character":77},"updated":"2016-12-01 07:18:29.000000000","message":"the disk name of VMware  generally have a  \".vmdk\" suffix","commit_id":"6f8cb7e7d688582bc314f20634d4a3aa34fdcb0e"}]}