)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"631e7d4e62ba386b87c4fdb7b890f637a02df300","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a handful of ways to generate a LibvirtConfigCapsNUMATopology"},{"line_number":10,"context_line":"for use in testing. Standardize them and kill the duplication. This"},{"line_number":11,"context_line":"requires explicitly configuring huge pages for the NUMA topology in some"},{"line_number":12,"context_line":"places, but that seems like \"A Good Thing\" (TM)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1efd99afbed23f64b7ba61d2cf449b2a48689baa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a74a57a_36ed0d8f","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":42},"updated":"2016-11-30 11:56:40.000000000","message":"if mempages \u003d None, fallback to 4k pages. I think you mean the mempages will be set anyway for cells, HUGE pages under request.","commit_id":"65a5e0c03a14746385d1a4f5724eb80bc4f11e9e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"872a76458ba28d28c68e11f0a9e828473d42e4ea","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a handful of ways to generate a LibvirtConfigCapsNUMATopology"},{"line_number":10,"context_line":"for use in testing. Standardize them and kill the duplication. This"},{"line_number":11,"context_line":"requires explicitly configuring huge pages for the NUMA topology in some"},{"line_number":12,"context_line":"places, but that seems like \"A Good Thing\" (TM)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1efd99afbed23f64b7ba61d2cf449b2a48689baa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a6eadb0_9a7a00f0","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":42},"in_reply_to":"5a74a57a_36ed0d8f","updated":"2016-12-15 14:58:02.000000000","message":"changed to \u0027mempages\u0027","commit_id":"65a5e0c03a14746385d1a4f5724eb80bc4f11e9e"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"631e7d4e62ba386b87c4fdb7b890f637a02df300","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class NumaHostInfo(fakelibvirt.HostInfo):"},{"line_number":36,"context_line":"    def __init__(self, **kwargs):"},{"line_number":37,"context_line":"        super(NumaHostInfo, self).__init__(**kwargs)"},{"line_number":38,"context_line":"        self.numa_mempages_list \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_numa_topology(self):"},{"line_number":41,"context_line":"        if self.numa_topology:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_d6ca196e","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":31},"updated":"2016-11-30 11:56:40.000000000","message":"This is no longer required since mempages now is part of the NUMATopology.","commit_id":"65a5e0c03a14746385d1a4f5724eb80bc4f11e9e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"872a76458ba28d28c68e11f0a9e828473d42e4ea","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class NumaHostInfo(fakelibvirt.HostInfo):"},{"line_number":36,"context_line":"    def __init__(self, **kwargs):"},{"line_number":37,"context_line":"        super(NumaHostInfo, self).__init__(**kwargs)"},{"line_number":38,"context_line":"        self.numa_mempages_list \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_numa_topology(self):"},{"line_number":41,"context_line":"        if self.numa_topology:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_1a043048","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":31},"in_reply_to":"3a71b18c_3b13585e","updated":"2016-12-15 14:58:02.000000000","message":"Done","commit_id":"65a5e0c03a14746385d1a4f5724eb80bc4f11e9e"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"740db0de758fabe526f631c0bd330acda410887f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class NumaHostInfo(fakelibvirt.HostInfo):"},{"line_number":36,"context_line":"    def __init__(self, **kwargs):"},{"line_number":37,"context_line":"        super(NumaHostInfo, self).__init__(**kwargs)"},{"line_number":38,"context_line":"        self.numa_mempages_list \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_numa_topology(self):"},{"line_number":41,"context_line":"        if self.numa_topology:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_3b13585e","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":31},"in_reply_to":"5a74a57a_d6ca196e","updated":"2016-12-01 10:08:12.000000000","message":"will be removed in next patch https://review.openstack.org/#/c/402562/4","commit_id":"65a5e0c03a14746385d1a4f5724eb80bc4f11e9e"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"631e7d4e62ba386b87c4fdb7b890f637a02df300","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class NumaHostInfo(fakelibvirt.HostInfo):"},{"line_number":34,"context_line":"    def __init__(self, **kwargs):"},{"line_number":35,"context_line":"        super(NumaHostInfo, self).__init__(**kwargs)"},{"line_number":36,"context_line":"        self.numa_mempages_list \u003d []"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_numa_topology(self):"},{"line_number":39,"context_line":"        if self.numa_topology:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_7698656b","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":31},"updated":"2016-11-30 11:56:40.000000000","message":"no longer used?","commit_id":"65a5e0c03a14746385d1a4f5724eb80bc4f11e9e"}],"nova/tests/functional/libvirt/test_rt_servers.py":[{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"631e7d4e62ba386b87c4fdb7b890f637a02df300","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class NumaHostInfo(fakelibvirt.HostInfo):"},{"line_number":28,"context_line":"    def __init__(self, **kwargs):"},{"line_number":29,"context_line":"        super(NumaHostInfo, self).__init__(**kwargs)"},{"line_number":30,"context_line":"        self.numa_mempages_list \u003d []"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_numa_topology(self):"},{"line_number":33,"context_line":"        if self.numa_topology:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_f6ac758e","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":31},"updated":"2016-11-30 11:56:40.000000000","message":"remove me","commit_id":"65a5e0c03a14746385d1a4f5724eb80bc4f11e9e"}],"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4f64206c63e8c980eb71fd43ec6f1058f2a00b21","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        self.numa_topology \u003d numa_topology"},{"line_number":330,"context_line":"        self.disabled_cpus_list \u003d cpu_disabled or []"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @classmethod"},{"line_number":333,"context_line":"    def _gen_numa_topology(cls, cpu_nodes, cpu_sockets, cpu_cores,"},{"line_number":334,"context_line":"                           cpu_threads, kb_mem, numa_mempages_list\u003dNone):"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_d9c67d48","side":"PARENT","line":332,"updated":"2017-02-06 19:15:30.000000000","message":"++\n\nSay No to @classmethods that aren\u0027t class methods (and @staticmethods on classes for no reason).","commit_id":"33fbf35b211cfceee68258580832dd23c36444a3"}]}