)]}'
{"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"27e7b604f41740c32f25cb8f274fc763558b8090","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                % CONF.vmware.datastore_regex)"},{"line_number":421,"context_line":"        self._volumeops \u003d volumeops.VMwareVolumeOps(self._session,"},{"line_number":422,"context_line":"                                                    self._cluster)"},{"line_number":423,"context_line":"        self._vmops \u003d vmops.VMwareVCVMOps(self._session, self.virtapi,"},{"line_number":424,"context_line":"                                          self._volumeops, self._cluster,"},{"line_number":425,"context_line":"                                          self._datastore_regex)"},{"line_number":426,"context_line":"        self._vc_state \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F9Dw%3D","line":423,"updated":"2013-08-27 15:51:45.000000000","message":"good. We have other areas which need to be able to be swapped out at init time just like this. Overall this will be a good strategy for a \"pluggable\" driver.","commit_id":"2a4c141d2f5199b966538e0b45302820bfe08581"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e6e5aacd150c768574ed022621e78b0f42030a98","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                _(\"Invalid Regular Expression %s\")"},{"line_number":403,"context_line":"                % CONF.vmware.datastore_regex)"},{"line_number":404,"context_line":"        self._volumeops \u003d volumeops.VMwareVolumeOps(self._session,"},{"line_number":405,"context_line":"                                                    self._cluster)"},{"line_number":406,"context_line":"        self._vmops \u003d vmops.VMwareVCVMOps(self._session, self.virtapi,"},{"line_number":407,"context_line":"                                          self._volumeops, self._cluster,"},{"line_number":408,"context_line":"                                          self._datastore_regex)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FVWI%3D","line":405,"updated":"2013-09-06 06:08:59.000000000","message":"The vc_support\u003dTrue was dropped here. This is required for the cinder support.","commit_id":"847beee960d8e5b686ed275ee7e4f7417a97fd4e"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"c60258407169b26c833a562297dd7b696d44983b","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                _(\"Invalid Regular Expression %s\")"},{"line_number":403,"context_line":"                % CONF.vmware.datastore_regex)"},{"line_number":404,"context_line":"        self._volumeops \u003d volumeops.VMwareVolumeOps(self._session,"},{"line_number":405,"context_line":"                                                    self._cluster)"},{"line_number":406,"context_line":"        self._vmops \u003d vmops.VMwareVCVMOps(self._session, self.virtapi,"},{"line_number":407,"context_line":"                                          self._volumeops, self._cluster,"},{"line_number":408,"context_line":"                                          self._datastore_regex)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FVRU%3D","line":405,"in_reply_to":"AAAASn%2F%2FVWI%3D","updated":"2013-09-06 06:46:21.000000000","message":"Probably from a conflict resolution earlier. Thanks for catching.","commit_id":"847beee960d8e5b686ed275ee7e4f7417a97fd4e"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"27e7b604f41740c32f25cb8f274fc763558b8090","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"        pass"},{"line_number":1345,"context_line":""},{"line_number":1346,"context_line":""},{"line_number":1347,"context_line":"class VMwareVCVMOps(VMwareVMOps):"},{"line_number":1348,"context_line":"    \"\"\"Management class for VM-related tasks."},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"    Contains specializations to account for differences in vSphere API behavior"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F9Fc%3D","line":1347,"updated":"2013-08-27 15:51:45.000000000","message":"This is a good direction. Hopefully, this class stays small.","commit_id":"2a4c141d2f5199b966538e0b45302820bfe08581"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"fb34118accb55bcba9cc8463dda4f8e3cb787f1c","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"    when invoked on Virtual Center instead of ESX host."},{"line_number":1352,"context_line":"    \"\"\""},{"line_number":1353,"context_line":""},{"line_number":1354,"context_line":"    def _get_copy_virtual_disk_spec(self, client_factory, adapter_type,"},{"line_number":1355,"context_line":"                                    disk_type):"},{"line_number":1356,"context_line":"        LOG.debug(_(\"Will copy while retaining adapter type \""},{"line_number":1357,"context_line":"                    \"%(adapter_type)s and disk type %(disk_type)s\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F9Gw%3D","line":1354,"updated":"2013-08-27 15:44:52.000000000","message":"just a question here - could\u0027t this be a @staticmethod?","commit_id":"2a4c141d2f5199b966538e0b45302820bfe08581"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e6e5aacd150c768574ed022621e78b0f42030a98","unresolved":false,"context_lines":[{"line_number":1442,"context_line":"        # VirtualDiskManager.CopyVirtualDisk is called on VC. The behavior of a"},{"line_number":1443,"context_line":"        # spec-less copy is to consolidate to the target disk while keeping its"},{"line_number":1444,"context_line":"        # disk and adapter type unchanged."},{"line_number":1445,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FVV8%3D","line":1445,"updated":"2013-09-06 06:08:59.000000000","message":"By default the method returns None. I do not think that we need this specific return None.","commit_id":"847beee960d8e5b686ed275ee7e4f7417a97fd4e"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"c60258407169b26c833a562297dd7b696d44983b","unresolved":false,"context_lines":[{"line_number":1442,"context_line":"        # VirtualDiskManager.CopyVirtualDisk is called on VC. The behavior of a"},{"line_number":1443,"context_line":"        # spec-less copy is to consolidate to the target disk while keeping its"},{"line_number":1444,"context_line":"        # disk and adapter type unchanged."},{"line_number":1445,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FVRE%3D","line":1445,"in_reply_to":"AAAASn%2F%2FVV8%3D","updated":"2013-09-06 06:46:21.000000000","message":"Yep, thanks.","commit_id":"847beee960d8e5b686ed275ee7e4f7417a97fd4e"}],"nova/virt/vmwareapi/vmware_images.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"27e7b604f41740c32f25cb8f274fc763558b8090","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    # The properties and other fields that we need to set for the image."},{"line_number":126,"context_line":"    image_metadata \u003d {\"disk_format\": \"vmdk\","},{"line_number":127,"context_line":"                      \"is_public\": \"false\","},{"line_number":128,"context_line":"                      \"name\": kwargs.get(\"snapshot_name\"),"},{"line_number":129,"context_line":"                      \"status\": \"active\","},{"line_number":130,"context_line":"                      \"container_format\": \"bare\","},{"line_number":131,"context_line":"                      \"size\": file_size,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F9Es%3D","side":"PARENT","line":128,"updated":"2013-08-27 15:51:45.000000000","message":"Good. None of the other drivers use this concept of a \"snapshot_name\"","commit_id":"7478574573fe5b94072543375108cce9cde8efc9"}]}