)]}'
{"nova/rpc/impl_kombu.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"0c794e89adb23b11b13e21e1be27e6e59dee3c00","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        # Used in the unit test, also may be useful"},{"line_number":367,"context_line":"        # in the future for others that want to check it"},{"line_number":368,"context_line":"        self.using_ssl \u003d FLAGS.rabbit_use_ssl"},{"line_number":369,"context_line":"        if self.using_ssl:"},{"line_number":370,"context_line":"            self.params[\u0027ssl\u0027] \u003d self._fetch_ssl_params()"},{"line_number":371,"context_line":"        # Make connection happen"},{"line_number":372,"context_line":"        self.connection \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F40E%3D","line":369,"updated":"2012-02-20 07:48:00.000000000","message":"I think we should just remove using_ssl; see my comment in the unit test","commit_id":"c97fd8bc87b6f03d1706e5245c8e0012127f31b1"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"0c794e89adb23b11b13e21e1be27e6e59dee3c00","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        self.using_ssl \u003d FLAGS.rabbit_use_ssl"},{"line_number":369,"context_line":"        if self.using_ssl:"},{"line_number":370,"context_line":"            self.params[\u0027ssl\u0027] \u003d self._fetch_ssl_params()"},{"line_number":371,"context_line":"        # Make connection happen"},{"line_number":372,"context_line":"        self.connection \u003d None"},{"line_number":373,"context_line":"        self.reconnect()"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F40A%3D","line":371,"updated":"2012-02-20 07:48:00.000000000","message":"This comment has no value","commit_id":"c97fd8bc87b6f03d1706e5245c8e0012127f31b1"}],"nova/tests/rpc/test_kombu_ssl.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7e12472f147158adad1c9489bd6c875bb5d46201","unresolved":false,"context_lines":[{"line_number":35,"context_line":"SSL_VERSION \u003d \"SSLv2\""},{"line_number":36,"context_line":"flags.DECLARE(\"kombu_ssl_version\", \"\")"},{"line_number":37,"context_line":"FLAGS[\u0027kombu_ssl_version\u0027].SetDefault(SSL_VERSION)"},{"line_number":38,"context_line":" "},{"line_number":39,"context_line":"SSL_CERT \u003d \"/tmp/cert.blah.blah\""},{"line_number":40,"context_line":"flags.DECLARE(\"kombu_ssl_certfile\", \"\")"},{"line_number":41,"context_line":"FLAGS[\u0027kombu_ssl_certfile\u0027].SetDefault(SSL_CERT)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F5YM%3D","line":38,"updated":"2012-02-17 19:14:22.000000000","message":"You\u0027ve got trailing whitespace here that will cause PEP8 to fail.","commit_id":"981d99e50cf07e28f2e45c7b360f8330b7f25b6e"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"0c794e89adb23b11b13e21e1be27e6e59dee3c00","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#This is flags that are not set in the fake flags test (so turn them on)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":32,"context_line":"flags.DECLARE(\"rabbit_use_ssl\", \u0027\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SSL_VERSION \u003d \"SSLv2\""},{"line_number":35,"context_line":"flags.DECLARE(\"kombu_ssl_version\", \"nova.rpc.impl_kombu\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F40Y%3D","line":32,"updated":"2012-02-20 07:48:00.000000000","message":"DECLARE makes no sense with an empty second argument","commit_id":"c97fd8bc87b6f03d1706e5245c8e0012127f31b1"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"0c794e89adb23b11b13e21e1be27e6e59dee3c00","unresolved":false,"context_lines":[{"line_number":32,"context_line":"flags.DECLARE(\"rabbit_use_ssl\", \u0027\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SSL_VERSION \u003d \"SSLv2\""},{"line_number":35,"context_line":"flags.DECLARE(\"kombu_ssl_version\", \"nova.rpc.impl_kombu\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"SSL_CERT \u003d \"/tmp/cert.blah.blah\""},{"line_number":38,"context_line":"flags.DECLARE(\"kombu_ssl_certfile\", \"nova.rpc.impl_kombu\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F40U%3D","line":35,"updated":"2012-02-20 07:48:00.000000000","message":"And these ones aren\u0027t needed since they just re-import impl_kombu","commit_id":"c97fd8bc87b6f03d1706e5245c8e0012127f31b1"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"0c794e89adb23b11b13e21e1be27e6e59dee3c00","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        FLAGS.set_override(\u0027kombu_ssl_ca_certs\u0027, SSL_CA_CERT)"},{"line_number":55,"context_line":"        FLAGS.set_override(\u0027kombu_ssl_certfile\u0027, SSL_CERT)"},{"line_number":56,"context_line":"        FLAGS.set_override(\u0027kombu_ssl_version\u0027, SSL_VERSION)"},{"line_number":57,"context_line":"        FLAGS.set_override(\u0027rabbit_use_ssl\u0027, True)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def tearDown(self):"},{"line_number":60,"context_line":"        test.TestCase.tearDown(self)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F40Q%3D","line":57,"updated":"2012-02-20 07:48:00.000000000","message":"The right way to do this is:\n\n    self.flags(kombu_ssl_keyfile\u003dSSL_KEYFILE,\n                  kombu_ssl_ca_certs\u003dSSL_CA_CERT,\n                  ...)","commit_id":"c97fd8bc87b6f03d1706e5245c8e0012127f31b1"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"0c794e89adb23b11b13e21e1be27e6e59dee3c00","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        FLAGS.set_override(\u0027kombu_ssl_keyfile\u0027, \u0027\u0027)"},{"line_number":63,"context_line":"        FLAGS.set_override(\u0027kombu_ssl_version\u0027, \u0027\u0027)"},{"line_number":64,"context_line":"        FLAGS.set_override(\u0027kombu_ssl_ca_certs\u0027, \u0027\u0027)"},{"line_number":65,"context_line":"        FLAGS.set_override(\u0027kombu_ssl_certfile\u0027, \u0027\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_ssl_on_basic(self):"},{"line_number":68,"context_line":"        rpc \u003d impl_kombu"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F40M%3D","line":65,"updated":"2012-02-20 07:48:00.000000000","message":"If you use self.flags(), this teardDown() method won\u0027t be needed at all","commit_id":"c97fd8bc87b6f03d1706e5245c8e0012127f31b1"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"0c794e89adb23b11b13e21e1be27e6e59dee3c00","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        rpc \u003d impl_kombu"},{"line_number":69,"context_line":"        conn \u003d rpc.create_connection(True)"},{"line_number":70,"context_line":"        c \u003d conn.connection"},{"line_number":71,"context_line":"        self.assertTrue(c.using_ssl)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_ssl_on_extended(self):"},{"line_number":74,"context_line":"        rpc \u003d impl_kombu"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F40I%3D","line":71,"updated":"2012-02-20 07:48:00.000000000","message":"I don\u0027t think this test adds anything beyond the below test - I\u0027d prefer to just see the test and the using_ssl property removed","commit_id":"c97fd8bc87b6f03d1706e5245c8e0012127f31b1"}]}