)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae20f7120e5708798d5f9d932f60ef79648a12b9","unresolved":false,"context_lines":[{"line_number":1886,"context_line":""},{"line_number":1887,"context_line":"    # Set the VF\u0027s mac address and vlan"},{"line_number":1888,"context_line":"    exit_code \u003d [0, 2, 254]"},{"line_number":1889,"context_line":"    port_state \u003d \u0027up\u0027 if int(vlan) \u003e 0 else \u0027down\u0027"},{"line_number":1890,"context_line":"    utils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, pf_ifname,"},{"line_number":1891,"context_line":"                  \u0027vf\u0027, vf_num,"},{"line_number":1892,"context_line":"                  \u0027mac\u0027, mac_addr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_5b7a69f2","line":1889,"range":{"start_line":1889,"start_character":29,"end_line":1889,"end_character":33},"updated":"2016-12-03 11:53:54.000000000","message":"it should be integer only, object field are same - https://github.com/openstack/nova/blob/master/nova/objects/network.py#L54\n\nWe should fix tests sending str instead of int cast here.","commit_id":"a68c1c436fa3ecdc5a1242ed670a8ae3112aee38"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae20f7120e5708798d5f9d932f60ef79648a12b9","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                                   vnic_type\u003dnetwork_model.VNIC_TYPE_DIRECT,"},{"line_number":204,"context_line":"                                   ovs_interfaceid\u003dNone,"},{"line_number":205,"context_line":"                                   details\u003d{"},{"line_number":206,"context_line":"                                       network_model.VIF_DETAILS_VLAN: \u0027100\u0027},"},{"line_number":207,"context_line":"                                   profile\u003d{\u0027pci_vendor_info\u0027: \u00271137:0043\u0027,"},{"line_number":208,"context_line":"                                            \u0027pci_slot\u0027: \u00270000:0a:00.1\u0027,"},{"line_number":209,"context_line":"                                            \u0027physical_network\u0027: \u0027phynet1\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_5bc8a922","line":206,"range":{"start_line":206,"start_character":71,"end_line":206,"end_character":76},"updated":"2016-12-03 11:53:54.000000000","message":"you can pass 100 here","commit_id":"a68c1c436fa3ecdc5a1242ed670a8ae3112aee38"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae20f7120e5708798d5f9d932f60ef79648a12b9","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                    vnic_type\u003dnetwork_model.VNIC_TYPE_MACVTAP,"},{"line_number":227,"context_line":"                                    ovs_interfaceid\u003dNone,"},{"line_number":228,"context_line":"                                    details\u003d{"},{"line_number":229,"context_line":"                                      network_model.VIF_DETAILS_VLAN: \u0027100\u0027},"},{"line_number":230,"context_line":"                                    profile\u003d{\u0027pci_vendor_info\u0027: \u00271137:0043\u0027,"},{"line_number":231,"context_line":"                                             \u0027pci_slot\u0027: \u00270000:0a:00.1\u0027,"},{"line_number":232,"context_line":"                                             \u0027physical_network\u0027: \u0027phynet1\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_fb509560","line":229,"range":{"start_line":229,"start_character":70,"end_line":229,"end_character":75},"updated":"2016-12-03 11:53:54.000000000","message":"ditto","commit_id":"a68c1c436fa3ecdc5a1242ed670a8ae3112aee38"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae20f7120e5708798d5f9d932f60ef79648a12b9","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                                   vnic_type\u003dnetwork_model.VNIC_TYPE_DIRECT,"},{"line_number":269,"context_line":"                                   ovs_interfaceid\u003dNone,"},{"line_number":270,"context_line":"                                   details\u003d{"},{"line_number":271,"context_line":"                                       network_model.VIF_DETAILS_VLAN: \u0027100\u0027},"},{"line_number":272,"context_line":"                                   profile\u003d{\u0027pci_vendor_info\u0027: \u00271137:0043\u0027,"},{"line_number":273,"context_line":"                                            \u0027pci_slot\u0027: \u00270000:0a:00.1\u0027,"},{"line_number":274,"context_line":"                                            \u0027physical_network\u0027: \u0027phynet1\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_7bcba51e","line":271,"range":{"start_line":271,"start_character":71,"end_line":271,"end_character":76},"updated":"2016-12-03 11:53:54.000000000","message":"ditto","commit_id":"a68c1c436fa3ecdc5a1242ed670a8ae3112aee38"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae20f7120e5708798d5f9d932f60ef79648a12b9","unresolved":false,"context_lines":[{"line_number":358,"context_line":"          address\u003d\u0027ca:fe:de:ad:be:ef\u0027,"},{"line_number":359,"context_line":"          network\u003dnetwork_8021,"},{"line_number":360,"context_line":"          type\u003dnetwork_model.VIF_TYPE_MACVTAP,"},{"line_number":361,"context_line":"          details\u003d{network_model.VIF_DETAILS_VLAN: \u00271\u0027,"},{"line_number":362,"context_line":"                   network_model.VIF_DETAILS_PHYS_INTERFACE: \u0027eth0\u0027,"},{"line_number":363,"context_line":"                   network_model.VIF_DETAILS_MACVTAP_SOURCE: \u0027eth0.1\u0027,"},{"line_number":364,"context_line":"                   network_model.VIF_DETAILS_MACVTAP_MODE: \u0027vepa\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_9bd241d1","line":361,"range":{"start_line":361,"start_character":51,"end_line":361,"end_character":54},"updated":"2016-12-03 11:53:54.000000000","message":"ditto","commit_id":"a68c1c436fa3ecdc5a1242ed670a8ae3112aee38"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae20f7120e5708798d5f9d932f60ef79648a12b9","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                        mock_execute):"},{"line_number":796,"context_line":"        mock_get_ifname.side_effect \u003d [\u0027eth1\u0027, \u0027eth13\u0027]"},{"line_number":797,"context_line":"        exit_code \u003d [0, 2, 254]"},{"line_number":798,"context_line":"        port_state \u003d \u0027up\u0027 if int(vlan) \u003e 0 else \u0027down\u0027"},{"line_number":799,"context_line":"        calls \u003d {"},{"line_number":800,"context_line":"            \u0027get_ifname\u0027:"},{"line_number":801,"context_line":"                [mock.call(self.vif_hw_veb_macvtap[\u0027profile\u0027][\u0027pci_slot\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_db6e792e","line":798,"range":{"start_line":798,"start_character":29,"end_line":798,"end_character":38},"updated":"2016-12-03 11:53:54.000000000","message":"not needed.","commit_id":"a68c1c436fa3ecdc5a1242ed670a8ae3112aee38"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"295f2403d89bd699f59d8ac4c06db96f9dd644d7","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"                # id in the vlan attribute."},{"line_number":1348,"context_line":"                for sub in c.getchildren():"},{"line_number":1349,"context_line":"                    if sub.tag \u003d\u003d \u0027tag\u0027 and sub.get(\u0027id\u0027):"},{"line_number":1350,"context_line":"                        self.vlan \u003d int(sub.get(\u0027id\u0027))"},{"line_number":1351,"context_line":"                        break"},{"line_number":1352,"context_line":"            elif c.tag \u003d\u003d \u0027virtualport\u0027:"},{"line_number":1353,"context_line":"                self.vporttype \u003d c.get(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_24afff2a","line":1350,"range":{"start_line":1350,"start_character":36,"end_line":1350,"end_character":54},"updated":"2017-01-06 14:45:49.000000000","message":"Nit: this looks bad, as int(None) would fail. sub[\u0027id\u0027] feels more correct here.","commit_id":"6a6457b5a6563b6cb4bf7673b00773d8208f5900"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"28d0d2c6992450e6985e9c06b48b54456868a1dd","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _is_multiqueue_enabled(self, image_meta, flavor):"},{"line_number":148,"context_line":"        _, vhost_queues \u003d self._get_virtio_mq_settings(image_meta, flavor)"},{"line_number":149,"context_line":"        return vhost_queues \u003e 1 if vhost_queues is not None else False"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_virtio_mq_settings(self, image_meta, flavor):"},{"line_number":152,"context_line":"        \"\"\"A methods to set the number of virtio queues,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_76746a35","line":149,"range":{"start_line":149,"start_character":35,"end_line":149,"end_character":70},"updated":"2016-12-15 12:30:08.000000000","message":"nit:\n\n   return vhost_queues \u003e 1 if vhost_queues else False\n\nwould do fine, I guess?","commit_id":"f90f8c31c3d8ddda4d15c3e53d20d6f7bc23e4ff"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"95912dd00917529385157492e6a418e690972379","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _is_multiqueue_enabled(self, image_meta, flavor):"},{"line_number":148,"context_line":"        _, vhost_queues \u003d self._get_virtio_mq_settings(image_meta, flavor)"},{"line_number":149,"context_line":"        return vhost_queues \u003e 1 if vhost_queues is not None else False"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_virtio_mq_settings(self, image_meta, flavor):"},{"line_number":152,"context_line":"        \"\"\"A methods to set the number of virtio queues,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_b37a8f86","line":149,"range":{"start_line":149,"start_character":35,"end_line":149,"end_character":70},"in_reply_to":"1a6eadb0_76746a35","updated":"2016-12-15 13:26:27.000000000","message":"Looks like vhost_queues can be None (if hw_vif_multiqueue_enabled isn\u0027t in image properties), so I think this dance is necessary.","commit_id":"f90f8c31c3d8ddda4d15c3e53d20d6f7bc23e4ff"}]}