)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbf3b1b4f5ddf89268959833019f28b912b3473a","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        def create_lvm_image(base, size):"},{"line_number":677,"context_line":"            base_size \u003d disk.get_disk_size(base)"},{"line_number":678,"context_line":"            self.verify_base_size(base, size, base_size\u003dbase_size)"},{"line_number":679,"context_line":"            resize \u003d size \u003e base_size if size else None"},{"line_number":680,"context_line":"            size \u003d size if resize else base_size"},{"line_number":681,"context_line":"            lvm.create_volume(self.vg, self.lv,"},{"line_number":682,"context_line":"                                         size, sparse\u003dself.sparse)"},{"line_number":683,"context_line":"            if self.ephemeral_key_uuid is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_a288ce23","line":680,"range":{"start_line":679,"start_character":0,"end_line":680,"end_character":48},"updated":"2016-12-14 04:50:36.000000000","message":"self.verify_base_size check if size is not less than base_size. so we do not need to compare again.\n\nnot sure why size will be None but if so then we can do like below for L679 and L680\n            size \u003d size if size else base_size","commit_id":"615d2538be9a45124f1b9e3de5f4d1c7eeb44706"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"098e6cf74e63dcd4e66426d14fe933be3200acf2","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        def create_lvm_image(base, size):"},{"line_number":677,"context_line":"            base_size \u003d disk.get_disk_size(base)"},{"line_number":678,"context_line":"            self.verify_base_size(base, size, base_size\u003dbase_size)"},{"line_number":679,"context_line":"            resize \u003d size \u003e base_size if size else None"},{"line_number":680,"context_line":"            size \u003d size if resize else base_size"},{"line_number":681,"context_line":"            lvm.create_volume(self.vg, self.lv,"},{"line_number":682,"context_line":"                                         size, sparse\u003dself.sparse)"},{"line_number":683,"context_line":"            if self.ephemeral_key_uuid is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_e3b8902c","line":680,"range":{"start_line":679,"start_character":0,"end_line":680,"end_character":48},"in_reply_to":"1a6eadb0_a288ce23","updated":"2016-12-16 08:54:17.000000000","message":"not sure get your point, we still need reize in L695","commit_id":"615d2538be9a45124f1b9e3de5f4d1c7eeb44706"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"723e3070d4f714c775e1386a7173edcbe305c8cc","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        def create_lvm_image(base, size):"},{"line_number":686,"context_line":"            base_size \u003d disk.get_disk_size(base)"},{"line_number":687,"context_line":"            self.verify_base_size(base, size, base_size\u003dbase_size)"},{"line_number":688,"context_line":"            resize \u003d size \u003e base_size if size else None"},{"line_number":689,"context_line":"            size \u003d size if resize else base_size"},{"line_number":690,"context_line":"            lvm.create_volume(self.vg, self.lv,"},{"line_number":691,"context_line":"                                         size, sparse\u003dself.sparse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_7d9e9c57","line":688,"range":{"start_line":688,"start_character":51,"end_line":688,"end_character":55},"updated":"2017-01-02 11:54:19.000000000","message":"This should read \u0027False\u0027","commit_id":"346b7414d68cdae2bfa0eae718c680274caf3f94"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"6160a630298eb7143e598d98480a4aa2130bfdbf","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        def create_lvm_image(base, size):"},{"line_number":686,"context_line":"            base_size \u003d disk.get_disk_size(base)"},{"line_number":687,"context_line":"            self.verify_base_size(base, size, base_size\u003dbase_size)"},{"line_number":688,"context_line":"            resize \u003d size \u003e base_size if size else None"},{"line_number":689,"context_line":"            size \u003d size if resize else base_size"},{"line_number":690,"context_line":"            lvm.create_volume(self.vg, self.lv,"},{"line_number":691,"context_line":"                                         size, sparse\u003dself.sparse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_1948015b","line":688,"range":{"start_line":688,"start_character":51,"end_line":688,"end_character":55},"in_reply_to":"ba5201f7_7d9e9c57","updated":"2017-01-04 12:20:39.000000000","message":"Done","commit_id":"346b7414d68cdae2bfa0eae718c680274caf3f94"}]}