)]}'
{"nova/tests/unit/api/openstack/compute/test_disk_config.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"789ff3859e3ebf2231c0abcc937be6fb157e07d4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    \u0027 not one of [\\\u0027AUTO\\\u0027, \\\u0027MANUAL\\\u0027]\", \"code\": 400}}}}\u0027)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            return (\u0027{{\"badRequest\": {{\"message\": \"Invalid input for\u0027"},{"line_number":142,"context_line":"                    \u0027 field/attribute {0}. Value: {1}. u\\\u0027{1}\\\u0027 is\u0027"},{"line_number":143,"context_line":"                    \u0027 not one of [\\\u0027AUTO\\\u0027, \\\u0027MANUAL\\\u0027]\", \"code\": 400}}}}\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def _setup_fake_image_service(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_25a74c50","line":142,"range":{"start_line":142,"start_character":55,"end_line":142,"end_character":56},"updated":"2016-12-14 15:39:29.000000000","message":"This was a mistake the first day. You can drop this and...","commit_id":"a839325c749b6f842a83de7f8a30a58a22ee8e3b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"789ff3859e3ebf2231c0abcc937be6fb157e07d4","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            \u0027/fake/servers/%s\u0027 % MANUAL_INSTANCE_UUID)"},{"line_number":360,"context_line":"        req.method \u003d \u0027PUT\u0027"},{"line_number":361,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":362,"context_line":"        body \u003d {\u0027server\u0027: {API_DISK_CONFIG: \u0027server_test\u0027}}"},{"line_number":363,"context_line":"        req.body \u003d jsonutils.dump_as_bytes(body)"},{"line_number":364,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":365,"context_line":"        self.assertEqual(res.status_int, 400)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_6516a4a8","line":362,"range":{"start_line":362,"start_character":44,"end_line":362,"end_character":57},"updated":"2016-12-14 15:39:29.000000000","message":"just prefix this with a \u0027b\u0027:\n\n  b\u0027server_test\u0027","commit_id":"a839325c749b6f842a83de7f8a30a58a22ee8e3b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"789ff3859e3ebf2231c0abcc937be6fb157e07d4","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        expected_msg \u003d self._get_expected_msg_for_invalid_disk_config()"},{"line_number":367,"context_line":"        expected_msg \u003d expected_msg.format(API_DISK_CONFIG, \u0027server_test\u0027)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self.assertEqual(jsonutils.loads(expected_msg),"},{"line_number":370,"context_line":"                         jsonutils.loads(res.body))"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    @mock.patch(\u0027nova.api.openstack.common.get_instance\u0027)"},{"line_number":373,"context_line":"    def _test_rebuild_server_disk_config(self, uuid, disk_config,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_c50db83f","line":370,"range":{"start_line":369,"start_character":0,"end_line":370,"end_character":51},"updated":"2016-12-14 15:39:29.000000000","message":"nit: surely we should be using assertJSONEqual here instead of this? Worth adding a TODO or a follow-up patch to make this less fragile?","commit_id":"a839325c749b6f842a83de7f8a30a58a22ee8e3b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"326bb1c8aa01334ca6b1d7353821b5dbb14c464b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    \u0027 not one of [\\\u0027AUTO\\\u0027, \\\u0027MANUAL\\\u0027]\", \"code\": 400}}}}\u0027)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            return (\u0027{{\"badRequest\": {{\"message\": \"Invalid input for\u0027"},{"line_number":142,"context_line":"                    \u0027 field/attribute {0}. Value: {1}. u\\\u0027{1}\\\u0027 is\u0027"},{"line_number":143,"context_line":"                    \u0027 not one of [\\\u0027AUTO\\\u0027, \\\u0027MANUAL\\\u0027]\", \"code\": 400}}}}\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def _setup_fake_image_service(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_9a244db0","line":142,"range":{"start_line":142,"start_character":55,"end_line":142,"end_character":57},"updated":"2016-12-19 11:43:32.000000000","message":"I still don\u0027t like how this implementation detail is leaking through to the user, but that\u0027s an existing issue due to how jsonschema does it\u0027s validation exception reporting (using \u0027%r\u0027 [1]) and out-of-scope for this change so I think we can ignore the issue for now.\n\n[1] https://github.com/Julian/jsonschema/blob/v2.5.1/jsonschema/_validators.py#L188-L189","commit_id":"02ceb354828dc81b9849ce89745d21246a7d5443"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"627ed08ac80588a96f5638c5a7b0c265e21f7eac","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    \u0027 not one of [\\\u0027AUTO\\\u0027, \\\u0027MANUAL\\\u0027]\", \"code\": 400}}}}\u0027)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            return (\u0027{{\"badRequest\": {{\"message\": \"Invalid input for\u0027"},{"line_number":142,"context_line":"                    \u0027 field/attribute {0}. Value: {1}. u\\\u0027{1}\\\u0027 is\u0027"},{"line_number":143,"context_line":"                    \u0027 not one of [\\\u0027AUTO\\\u0027, \\\u0027MANUAL\\\u0027]\", \"code\": 400}}}}\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def _setup_fake_image_service(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_279045ec","line":142,"range":{"start_line":142,"start_character":55,"end_line":142,"end_character":57},"in_reply_to":"1a6eadb0_9a244db0","updated":"2016-12-24 12:24:20.000000000","message":"yea, that isn\u0027t a good error message. but also agree this is out of scope for this patch.","commit_id":"02ceb354828dc81b9849ce89745d21246a7d5443"}]}