)]}'
{"nova/objects/build_request.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3626a512e575cdad52e137ec37efb08a4831aa2f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # field being set, so when hydrating it back here, we should get the"},{"line_number":85,"context_line":"        # right value but in case we don\u0027t have it, let\u0027s suppose that the"},{"line_number":86,"context_line":"        # instance is not deleted, which is the default value for that field."},{"line_number":87,"context_line":"        self.instance.obj_set_defaults(\u0027deleted\u0027)"},{"line_number":88,"context_line":"        # NOTE(alaski): Set some fields on instance that are needed by the api,"},{"line_number":89,"context_line":"        # not lazy-loadable, and don\u0027t change."},{"line_number":90,"context_line":"        self.instance.disable_terminate \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_aa32eea4","line":87,"updated":"2016-11-28 17:49:35.000000000","message":"Why aren\u0027t we just setting it like the instance object does?\n\nhttps://github.com/openstack/nova/blob/646151ff1b8d481b70884d201a1b395d904e35b0/nova/objects/instance.py#L334","commit_id":"37ec9b99c7ca85467f5d274505e86436d86657dc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1c6ddaa2d48d11d47ecdaf4db37aadaf0120749f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # field being set, so when hydrating it back here, we should get the"},{"line_number":85,"context_line":"        # right value but in case we don\u0027t have it, let\u0027s suppose that the"},{"line_number":86,"context_line":"        # instance is not deleted, which is the default value for that field."},{"line_number":87,"context_line":"        self.instance.obj_set_defaults(\u0027deleted\u0027)"},{"line_number":88,"context_line":"        # NOTE(alaski): Set some fields on instance that are needed by the api,"},{"line_number":89,"context_line":"        # not lazy-loadable, and don\u0027t change."},{"line_number":90,"context_line":"        self.instance.disable_terminate \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_41c21cea","line":87,"in_reply_to":"5a74a57a_a175b064","updated":"2016-11-28 20:23:38.000000000","message":"I guess this set-defaults thing is to handle the case where we pull an instance out with a value so we don\u0027t clobber it. However, the way this is used (and because BuildRequest *means* the instance is not created yet) I\u0027m not sure this is useful.\n\nIMHO, this has already been defined as \"loads a stored instance with a known state\" and just changing 0 to False on L85 is the way to go.","commit_id":"37ec9b99c7ca85467f5d274505e86436d86657dc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c43b0efb0a38b3041e15706b675c56c00e68026f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # field being set, so when hydrating it back here, we should get the"},{"line_number":85,"context_line":"        # right value but in case we don\u0027t have it, let\u0027s suppose that the"},{"line_number":86,"context_line":"        # instance is not deleted, which is the default value for that field."},{"line_number":87,"context_line":"        self.instance.obj_set_defaults(\u0027deleted\u0027)"},{"line_number":88,"context_line":"        # NOTE(alaski): Set some fields on instance that are needed by the api,"},{"line_number":89,"context_line":"        # not lazy-loadable, and don\u0027t change."},{"line_number":90,"context_line":"        self.instance.disable_terminate \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_a175b064","line":87,"in_reply_to":"5a74a57a_aa32eea4","updated":"2016-11-28 20:11:51.000000000","message":"Hmm, I\u0027m finding we can\u0027t do like in the instance object because we don\u0027t have a primitive instances table instance here, we have a serialized Instance object, so the deleted column is going to be a boolean, so we literally can\u0027t tell if it should be soft deleted or not. That sucks.","commit_id":"37ec9b99c7ca85467f5d274505e86436d86657dc"}]}