)]}'
{"nova/api/openstack/compute/server_external_events.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"de30512a32d7a8d626c4f955f754d40a312205ff","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            if not instance:"},{"line_number":67,"context_line":"                try:"},{"line_number":68,"context_line":"                    # Load migration_context and info_cache here in a single DB"},{"line_number":69,"context_line":"                    # operation because we need them later on"},{"line_number":70,"context_line":"                    instance \u003d objects.Instance.get_by_uuid("},{"line_number":71,"context_line":"                        context, event.instance_uuid,"},{"line_number":72,"context_line":"                        expected_attrs\u003d[\u0027migration_context\u0027, \u0027info_cache\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_b197f246","line":69,"updated":"2017-01-28 02:07:24.000000000","message":"It would be nice if this comment mentioned what they are needed for, or why they need to be pre-loaded.","commit_id":"4fce45f83bd510202fd1cbcdb7694361c41e9400"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"de30512a32d7a8d626c4f955f754d40a312205ff","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    # operation because we need them later on"},{"line_number":70,"context_line":"                    instance \u003d objects.Instance.get_by_uuid("},{"line_number":71,"context_line":"                        context, event.instance_uuid,"},{"line_number":72,"context_line":"                        expected_attrs\u003d[\u0027migration_context\u0027, \u0027info_cache\u0027])"},{"line_number":73,"context_line":"                    instances[event.instance_uuid] \u003d instance"},{"line_number":74,"context_line":"                except exception.InstanceNotFound:"},{"line_number":75,"context_line":"                    LOG.debug(\u0027Dropping event %(name)s:%(tag)s for unknown \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_f1c6da66","line":72,"updated":"2017-01-28 02:07:24.000000000","message":"So the change mentioned in the commit message stopped the pre-loading of info_cache because in Instance.get_by_uuid, if expected_attrs\u003dNone, [\u0027info_cache\u0027, \u0027security_groups\u0027] are used automatically as expected_attrs. When \u0027migration_context\u0027 was added, the automatic adding stopped.\n\nMakes me wonder if we should add \u0027security_groups\u0027 back here too, but I guess we might as well wait to see if any problems arise first.","commit_id":"4fce45f83bd510202fd1cbcdb7694361c41e9400"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"83fbff39fd5ab4762994b13a791c3c308a220661","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    # operation because we need them later on"},{"line_number":70,"context_line":"                    instance \u003d objects.Instance.get_by_uuid("},{"line_number":71,"context_line":"                        context, event.instance_uuid,"},{"line_number":72,"context_line":"                        expected_attrs\u003d[\u0027migration_context\u0027, \u0027info_cache\u0027])"},{"line_number":73,"context_line":"                    instances[event.instance_uuid] \u003d instance"},{"line_number":74,"context_line":"                except exception.InstanceNotFound:"},{"line_number":75,"context_line":"                    LOG.debug(\u0027Dropping event %(name)s:%(tag)s for unknown \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_adad889c","line":72,"in_reply_to":"3a461143_e3d0d1f8","updated":"2017-01-31 14:52:45.000000000","message":"Yeah, we shouldn\u0027t need security groups for neutron tidy up as such. Neutron should have the definitive info on that anyways.","commit_id":"4fce45f83bd510202fd1cbcdb7694361c41e9400"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7cbe25c8f9fa756a0ac022c53780df21c7b7440","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    # operation because we need them later on"},{"line_number":70,"context_line":"                    instance \u003d objects.Instance.get_by_uuid("},{"line_number":71,"context_line":"                        context, event.instance_uuid,"},{"line_number":72,"context_line":"                        expected_attrs\u003d[\u0027migration_context\u0027, \u0027info_cache\u0027])"},{"line_number":73,"context_line":"                    instances[event.instance_uuid] \u003d instance"},{"line_number":74,"context_line":"                except exception.InstanceNotFound:"},{"line_number":75,"context_line":"                    LOG.debug(\u0027Dropping event %(name)s:%(tag)s for unknown \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_e3d0d1f8","line":72,"in_reply_to":"3a461143_f1c6da66","updated":"2017-01-28 03:34:07.000000000","message":"As far as I know we don\u0027t lazy-load security groups anywhere in this flow where this instance is used.","commit_id":"4fce45f83bd510202fd1cbcdb7694361c41e9400"}]}