)]}'
{"nova/objects/resource_provider.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c964e894c7ca285d76fc5f6f72cc043aafe7184b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# NOTE(cdent): The resource provider objects are designed to never be"},{"line_number":14,"context_line":"# used over RPC. Remote manipulation is done with the placement HTTP"},{"line_number":15,"context_line":"# API. The \u0027remotable\u0027 decorators should not be used."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_db import exception as db_exc"},{"line_number":18,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_a20a4577","line":15,"updated":"2016-12-05 16:02:19.000000000","message":"That is a strong assumption (we should never call the objects remotely), I\u0027d like to see then a way to either unittest it or have a method like https://github.com/openstack/nova/blob/a049967e7d6815ebb0962e0328a6f02088186339/nova/cmd/common.py#L38-L52 fencing it.","commit_id":"71d9b5ab9364c1ab59a16dcd09b751682eb8d6f9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9f9a0834fc8ef553c351aed5394252c88feff8c2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":"# NOTE(cdent): The resource provider objects are designed to never be"},{"line_number":15,"context_line":"# used over RPC. Remote manipulation is done with the placement HTTP"},{"line_number":16,"context_line":"# API. The \u0027remotable\u0027 decorators should not be used."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_db import exception as db_exc"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_37db20ef","line":16,"updated":"2016-12-08 22:19:57.000000000","message":"Providing the same comment as in PS2 : \n\nThat is a strong assumption (we should never call the objects remotely), I\u0027d like to see then a way to either unittest it or have a method like https://github.com/openstack/nova/blob/a049967e7d6815ebb0962e0328a6f02088186339/nova/cmd/common.py#L38-L52 fencing it.","commit_id":"bea29e6d58aa5e028f33663b5d79a6556653a6c8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7998fc9c8995938dbf65cfd9451854e5f266dfb3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":"# NOTE(cdent): The resource provider objects are designed to never be"},{"line_number":15,"context_line":"# used over RPC. Remote manipulation is done with the placement HTTP"},{"line_number":16,"context_line":"# API. The \u0027remotable\u0027 decorators should not be used."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_db import exception as db_exc"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_98dcf5e5","line":16,"in_reply_to":"3a71b18c_37db20ef","updated":"2016-12-09 21:13:29.000000000","message":"Personally, I don\u0027t think that\u0027s really necessary.","commit_id":"bea29e6d58aa5e028f33663b5d79a6556653a6c8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"027afc19ab84ca4f5d54b604f6a4acd6db5fa258","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import copy"},{"line_number":14,"context_line":"# NOTE(cdent): The resource provider objects are designed to never be"},{"line_number":15,"context_line":"# used over RPC. Remote manipulation is done with the placement HTTP"},{"line_number":16,"context_line":"# API. The \u0027remotable\u0027 decorators should not be used."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_db import exception as db_exc"},{"line_number":19,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_b8ae112c","line":16,"in_reply_to":"3a71b18c_98dcf5e5","updated":"2016-12-09 21:16:27.000000000","message":"Okay, fair enough :-)","commit_id":"bea29e6d58aa5e028f33663b5d79a6556653a6c8"}],"nova/tests/unit/objects/test_resource_provider.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4673e2446d33f0afb6d062579223399e68819f3a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    USES_DB \u003d False"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class TestRemoteResourceProviderNoDB(test_objects._RemoteTest,"},{"line_number":115,"context_line":"                                     _TestResourceProviderNoDB):"},{"line_number":116,"context_line":"    USES_DB \u003d False"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_7800f966","side":"PARENT","line":114,"range":{"start_line":114,"start_character":50,"end_line":114,"end_character":61},"updated":"2016-12-09 21:09:56.000000000","message":"You might be able to sort something out with this, or like this, maybe it\u0027s as simple as iterating the methods on the resource provider object and simply checking to see if they are remotable and if so, blow up.\n\nDan Smith would probably have a sneaky way to enforce this also.","commit_id":"0a137d1873be87d249805abea835539c8bb98954"}]}