)]}'
{"nova/virt/hardware.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2e782c2e97bb9a189217ed0a706a08d375939807","unresolved":false,"context_lines":[{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    # sanity checks"},{"line_number":1269,"context_line":""},{"line_number":1270,"context_line":"    if ((cpu_policy and cpu_policy not in fields.CPUAllocationPolicy.ALL) or"},{"line_number":1271,"context_line":"        (cpu_thread_policy and"},{"line_number":1272,"context_line":"         cpu_thread_policy not in fields.CPUThreadAllocationPolicy.ALL)):"},{"line_number":1273,"context_line":"        raise exception.NUMAPolicyConfigurationInvalid("},{"line_number":1274,"context_line":"                thread_policy\u003dcpu_thread_policy or \"None\","},{"line_number":1275,"context_line":"                cpu_policy\u003dcpu_policy or \"None\")"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    rt \u003d is_realtime_enabled(flavor)"},{"line_number":1278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_9ab5fbd1","line":1275,"range":{"start_line":1270,"start_character":4,"end_line":1275,"end_character":48},"updated":"2016-12-01 02:31:17.000000000","message":"We can put those check in the separate validation method in the line 1264 and 1265.\n\nAnd we can have separate exception for them to get better error message. Also we can tell user the wrong one is extra_spec or image_properties.","commit_id":"eea6b235545cb52088021508490a7d4ed6155dc2"},{"author":{"_account_id":15648,"name":"Yingxin","email":"yingxin.cheng@intel.com","username":"Yingxin"},"change_message_id":"eb8f0198928dea0e64de464e9e24624310c82b83","unresolved":false,"context_lines":[{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"    # sanity checks"},{"line_number":1269,"context_line":""},{"line_number":1270,"context_line":"    if ((cpu_policy and cpu_policy not in fields.CPUAllocationPolicy.ALL) or"},{"line_number":1271,"context_line":"        (cpu_thread_policy and"},{"line_number":1272,"context_line":"         cpu_thread_policy not in fields.CPUThreadAllocationPolicy.ALL)):"},{"line_number":1273,"context_line":"        raise exception.NUMAPolicyConfigurationInvalid("},{"line_number":1274,"context_line":"                thread_policy\u003dcpu_thread_policy or \"None\","},{"line_number":1275,"context_line":"                cpu_policy\u003dcpu_policy or \"None\")"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    rt \u003d is_realtime_enabled(flavor)"},{"line_number":1278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_207cb61f","line":1275,"range":{"start_line":1270,"start_character":4,"end_line":1275,"end_character":48},"in_reply_to":"5a74a57a_9ab5fbd1","updated":"2016-12-01 03:41:49.000000000","message":"Done","commit_id":"eea6b235545cb52088021508490a7d4ed6155dc2"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"98037c2ad7933d4d85fc37969368415cda01d18f","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        \u0027cpu_thread_policy\u0027, flavor, image_meta)"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    # NOTE: image_policy is already coerced by the ImageMeta object"},{"line_number":1086,"context_line":"    if flavor_policy and \\"},{"line_number":1087,"context_line":"            flavor_policy not in fields.CPUThreadAllocationPolicy.ALL:"},{"line_number":1088,"context_line":"        raise exception.NUMACPUThreadPolicyInvalid(thread_policy\u003dflavor_policy,"},{"line_number":1089,"context_line":"                                                   source\u003d\"flavor\")"},{"line_number":1090,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_1eeccac6","line":1087,"range":{"start_line":1086,"start_character":7,"end_line":1087,"end_character":70},"updated":"2016-12-01 10:35:51.000000000","message":"I think you should use parentheses here to avoid the ugly backslash character.","commit_id":"5f69da693c0f4956c6aee4f0591a4fd34294d4e7"}]}