)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f118f71a4f60ad72db1f235e2e74a173f554c001","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the audit hasn’t been triggered and confirm resize is executed, the"},{"line_number":10,"context_line":"resources aren\u0027t dropped because the itype stored in the"},{"line_number":11,"context_line":"self.tracked_migrations correspond to new flavor."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But if the audit got executed, it correspond to the old flavor, and resources"},{"line_number":14,"context_line":"gets dropped properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_96e5480a","line":11,"updated":"2016-12-06 20:40:42.000000000","message":"s/correspond/corresponds/\n\ns/to new/to the new/","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"408f226c9d5289b9fa6f18a67e6c40a154ca4592","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the audit hasn’t been triggered and confirm resize is executed, the"},{"line_number":10,"context_line":"resources aren\u0027t dropped because the itype stored in the"},{"line_number":11,"context_line":"self.tracked_migrations correspond to new flavor."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But if the audit got executed, it correspond to the old flavor, and resources"},{"line_number":14,"context_line":"gets dropped properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_25585cfa","line":11,"in_reply_to":"3a71b18c_96e5480a","updated":"2016-12-08 15:59:58.000000000","message":"Done","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f118f71a4f60ad72db1f235e2e74a173f554c001","unresolved":false,"context_lines":[{"line_number":10,"context_line":"resources aren\u0027t dropped because the itype stored in the"},{"line_number":11,"context_line":"self.tracked_migrations correspond to new flavor."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But if the audit got executed, it correspond to the old flavor, and resources"},{"line_number":14,"context_line":"gets dropped properly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch removes part of the condition in drop_move_claim() which was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_16c0584f","line":13,"updated":"2016-12-06 20:40:42.000000000","message":"s/correspond/corresponds/","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"408f226c9d5289b9fa6f18a67e6c40a154ca4592","unresolved":false,"context_lines":[{"line_number":10,"context_line":"resources aren\u0027t dropped because the itype stored in the"},{"line_number":11,"context_line":"self.tracked_migrations correspond to new flavor."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But if the audit got executed, it correspond to the old flavor, and resources"},{"line_number":14,"context_line":"gets dropped properly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch removes part of the condition in drop_move_claim() which was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_455b98f6","line":13,"in_reply_to":"3a71b18c_16c0584f","updated":"2016-12-08 15:59:58.000000000","message":"Done","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f118f71a4f60ad72db1f235e2e74a173f554c001","unresolved":false,"context_lines":[{"line_number":11,"context_line":"self.tracked_migrations correspond to new flavor."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But if the audit got executed, it correspond to the old flavor, and resources"},{"line_number":14,"context_line":"gets dropped properly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch removes part of the condition in drop_move_claim() which was"},{"line_number":17,"context_line":"trying to validate that the instance type (itype) stored in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_56b650f9","line":14,"updated":"2016-12-06 20:40:42.000000000","message":"s/gets dropped/get dropped/","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"408f226c9d5289b9fa6f18a67e6c40a154ca4592","unresolved":false,"context_lines":[{"line_number":11,"context_line":"self.tracked_migrations correspond to new flavor."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But if the audit got executed, it correspond to the old flavor, and resources"},{"line_number":14,"context_line":"gets dropped properly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch removes part of the condition in drop_move_claim() which was"},{"line_number":17,"context_line":"trying to validate that the instance type (itype) stored in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_6572547e","line":14,"in_reply_to":"3a71b18c_56b650f9","updated":"2016-12-08 15:59:58.000000000","message":"Done","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f118f71a4f60ad72db1f235e2e74a173f554c001","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            else:"},{"line_number":796,"context_line":"                obj \u003d objects.PciDevicePoolList()"},{"line_number":797,"context_line":"                self.compute_node.pci_device_pools \u003d obj"},{"line_number":798,"context_line":"            self.tracked_migrations[uuid] \u003d migration"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"    def _update_usage_from_migrations(self, context, migrations):"},{"line_number":801,"context_line":"        filtered \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_b6da4415","line":798,"updated":"2016-12-06 20:40:42.000000000","message":"Yeah, I have a feeling that this code looked the way it did because we didn\u0027t use to have a migration object that had the (correct) old and new flavors in it? Not sure at this point :(","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"408f226c9d5289b9fa6f18a67e6c40a154ca4592","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            else:"},{"line_number":796,"context_line":"                obj \u003d objects.PciDevicePoolList()"},{"line_number":797,"context_line":"                self.compute_node.pci_device_pools \u003d obj"},{"line_number":798,"context_line":"            self.tracked_migrations[uuid] \u003d migration"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"    def _update_usage_from_migrations(self, context, migrations):"},{"line_number":801,"context_line":"        filtered \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_e5dca41a","line":798,"in_reply_to":"3a71b18c_b6da4415","updated":"2016-12-08 15:59:58.000000000","message":"I don\u0027t have a definite answer, I\u0027m not sure for what reason it was done like that.  I tracked down the commit that introduced this code: https://review.openstack.org/#/c/15799/\n\nThis commit introduced support for resize claim.  There is not much comments in the review.\n\nBut, looking at current code base, I don\u0027t see the value for storing the itype.  The method drop_move_claim is called from three different places: in the compute manager (on confirm_resize and revert_resize) and on claim.abort().  In all three cases we have enough context for what we need to drop in terms of resources (based on the flavor).","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"0e0794ed8e2da3a62626196b5a304f3faae1340a","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                instance_type \u003d self._get_instance_type(ctxt, instance, prefix,"},{"line_number":361,"context_line":"                                                        migration)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"            if instance_type is not None and instance_type.id \u003d\u003d itype[\u0027id\u0027]:"},{"line_number":364,"context_line":"                numa_topology \u003d self._get_migration_context_resource("},{"line_number":365,"context_line":"                    \u0027numa_topology\u0027, instance, prefix\u003dprefix)"},{"line_number":366,"context_line":"                usage \u003d self._get_usage_dict("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_19cae41a","side":"PARENT","line":363,"range":{"start_line":363,"start_character":39,"end_line":363,"end_character":76},"updated":"2016-12-08 18:18:40.000000000","message":"are you sure remove this is ok?\ncan you check the resize on the same node with this patch?\nas I remember _update_usage_from_migration is called twice \nsee this mail http://lists.openstack.org/pipermail/openstack-dev/2016-May/095479.html","commit_id":"668f2f963170b40f68045976393ea4393d940949"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"1ca4cd8edae938df1e2aa2ae452b9a8d8ef0bb9f","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                instance_type \u003d self._get_instance_type(ctxt, instance, prefix,"},{"line_number":361,"context_line":"                                                        migration)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"            if instance_type is not None and instance_type.id \u003d\u003d itype[\u0027id\u0027]:"},{"line_number":364,"context_line":"                numa_topology \u003d self._get_migration_context_resource("},{"line_number":365,"context_line":"                    \u0027numa_topology\u0027, instance, prefix\u003dprefix)"},{"line_number":366,"context_line":"                usage \u003d self._get_usage_dict("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_7563b441","side":"PARENT","line":363,"range":{"start_line":363,"start_character":39,"end_line":363,"end_character":76},"in_reply_to":"3a71b18c_19cae41a","updated":"2016-12-09 14:14:10.000000000","message":"I tested a resize on the same node, and it was successful.\n\nI don\u0027t think the number of time that  _update_usage_from_migration() could be called matters.  The block of code at L364 will get executed only once since we pop the instance from the tracked_migrations.","commit_id":"668f2f963170b40f68045976393ea4393d940949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"d625cd8539f7a73d1af1b53ed3a5b1c479007e90","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                instance_type \u003d self._get_instance_type(ctxt, instance, prefix,"},{"line_number":361,"context_line":"                                                        migration)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"            if instance_type is not None and instance_type.id \u003d\u003d itype[\u0027id\u0027]:"},{"line_number":364,"context_line":"                numa_topology \u003d self._get_migration_context_resource("},{"line_number":365,"context_line":"                    \u0027numa_topology\u0027, instance, prefix\u003dprefix)"},{"line_number":366,"context_line":"                usage \u003d self._get_usage_dict("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_12028b0b","side":"PARENT","line":363,"range":{"start_line":363,"start_character":39,"end_line":363,"end_character":76},"in_reply_to":"3a71b18c_7563b441","updated":"2016-12-09 17:41:25.000000000","message":"Ok I see you point. \nLet me think about it :)","commit_id":"668f2f963170b40f68045976393ea4393d940949"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9c4b22cbb6a39e936965cba5bc207e0597b4a685","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                instance_type \u003d self._get_instance_type(ctxt, instance, prefix,"},{"line_number":361,"context_line":"                                                        migration)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"            if instance_type is not None and instance_type.id \u003d\u003d itype[\u0027id\u0027]:"},{"line_number":364,"context_line":"                numa_topology \u003d self._get_migration_context_resource("},{"line_number":365,"context_line":"                    \u0027numa_topology\u0027, instance, prefix\u003dprefix)"},{"line_number":366,"context_line":"                usage \u003d self._get_usage_dict("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_a07f6e13","side":"PARENT","line":363,"range":{"start_line":363,"start_character":41,"end_line":363,"end_character":77},"updated":"2016-12-16 08:38:45.000000000","message":"So I guess I am fine with this.","commit_id":"bcc176804296b26fbc973f41ba56ca5682188cf6"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9c4b22cbb6a39e936965cba5bc207e0597b4a685","unresolved":false,"context_lines":[{"line_number":771,"context_line":"                # (just in case)."},{"line_number":772,"context_line":"                itype \u003d self._get_instance_type(context, instance, \u0027old_\u0027,"},{"line_number":773,"context_line":"                        migration)"},{"line_number":774,"context_line":"                numa_topology \u003d self._get_migration_context_resource("},{"line_number":775,"context_line":"                    \u0027numa_topology\u0027, instance, prefix\u003d\u0027old_\u0027)"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        elif incoming and not record:"},{"line_number":778,"context_line":"            # instance has not yet migrated here:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_e0f086cb","line":775,"range":{"start_line":774,"start_character":0,"end_line":775,"end_character":61},"updated":"2016-12-16 08:38:45.000000000","message":"regarding pci it seem that the code here is incorrect. we should do the same as NUMA. in each if branch we should get \nthe new/old pci device and pass them to the  \nself._get_usage_dict and the self._update_usage.\nThe self._update_usage should allocated ether the old or the new pci device.","commit_id":"10703162422fcf86851a274a0a0dd3438cd00c25"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f118f71a4f60ad72db1f235e2e74a173f554c001","unresolved":false,"context_lines":[{"line_number":5174,"context_line":"                                          instance.instance_type_id)"},{"line_number":5175,"context_line":"        self.assertEqual(flavor.flavorid, \u00271\u0027)"},{"line_number":5176,"context_line":""},{"line_number":5177,"context_line":"        # Memory usage should had decreased by the claim"},{"line_number":5178,"context_line":"        self.assertEqual(self.rt.compute_node.free_ram_mb,"},{"line_number":5179,"context_line":"                         free_ram_mb - flavor.memory_mb)"},{"line_number":5180,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_b69ec460","line":5177,"range":{"start_line":5177,"start_character":30,"end_line":5177,"end_character":33},"updated":"2016-12-06 20:40:42.000000000","message":"s/had/have/ :)","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"408f226c9d5289b9fa6f18a67e6c40a154ca4592","unresolved":false,"context_lines":[{"line_number":5174,"context_line":"                                          instance.instance_type_id)"},{"line_number":5175,"context_line":"        self.assertEqual(flavor.flavorid, \u00271\u0027)"},{"line_number":5176,"context_line":""},{"line_number":5177,"context_line":"        # Memory usage should had decreased by the claim"},{"line_number":5178,"context_line":"        self.assertEqual(self.rt.compute_node.free_ram_mb,"},{"line_number":5179,"context_line":"                         free_ram_mb - flavor.memory_mb)"},{"line_number":5180,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_e55f4473","line":5177,"range":{"start_line":5177,"start_character":30,"end_line":5177,"end_character":33},"in_reply_to":"3a71b18c_b69ec460","updated":"2016-12-08 15:59:58.000000000","message":"Done","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f118f71a4f60ad72db1f235e2e74a173f554c001","unresolved":false,"context_lines":[{"line_number":5516,"context_line":"        # Resources from the migration (based on initial flavor) should"},{"line_number":5517,"context_line":"        # be freed now"},{"line_number":5518,"context_line":"        self.assertEqual(self.rt.compute_node.free_ram_mb,"},{"line_number":5519,"context_line":"                         free_ram_mb - flavor.memory_mb)"},{"line_number":5520,"context_line":""},{"line_number":5521,"context_line":"        instance.refresh()"},{"line_number":5522,"context_line":"        if remove_old_vm_state:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_9600e835","line":5519,"updated":"2016-12-06 20:40:42.000000000","message":"Here and the changes above...\n\nThe code changed in this patch is the nova.compute.resource_tracker module and the unit tests in nova/tests/unit/compute/test_resource_tracker.py are the ones that should have been modified. The fact that there\u0027s no changes to any of the unit tests in that test module indicate that the testing of the _update_usage_from_migrations() method is really not good at all and needs to be fixed up, I\u0027m afraid.\n\nTesting the resource tracker in this test file expands the testing surface area to a much greater area than is either needed or desired.\n\nFor instance, what you\u0027re testing above is how the compute manager\u0027s prep_resize(), confirm_resize() and revert_resize() methods affec the amount of memory in the resource tracker\u0027s compute_node object. The issue is that the changes in this patch don\u0027t touch the compute manager at all, they only tough the resource tracker. So, really, tests for accounting of resources during a resize belong in the test_resource_tracker.py module.","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"408f226c9d5289b9fa6f18a67e6c40a154ca4592","unresolved":false,"context_lines":[{"line_number":5516,"context_line":"        # Resources from the migration (based on initial flavor) should"},{"line_number":5517,"context_line":"        # be freed now"},{"line_number":5518,"context_line":"        self.assertEqual(self.rt.compute_node.free_ram_mb,"},{"line_number":5519,"context_line":"                         free_ram_mb - flavor.memory_mb)"},{"line_number":5520,"context_line":""},{"line_number":5521,"context_line":"        instance.refresh()"},{"line_number":5522,"context_line":"        if remove_old_vm_state:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_25d13cce","line":5519,"in_reply_to":"3a71b18c_9600e835","updated":"2016-12-08 15:59:58.000000000","message":"Agreed and done.\n\nShould we keep those changes in this patch ?  Does it improves the test coverage ?","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f118f71a4f60ad72db1f235e2e74a173f554c001","unresolved":false,"context_lines":[{"line_number":5639,"context_line":"        self.assertNotEqual(migration.dest_compute, migration.source_compute)"},{"line_number":5640,"context_line":"        self.assertNotEqual(migration.dest_node, migration.source_node)"},{"line_number":5641,"context_line":"        self.assertEqual(NODENAME2, migration.dest_compute)"},{"line_number":5642,"context_line":"        self.assertEqual(NODENAME2, migration.dest_node)"},{"line_number":5643,"context_line":""},{"line_number":5644,"context_line":"    def test_get_by_flavor_id(self):"},{"line_number":5645,"context_line":"        flavor_type \u003d flavors.get_flavor_by_flavor_id(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_d68d00d4","line":5642,"updated":"2016-12-06 20:40:42.000000000","message":"The above test is great. However, it doesn\u0027t have anything to do with the contents of this patch :)\n\nCan you add this new test in a different patch please?","commit_id":"9af3a0ea3d5a4a597842a06ffc99fd77d11ddb7d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2302383448ea7bad1f4892933a6d94687bb3dcde","unresolved":false,"context_lines":[{"line_number":5223,"context_line":"        reservations \u003d list(\u0027fake_res\u0027)"},{"line_number":5224,"context_line":""},{"line_number":5225,"context_line":"        # Get initial memory usage"},{"line_number":5226,"context_line":"        free_ram_mb \u003d self.rt.compute_node.free_ram_mb"},{"line_number":5227,"context_line":""},{"line_number":5228,"context_line":"        self.compute.build_and_run_instance(self.context, instance, {}, {}, {},"},{"line_number":5229,"context_line":"                                            block_device_mapping\u003d[])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_6fec24c8","line":5226,"updated":"2016-12-22 15:32:31.000000000","message":"Instead of the free_ram_mb field, please perform validation against the memory_mb_used value. The free_ram_mb value is (supposed to be) a calculated field value that we are no longer using in calculations within the scheduler. We are now looking only at the memory_mb_used field value.","commit_id":"10703162422fcf86851a274a0a0dd3438cd00c25"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"13f5f395ec47e4608b0d7f4d960bd58750ae9676","unresolved":false,"context_lines":[{"line_number":5223,"context_line":"        reservations \u003d list(\u0027fake_res\u0027)"},{"line_number":5224,"context_line":""},{"line_number":5225,"context_line":"        # Get initial memory usage"},{"line_number":5226,"context_line":"        free_ram_mb \u003d self.rt.compute_node.free_ram_mb"},{"line_number":5227,"context_line":""},{"line_number":5228,"context_line":"        self.compute.build_and_run_instance(self.context, instance, {}, {}, {},"},{"line_number":5229,"context_line":"                                            block_device_mapping\u003d[])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_ef9014ef","line":5226,"in_reply_to":"da4df55a_6fec24c8","updated":"2016-12-22 16:12:05.000000000","message":"Done","commit_id":"10703162422fcf86851a274a0a0dd3438cd00c25"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2302383448ea7bad1f4892933a6d94687bb3dcde","unresolved":false,"context_lines":[{"line_number":5276,"context_line":"                                     clean_shutdown\u003dTrue)"},{"line_number":5277,"context_line":"        self.compute.finish_resize(self.context,"},{"line_number":5278,"context_line":"                    migration\u003dmigration, reservations\u003d[],"},{"line_number":5279,"context_line":"                    disk_info\u003d{}, image\u003d{}, instance\u003dinstance)"},{"line_number":5280,"context_line":""},{"line_number":5281,"context_line":"        # Prove that the instance size is now the new size"},{"line_number":5282,"context_line":"        flavor \u003d objects.Flavor.get_by_id(self.context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_af79ac31","line":5279,"updated":"2016-12-22 15:32:31.000000000","message":"Can we put a check in here that the memory_mb_used of the compute node equals the original memory_mb_used plus both the old and new instance type\u0027s memory_mb value?","commit_id":"10703162422fcf86851a274a0a0dd3438cd00c25"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"13f5f395ec47e4608b0d7f4d960bd58750ae9676","unresolved":false,"context_lines":[{"line_number":5276,"context_line":"                                     clean_shutdown\u003dTrue)"},{"line_number":5277,"context_line":"        self.compute.finish_resize(self.context,"},{"line_number":5278,"context_line":"                    migration\u003dmigration, reservations\u003d[],"},{"line_number":5279,"context_line":"                    disk_info\u003d{}, image\u003d{}, instance\u003dinstance)"},{"line_number":5280,"context_line":""},{"line_number":5281,"context_line":"        # Prove that the instance size is now the new size"},{"line_number":5282,"context_line":"        flavor \u003d objects.Flavor.get_by_id(self.context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_2f1dbc73","line":5279,"in_reply_to":"da4df55a_af79ac31","updated":"2016-12-22 16:12:05.000000000","message":"Done","commit_id":"10703162422fcf86851a274a0a0dd3438cd00c25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"359cc61dd148f192b185400efcf5535303a1b8c6","unresolved":false,"context_lines":[{"line_number":5279,"context_line":"                    migration\u003dmigration, reservations\u003d[],"},{"line_number":5280,"context_line":"                    disk_info\u003d{}, image\u003d{}, instance\u003dinstance)"},{"line_number":5281,"context_line":""},{"line_number":5282,"context_line":"        # Memory usage shouldn\u0027t had changed"},{"line_number":5283,"context_line":"        self.assertEqual(self.rt.compute_node.memory_mb_used,"},{"line_number":5284,"context_line":"             memory_mb_used + flavor.memory_mb +"},{"line_number":5285,"context_line":"             new_instance_type_ref.memory_mb)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_b082e4fe","line":5282,"range":{"start_line":5282,"start_character":33,"end_line":5282,"end_character":36},"updated":"2016-12-22 20:20:28.000000000","message":"have","commit_id":"373aa66f5995ba002f8b68f483505d3763413a18"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"359cc61dd148f192b185400efcf5535303a1b8c6","unresolved":false,"context_lines":[{"line_number":5565,"context_line":"                    migration\u003dmigration, reservations\u003d[],"},{"line_number":5566,"context_line":"                    disk_info\u003d{}, image\u003d{}, instance\u003dinstance)"},{"line_number":5567,"context_line":""},{"line_number":5568,"context_line":"        # Memory usage shouldn\u0027t had changed"},{"line_number":5569,"context_line":"        self.assertEqual(self.rt.compute_node.memory_mb_used,"},{"line_number":5570,"context_line":"            memory_mb_used + flavor.memory_mb +"},{"line_number":5571,"context_line":"            new_instance_type_ref.memory_mb)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_d09e8855","line":5568,"range":{"start_line":5568,"start_character":33,"end_line":5568,"end_character":36},"updated":"2016-12-22 20:20:28.000000000","message":"have","commit_id":"373aa66f5995ba002f8b68f483505d3763413a18"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"359cc61dd148f192b185400efcf5535303a1b8c6","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"                                                 ignore\u003d[\u0027stats\u0027]))"},{"line_number":1775,"context_line":"        # Confirm or revert resize"},{"line_number":1776,"context_line":"        if revert:"},{"line_number":1777,"context_line":"            flavor \u003d new_flavor"},{"line_number":1778,"context_line":"            prefix \u003d \u0027new_\u0027"},{"line_number":1779,"context_line":"        else:"},{"line_number":1780,"context_line":"            flavor \u003d old_flavor"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_d0404859","line":1777,"range":{"start_line":1777,"start_character":12,"end_line":1777,"end_character":31},"updated":"2016-12-22 20:20:28.000000000","message":"nit: in the case of revert in the compute manager we don\u0027t actually pass a flavor into drop_move_claim, so it\u0027s just looked up inside that method using the new_ prefix.","commit_id":"373aa66f5995ba002f8b68f483505d3763413a18"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"717213f5a1ae82f1177734b7f82180bdabb5c64a","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"                                                 ignore\u003d[\u0027stats\u0027]))"},{"line_number":1775,"context_line":"        # Confirm or revert resize"},{"line_number":1776,"context_line":"        if revert:"},{"line_number":1777,"context_line":"            flavor \u003d new_flavor"},{"line_number":1778,"context_line":"            prefix \u003d \u0027new_\u0027"},{"line_number":1779,"context_line":"        else:"},{"line_number":1780,"context_line":"            flavor \u003d old_flavor"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_fd385bf0","line":1777,"range":{"start_line":1777,"start_character":12,"end_line":1777,"end_character":31},"in_reply_to":"da4df55a_d0404859","updated":"2016-12-27 15:27:20.000000000","message":"Thanks Matt !","commit_id":"373aa66f5995ba002f8b68f483505d3763413a18"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2af937f14ae26adfd4316d1d7c14a5ab668e0851","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"    def test_instance_build_resize_confirm(self):"},{"line_number":1791,"context_line":"        self._test_instance_build_resize()"},{"line_number":1792,"context_line":""},{"line_number":1793,"context_line":"    def test_instance_build_resize_revert(self, revert\u003dTrue):"},{"line_number":1794,"context_line":"        self._test_instance_build_resize()"},{"line_number":1795,"context_line":""},{"line_number":1796,"context_line":"    @mock.patch(\u0027nova.pci.stats.PciDeviceStats.support_requests\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_239bb973","line":1793,"updated":"2016-12-26 17:56:24.000000000","message":"note that having revert\u003dTrue in the test method constructor doesn\u0027t do anything. You want to pass revert\u003dTrue to _test_instance_build_resize()...\n\nI\u0027m fixing this issue locally.","commit_id":"373aa66f5995ba002f8b68f483505d3763413a18"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"717213f5a1ae82f1177734b7f82180bdabb5c64a","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"    def test_instance_build_resize_confirm(self):"},{"line_number":1791,"context_line":"        self._test_instance_build_resize()"},{"line_number":1792,"context_line":""},{"line_number":1793,"context_line":"    def test_instance_build_resize_revert(self, revert\u003dTrue):"},{"line_number":1794,"context_line":"        self._test_instance_build_resize()"},{"line_number":1795,"context_line":""},{"line_number":1796,"context_line":"    @mock.patch(\u0027nova.pci.stats.PciDeviceStats.support_requests\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_1d151f48","line":1793,"in_reply_to":"da4df55a_239bb973","updated":"2016-12-27 15:27:20.000000000","message":"Jeez, missed that as well (how could I :)). Thanks Jay !","commit_id":"373aa66f5995ba002f8b68f483505d3763413a18"}]}