)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5e2614a011c65538b4eff013c9d00b3c0761032","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            \u0027nova.objects.CellMappingList._get_all_from_db\u0027,"},{"line_number":259,"context_line":"            self._fake_cell_list))"},{"line_number":260,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":261,"context_line":"            \u0027nova.conductor.manager.try_target_cell\u0027,"},{"line_number":262,"context_line":"            self._fake_target_cell))"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _fake_cell_list(self, *args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_4b9b0266","line":261,"updated":"2016-12-07 01:58:36.000000000","message":"This doesn\u0027t actually exist...","commit_id":"a630568d08ce1d00baf9579cc89621cba3576c21"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9710cfd5e8f923d43da4877da6e6acf44282fe5c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            \u0027nova.objects.CellMappingList._get_all_from_db\u0027,"},{"line_number":259,"context_line":"            self._fake_cell_list))"},{"line_number":260,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":261,"context_line":"            \u0027nova.conductor.manager.try_target_cell\u0027,"},{"line_number":262,"context_line":"            self._fake_target_cell))"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _fake_cell_list(self, *args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_cbd552e5","line":261,"in_reply_to":"3a71b18c_4b9b0266","updated":"2016-12-07 02:01:29.000000000","message":"I guess it\u0027s added later in the series here:\n\nhttps://review.openstack.org/#/c/367557/29/nova/conductor/manager.py@156\n\nCan we monkey patch that out in the actual change that adds it?","commit_id":"a630568d08ce1d00baf9579cc89621cba3576c21"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"32899ac78d0d1b3f82a26d8347e6b790730a5d78","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            \u0027nova.objects.CellMappingList._get_all_from_db\u0027,"},{"line_number":259,"context_line":"            self._fake_cell_list))"},{"line_number":260,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":261,"context_line":"            \u0027nova.conductor.manager.try_target_cell\u0027,"},{"line_number":262,"context_line":"            self._fake_target_cell))"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _fake_cell_list(self, *args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_8f9ee661","line":261,"in_reply_to":"3a71b18c_cbd552e5","updated":"2016-12-07 15:48:15.000000000","message":"I think I should mock out the underlying thing anyway, so yeah I\u0027ll fix this.","commit_id":"a630568d08ce1d00baf9579cc89621cba3576c21"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5e2614a011c65538b4eff013c9d00b3c0761032","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _fake_cell_list(self, *args):"},{"line_number":265,"context_line":"        return [{\u0027id\u0027: 1,"},{"line_number":266,"context_line":"                 \u0027deleted\u0027: False,"},{"line_number":267,"context_line":"                 \u0027deleted_at\u0027: None,"},{"line_number":268,"context_line":"                 \u0027updated_at\u0027: None,"},{"line_number":269,"context_line":"                 \u0027created_at\u0027: None,"},{"line_number":270,"context_line":"                 \u0027uuid\u0027: uuidsentinel.cell1,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_4b84e209","line":267,"range":{"start_line":266,"start_character":17,"end_line":267,"end_character":36},"updated":"2016-12-07 01:58:36.000000000","message":"We don\u0027t actually use the SoftDeleteMixin on these.","commit_id":"a630568d08ce1d00baf9579cc89621cba3576c21"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"21bd0c5fc2a031290d8e0e8e389869ebe432b8df","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _fake_cell_list(self, *args):"},{"line_number":265,"context_line":"        return [{\u0027id\u0027: 1,"},{"line_number":266,"context_line":"                 \u0027deleted\u0027: False,"},{"line_number":267,"context_line":"                 \u0027deleted_at\u0027: None,"},{"line_number":268,"context_line":"                 \u0027updated_at\u0027: None,"},{"line_number":269,"context_line":"                 \u0027created_at\u0027: None,"},{"line_number":270,"context_line":"                 \u0027uuid\u0027: uuidsentinel.cell1,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_2fd5d2b8","line":267,"range":{"start_line":266,"start_character":17,"end_line":267,"end_character":36},"in_reply_to":"3a71b18c_0fb3b60b","updated":"2016-12-07 15:51:49.000000000","message":"Ah, because it\u0027s a timestamp object and I just did the kneejerk thing when I saw it fail to load updated_at.","commit_id":"a630568d08ce1d00baf9579cc89621cba3576c21"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"32899ac78d0d1b3f82a26d8347e6b790730a5d78","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _fake_cell_list(self, *args):"},{"line_number":265,"context_line":"        return [{\u0027id\u0027: 1,"},{"line_number":266,"context_line":"                 \u0027deleted\u0027: False,"},{"line_number":267,"context_line":"                 \u0027deleted_at\u0027: None,"},{"line_number":268,"context_line":"                 \u0027updated_at\u0027: None,"},{"line_number":269,"context_line":"                 \u0027created_at\u0027: None,"},{"line_number":270,"context_line":"                 \u0027uuid\u0027: uuidsentinel.cell1,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_0fb3b60b","line":267,"range":{"start_line":266,"start_character":17,"end_line":267,"end_character":36},"in_reply_to":"3a71b18c_4b84e209","updated":"2016-12-07 15:48:15.000000000","message":"Hmm, I added this because I got a failure to load them on the deleted flag. But yeah. I\u0027ll have a look.","commit_id":"a630568d08ce1d00baf9579cc89621cba3576c21"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"296fde741af901c6e559e59b615c82ca90347ef1","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                        \u0027do use the database and cause failures later.\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"class SingleCellSimple(fixtures.Fixture):"},{"line_number":255,"context_line":"    def setUp(self):"},{"line_number":256,"context_line":"        super(SingleCellSimple, self).setUp()"},{"line_number":257,"context_line":"        self.useFixture(fixtures.MonkeyPatch("}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_0043836d","line":254,"updated":"2016-12-07 16:42:21.000000000","message":"nit: it would be nice to have a docstring on what this fixtures does or what it\u0027s useful for. I see most of the other fixtures in here have usage docs.","commit_id":"437c17ce243d97cbe05d07af995b85f05aef484f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"48b76f3d0cc796562785220d14d1addb8c94dc56","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                        \u0027do use the database and cause failures later.\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"class SingleCellSimple(fixtures.Fixture):"},{"line_number":255,"context_line":"    def setUp(self):"},{"line_number":256,"context_line":"        super(SingleCellSimple, self).setUp()"},{"line_number":257,"context_line":"        self.useFixture(fixtures.MonkeyPatch("}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_465bd42e","line":254,"in_reply_to":"3a71b18c_0043836d","updated":"2016-12-07 16:45:19.000000000","message":"agree, the fixtures end up being things that people gloss over as magic later, so giving an overview is helpful.","commit_id":"437c17ce243d97cbe05d07af995b85f05aef484f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"047eacaf4a0f7ddd4fcaab951b958628afd40cc8","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                        \u0027do use the database and cause failures later.\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"class SingleCellSimple(fixtures.Fixture):"},{"line_number":255,"context_line":"    \"\"\"Setup the simplest cells environment possible"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    This should be used when you do not care about multiple cells,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_9e5b612e","line":254,"updated":"2016-12-08 00:49:29.000000000","message":"I sort of feel like at some point we\u0027re going to need one fixture to rule them all so that we\u0027re always running with all of the cellsv2 goodies enabled by default in all tests, like what I\u0027m trying to get to with running with use_neutron\u003dTrue by default, especially as we CI test with cellvs2 now. But I know we\u0027re making incremental improvements.","commit_id":"419bbc88475daabd0fed90d2c2b86b41365e1e48"}],"nova/tests/unit/test_fixtures.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"296fde741af901c6e559e59b615c82ca90347ef1","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def test_target_cell(self):"},{"line_number":467,"context_line":"        self.useFixture(fixtures.SingleCellSimple())"},{"line_number":468,"context_line":"        with context.target_cell(mock.sentinel.context, None) as c:"},{"line_number":469,"context_line":"            self.assertEqual(mock.sentinel.context, c)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_80579325","line":469,"range":{"start_line":469,"start_character":17,"end_line":469,"end_character":28},"updated":"2016-12-07 16:42:21.000000000","message":"nit: assertIs might be a tad better.","commit_id":"437c17ce243d97cbe05d07af995b85f05aef484f"}]}