)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d6c82bd79c61515c8169ade6f8503e3087c0d75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a461143_27af8c95","updated":"2017-01-26 15:59:32.000000000","message":"This is almost mdboot-esque. I do love a good commit message :)","commit_id":"81defe68d163dcf9528678ef5f7295b878e02255"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"fe967b464aeeb05471e98981960ce73a0063977e","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        LOG.debug(\u0027Sending allocation for instance %s\u0027,"},{"line_number":443,"context_line":"                  my_allocations,"},{"line_number":444,"context_line":"                  instance\u003dinstance)"},{"line_number":445,"context_line":"        res \u003d self._put_allocations(rp_uuid, instance.uuid, my_allocations)"},{"line_number":446,"context_line":"        if res:"},{"line_number":447,"context_line":"            LOG.info(_LI(\u0027Submitted allocation for instance\u0027),"},{"line_number":448,"context_line":"                     instance\u003dinstance)"},{"line_number":449,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_501a227e","line":446,"range":{"start_line":445,"start_character":0,"end_line":446,"end_character":15},"updated":"2016-12-05 13:15:51.000000000","message":"nit: there is no need to assign result to new variable. How about:\n\n    if self._put_allocations(rp_uuid, instance.uuid, my_allocations):\n\n?","commit_id":"b7957059fd7ea0b07466b304172aa033b42e6c4b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f55af95d914dbdca51dbaa5c9138397bbb3202a1","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                      {\u0027uuid\u0027: instance.uuid, \u0027alloc\u0027: allocstr})"},{"line_number":600,"context_line":"            return"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        LOG.debug(\u0027Sending allocation for instance %s\u0027,"},{"line_number":603,"context_line":"                  my_allocations,"},{"line_number":604,"context_line":"                  instance\u003dinstance)"},{"line_number":605,"context_line":"        res \u003d self._put_allocations(rp_uuid, instance.uuid, my_allocations)"},{"line_number":606,"context_line":"        if res:"},{"line_number":607,"context_line":"            LOG.info(_LI(\u0027Submitted allocation for instance\u0027),"},{"line_number":608,"context_line":"                     instance\u003dinstance)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    @safe_connect"},{"line_number":611,"context_line":"    def _put_allocations(self, rp_uuid, consumer_uuid, alloc_data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_f69394f8","line":608,"range":{"start_line":602,"start_character":8,"end_line":608,"end_character":39},"updated":"2017-01-26 01:44:00.000000000","message":"nit: could have just left the pre/post logging in _put_allocations but whatever.","commit_id":"81defe68d163dcf9528678ef5f7295b878e02255"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f55af95d914dbdca51dbaa5c9138397bbb3202a1","unresolved":false,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    @safe_connect"},{"line_number":611,"context_line":"    def _put_allocations(self, rp_uuid, consumer_uuid, alloc_data):"},{"line_number":612,"context_line":"        \"\"\"Creates allocation records for the supplied instance UUID against"},{"line_number":613,"context_line":"        the supplied resource provider."},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        :note Currently we only allocate against a single resource provider."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_b66d8c34","line":612,"range":{"start_line":612,"start_character":55,"end_line":612,"end_character":63},"updated":"2017-01-26 01:44:00.000000000","message":"nit: call it \u0027consumer\u0027 uuid if you\u0027re going to be generic about the input arg name?","commit_id":"81defe68d163dcf9528678ef5f7295b878e02255"}]}
