)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2a8c463aa99321ff9bc75f2a071af6dc0aa41846","unresolved":false,"context_lines":[{"line_number":10,"context_line":"13.0.0, we can remove it now."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp centralize-config-options-ocata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I84503655bd9675ff441073e51059202142db22ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_f3eb9cae","line":13,"updated":"2016-12-08 10:26:30.000000000","message":"It would help to include the \u0027Depends-on\u0027 line from the original patch to indicate why sdague\u0027s note is finally resolved\n\n  Depends-On: I93b62372e357db4f7c39992c244b2ec9e594ad9c\n\nFrom https://review.openstack.org/#/c/319532/16//COMMIT_MSG","commit_id":"1962cfc5769d473624707d006d02801fc27e8c15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2369bc7008e22d8c6e5b761ec69590a3b6b7e8de","unresolved":false,"context_lines":[{"line_number":10,"context_line":"13.0.0, we can remove it now."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp centralize-config-options-ocata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I84503655bd9675ff441073e51059202142db22ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a71b18c_f302bc6e","line":13,"updated":"2016-12-08 10:27:03.000000000","message":"It would help to include the \u0027Depends-on\u0027 line from the original patch to indicate why sdague\u0027s note is finally resolved\n\n  Depends-On: I93b62372e357db4f7c39992c244b2ec9e594ad9c\n\nFrom https://review.openstack.org/#/c/319532/16//COMMIT_MSG","commit_id":"db828ed1b7be775237fb978f9793b6fc26ee6514"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"26b5ed144ccf5c670ecc5bc9251929af9833ce16","unresolved":false,"context_lines":[{"line_number":10,"context_line":"13.0.0, we can remove it now."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp centralize-config-options-ocata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I84503655bd9675ff441073e51059202142db22ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a71b18c_bfb3a509","line":13,"in_reply_to":"3a71b18c_f302bc6e","updated":"2016-12-08 11:50:15.000000000","message":"Done","commit_id":"db828ed1b7be775237fb978f9793b6fc26ee6514"}],"nova/conf/service.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"8ab951c07179ae0105514b2932a354b7415876a6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"* Any positive integer"},{"line_number":158,"context_line":"* None (default value)"},{"line_number":159,"context_line":"\"\"\"),"},{"line_number":160,"context_line":"    # NOTE(sdague): Ironic is still using this facility for their HA"},{"line_number":161,"context_line":"    # manager. Ensure they are sorted before removing this."},{"line_number":162,"context_line":"    cfg.StrOpt(\u0027compute_manager\u0027,"},{"line_number":163,"context_line":"               default\u003d\u0027nova.compute.manager.ComputeManager\u0027,"},{"line_number":164,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_a012a160","side":"PARENT","line":161,"range":{"start_line":160,"start_character":0,"end_line":161,"end_character":59},"updated":"2016-12-02 05:44:34.000000000","message":"Ironic remove it  in https://review.openstack.org/#/c/397762/,\nbut revert in https://review.openstack.org/#/c/399100/ due to the deprecated period is less than 90 days.\n\nIronic deprecated HA manager in https://github.com/openstack/ironic/commit/d1c47cbf72a77b2b32c6bf5ac46acd57455200a8","commit_id":"c4ed9a526eebc75d08667dcc9d62cac37620e24d"}],"nova/service.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c2dc314a2e0be91c69ba22a12b228dc6fdc59a2","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            topic \u003d binary.rpartition(\u0027nova-\u0027)[2]"},{"line_number":210,"context_line":"        if not manager:"},{"line_number":211,"context_line":"            manager \u003d SERVICE_MANAGERS.get(binary)"},{"line_number":212,"context_line":"            # NOTE(gcb) manager can be None when binary is nova-network,"},{"line_number":213,"context_line":"            # still need get manger from CONF."},{"line_number":214,"context_line":"            if manager is None:"},{"line_number":215,"context_line":"                manager_cls \u003d (\u0027%s_manager\u0027 %"},{"line_number":216,"context_line":"                               binary.rpartition(\u0027nova-\u0027)[2])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_f0c6d566","line":213,"range":{"start_line":212,"start_character":0,"end_line":213,"end_character":46},"updated":"2016-12-05 10:46:16.000000000","message":"Oh, it\u0027s back again :) Yay","commit_id":"23349396e8dc8099fdbecacdba81f6a2165bfb43"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6fa1d9e22416a1fbc6192f8ae4e4d5c2692bf1aa","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        if not topic:"},{"line_number":209,"context_line":"            topic \u003d binary.rpartition(\u0027nova-\u0027)[2]"},{"line_number":210,"context_line":"        if not manager:"},{"line_number":211,"context_line":"            manager \u003d SERVICE_MANAGERS.get(binary)"},{"line_number":212,"context_line":"        if report_interval is None:"},{"line_number":213,"context_line":"            report_interval \u003d CONF.report_interval"},{"line_number":214,"context_line":"        if periodic_enable is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_22c39539","line":211,"range":{"start_line":211,"start_character":12,"end_line":211,"end_character":50},"updated":"2016-12-05 16:00:42.000000000","message":"It might be worth not using \u0027.get\u0027 so we raise a KeyError early. As things stand, however, this will fail on L221/222 because of the call in L101 so I\u0027m happy to let this slide","commit_id":"51b044fcbfe3642ffebd8e62aa4c70b6cb6085db"}],"nova/tests/unit/test_service.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0f3763e1fd4af7e5a0d5bcd15974e405772210c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        #             the looping calls are created in StartService."},{"line_number":106,"context_line":"        app \u003d service.Service.create(host\u003dself.host, binary\u003dself.binary,"},{"line_number":107,"context_line":"                topic\u003dself.topic,"},{"line_number":108,"context_line":"                manager\u003d\u0027nova.tests.unit.test_service.FakeManager\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.assertTrue(app)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_f09d525a","line":108,"range":{"start_line":108,"start_character":24,"end_line":108,"end_character":66},"updated":"2016-12-08 10:09:07.000000000","message":"Do we not need to use the value of the configuration option on line 40?","commit_id":"db828ed1b7be775237fb978f9793b6fc26ee6514"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"26b5ed144ccf5c670ecc5bc9251929af9833ce16","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        #             the looping calls are created in StartService."},{"line_number":106,"context_line":"        app \u003d service.Service.create(host\u003dself.host, binary\u003dself.binary,"},{"line_number":107,"context_line":"                topic\u003dself.topic,"},{"line_number":108,"context_line":"                manager\u003d\u0027nova.tests.unit.test_service.FakeManager\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.assertTrue(app)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_df806149","line":108,"range":{"start_line":108,"start_character":24,"end_line":108,"end_character":66},"in_reply_to":"3a71b18c_f09d525a","updated":"2016-12-08 11:50:15.000000000","message":"yes, good catch","commit_id":"db828ed1b7be775237fb978f9793b6fc26ee6514"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c25d040a4d045a2f872d5123abef8943a9a94e70","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        #             the looping calls are created in StartService."},{"line_number":106,"context_line":"        app \u003d service.Service.create(host\u003dself.host, binary\u003dself.binary,"},{"line_number":107,"context_line":"                topic\u003dself.topic,"},{"line_number":108,"context_line":"                manager\u003dCONF.fake_manager)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.assertTrue(app)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_5f4611c0","line":108,"range":{"start_line":108,"start_character":24,"end_line":108,"end_character":41},"updated":"2016-12-08 11:57:10.000000000","message":"actually, sorry for misdirecting you but it seems we don\u0027t use this anywhere at the moment and haven\u0027t for a very long time. Maybe that config option should just be dropped (in a later patch) instead?\n\n  $ git checkout master\n  $ ag fake_manager\n  nova/tests/unit/test_service.py\n  40:    cfg.StrOpt(\"fake_manager\",\n  $ git checkout juno-eol\n  $ ag fake_manager\n  nova/tests/unit/test_service.py\n  40:    cfg.StrOpt(\"fake_manager\",","commit_id":"23ba2e5c9059c42a12af5f4ba91e2e79560bb38b"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"a6dddc14960582ca1cf0011d4b8afaff99f62076","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        #             the looping calls are created in StartService."},{"line_number":106,"context_line":"        app \u003d service.Service.create(host\u003dself.host, binary\u003dself.binary,"},{"line_number":107,"context_line":"                topic\u003dself.topic,"},{"line_number":108,"context_line":"                manager\u003dCONF.fake_manager)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.assertTrue(app)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_bf11e55f","line":108,"range":{"start_line":108,"start_character":24,"end_line":108,"end_character":41},"in_reply_to":"3a71b18c_5f4611c0","updated":"2016-12-08 12:03:23.000000000","message":"ok, I will update with constant string \"nova.tests.unit.test_service.FakeManager\"  and drop the config option in separated patch.","commit_id":"23ba2e5c9059c42a12af5f4ba91e2e79560bb38b"}]}