)]}'
{"nova/api/openstack/compute/simple_tenant_usage.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01c5c7875098cdcfc3c257116196ec8c7419d02c","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            if detailed:"},{"line_number":174,"context_line":"                summary[\u0027server_usages\u0027].append(info)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return list(rval.values())"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _parse_datetime(self, dtstr):"},{"line_number":179,"context_line":"        if not dtstr:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_c621404f","line":176,"range":{"start_line":176,"start_character":15,"end_line":176,"end_character":34},"updated":"2016-12-03 13:37:28.000000000","message":"do we really need this? .values() already return view object.","commit_id":"342fc65bc1cfcc3b7796023462fc32154f8596f2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65ffae853fadec9353acec03f36111d73f0fbe7a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            if detailed:"},{"line_number":174,"context_line":"                summary[\u0027server_usages\u0027].append(info)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return list(rval.values())"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _parse_datetime(self, dtstr):"},{"line_number":179,"context_line":"        if not dtstr:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_472bbc33","line":176,"range":{"start_line":176,"start_character":15,"end_line":176,"end_character":34},"in_reply_to":"3a71b18c_4f1c6077","updated":"2016-12-08 03:01:14.000000000","message":"yea we cannot index on that but still can iterate. I am ok to return indexed list.","commit_id":"342fc65bc1cfcc3b7796023462fc32154f8596f2"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"d243895e9966d7133cb237178f4ac47425179a25","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            if detailed:"},{"line_number":174,"context_line":"                summary[\u0027server_usages\u0027].append(info)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return list(rval.values())"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _parse_datetime(self, dtstr):"},{"line_number":179,"context_line":"        if not dtstr:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_4f1c6077","line":176,"range":{"start_line":176,"start_character":15,"end_line":176,"end_character":34},"in_reply_to":"3a71b18c_c621404f","updated":"2016-12-04 08:19:22.000000000","message":"without this change, failed on Python 3 with following errors:\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    b\u0027Traceback (most recent call last):\u0027\n    b\u0027  File \"/home/changboguo/code/os/nova/.tox/py34/lib/python3.4/site-packages/mock/mock.py\", line 1305, in patched\u0027\n    b\u0027    return func(*args, **keywargs)\u0027\n    b\u0027  File \"/home/changboguo/code/os/nova/nova/tests/unit/api/openstack/compute/test_simple_tenant_usage.py\", line 137, in test_verify_index_future_end_time\u0027\n    b\u0027    self._test_verify_index(START, future)\u0027\n    b\u0027  File \"/home/changboguo/code/os/nova/nova/tests/unit/api/openstack/compute/test_simple_tenant_usage.py\", line 123, in _test_verify_index\u0027\n    b\"    self.assertEqual(SERVERS * HOURS, int(usages[i][\u0027total_hours\u0027]))\"\n    b\"TypeError: \u0027dict_values\u0027 object does not support indexing\"\n    b\u0027\u0027","commit_id":"342fc65bc1cfcc3b7796023462fc32154f8596f2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65ffae853fadec9353acec03f36111d73f0fbe7a","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                               tenant_id\u003dtenant_id,"},{"line_number":263,"context_line":"                                               detailed\u003dTrue)"},{"line_number":264,"context_line":"        if len(usage):"},{"line_number":265,"context_line":"            usage \u003d list(usage)[0]"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            usage \u003d {}"},{"line_number":268,"context_line":"        return {\u0027tenant_usage\u0027: usage}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_47d2dc35","line":265,"range":{"start_line":265,"start_character":20,"end_line":265,"end_character":31},"updated":"2016-12-08 03:01:14.000000000","message":"this can be just usage[0] now","commit_id":"342fc65bc1cfcc3b7796023462fc32154f8596f2"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"b26473d7728d0344ed7a7e553fedb6fa85c39b3e","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                               tenant_id\u003dtenant_id,"},{"line_number":263,"context_line":"                                               detailed\u003dTrue)"},{"line_number":264,"context_line":"        if len(usage):"},{"line_number":265,"context_line":"            usage \u003d list(usage)[0]"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            usage \u003d {}"},{"line_number":268,"context_line":"        return {\u0027tenant_usage\u0027: usage}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_92f27005","line":265,"range":{"start_line":265,"start_character":20,"end_line":265,"end_character":31},"in_reply_to":"3a71b18c_47d2dc35","updated":"2016-12-08 03:35:17.000000000","message":"Done","commit_id":"342fc65bc1cfcc3b7796023462fc32154f8596f2"}]}