)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"93fb80d0667c18d3dea4bcac88644ff787160bb3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Post step could fail due to auth token expiration."},{"line_number":10,"context_line":"get_instance_nw_info fails with authentication required,"},{"line_number":11,"context_line":"because there are several call to neutron api, some of them"},{"line_number":12,"context_line":"are admin context, while others tries to use token from request"},{"line_number":13,"context_line":"cotext. This patch ensure that if admin context is initally used,"},{"line_number":14,"context_line":"all subsequent calls will use the same initialized client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_846fe4fa","line":11,"updated":"2016-12-06 15:00:31.000000000","message":"s/call/calls/","commit_id":"9de4ac2cf1df03f3cec9966e3af5763a94c1f065"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"428fa9f8dba8ef5331216f3b69776d3ae636ee27","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Post step could fail due to auth token expiration."},{"line_number":10,"context_line":"get_instance_nw_info fails with authentication required,"},{"line_number":11,"context_line":"because there are several call to neutron api, some of them"},{"line_number":12,"context_line":"are admin context, while others tries to use token from request"},{"line_number":13,"context_line":"cotext. This patch ensure that if admin context is initally used,"},{"line_number":14,"context_line":"all subsequent calls will use the same initialized client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_0396dc4b","line":11,"in_reply_to":"3a71b18c_846fe4fa","updated":"2016-12-09 08:03:02.000000000","message":"Done","commit_id":"9de4ac2cf1df03f3cec9966e3af5763a94c1f065"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"93fb80d0667c18d3dea4bcac88644ff787160bb3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Post step could fail due to auth token expiration."},{"line_number":10,"context_line":"get_instance_nw_info fails with authentication required,"},{"line_number":11,"context_line":"because there are several call to neutron api, some of them"},{"line_number":12,"context_line":"are admin context, while others tries to use token from request"},{"line_number":13,"context_line":"cotext. This patch ensure that if admin context is initally used,"},{"line_number":14,"context_line":"all subsequent calls will use the same initialized client"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_047cb4b3","line":12,"updated":"2016-12-06 15:00:31.000000000","message":"s/tries/try/","commit_id":"9de4ac2cf1df03f3cec9966e3af5763a94c1f065"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"428fa9f8dba8ef5331216f3b69776d3ae636ee27","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Post step could fail due to auth token expiration."},{"line_number":10,"context_line":"get_instance_nw_info fails with authentication required,"},{"line_number":11,"context_line":"because there are several call to neutron api, some of them"},{"line_number":12,"context_line":"are admin context, while others tries to use token from request"},{"line_number":13,"context_line":"cotext. This patch ensure that if admin context is initally used,"},{"line_number":14,"context_line":"all subsequent calls will use the same initialized client"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_23911853","line":12,"in_reply_to":"3a71b18c_047cb4b3","updated":"2016-12-09 08:03:02.000000000","message":"Done","commit_id":"9de4ac2cf1df03f3cec9966e3af5763a94c1f065"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"93fb80d0667c18d3dea4bcac88644ff787160bb3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"get_instance_nw_info fails with authentication required,"},{"line_number":11,"context_line":"because there are several call to neutron api, some of them"},{"line_number":12,"context_line":"are admin context, while others tries to use token from request"},{"line_number":13,"context_line":"cotext. This patch ensure that if admin context is initally used,"},{"line_number":14,"context_line":"all subsequent calls will use the same initialized client"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1647451"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_244d309a","line":13,"updated":"2016-12-06 15:00:31.000000000","message":"s/cotext/context/\n\ns/initally/initially/","commit_id":"9de4ac2cf1df03f3cec9966e3af5763a94c1f065"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"428fa9f8dba8ef5331216f3b69776d3ae636ee27","unresolved":false,"context_lines":[{"line_number":10,"context_line":"get_instance_nw_info fails with authentication required,"},{"line_number":11,"context_line":"because there are several call to neutron api, some of them"},{"line_number":12,"context_line":"are admin context, while others tries to use token from request"},{"line_number":13,"context_line":"cotext. This patch ensure that if admin context is initally used,"},{"line_number":14,"context_line":"all subsequent calls will use the same initialized client"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1647451"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_43a0d49f","line":13,"in_reply_to":"3a71b18c_244d309a","updated":"2016-12-09 08:03:02.000000000","message":"Done","commit_id":"9de4ac2cf1df03f3cec9966e3af5763a94c1f065"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"a590afde5a1211670d4d509e605c83e476ce2a6d","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"        return network_model.NetworkInfo.hydrate(nw_info)"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"    def _gather_port_ids_and_networks(self, context, instance, networks\u003dNone,"},{"line_number":1286,"context_line":"                                      port_ids\u003dNone, neutron\u003dNone):"},{"line_number":1287,"context_line":"        \"\"\"Return an instance\u0027s complete list of port_ids and networks.\"\"\""},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"        if ((networks is None and port_ids is not None) or"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_23faadbd","line":1286,"range":{"start_line":1286,"start_character":53,"end_line":1286,"end_character":65},"updated":"2016-12-12 09:57:59.000000000","message":"I don\u0027t like the name of this variable, because it would indicate to me that it\u0027s just a true/false, but it has the same name in _get_available_networks, so meh...","commit_id":"4a5ecf1e29c3bdbb022f98a5fba41d4e7df56d88"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"6bdac457bb9322ad232636cba82282af5dea8528","unresolved":false,"context_lines":[{"line_number":800,"context_line":""},{"line_number":801,"context_line":"class TestNeutronv2(TestNeutronv2Base):"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    def setUp(self):"},{"line_number":804,"context_line":"        super(TestNeutronv2, self).setUp()"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"    def test_get_instance_nw_info_1(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_cf4e693a","line":803,"updated":"2016-12-06 08:54:05.000000000","message":"nit: this method becomes redundant now - you could just remove it completely, so that setUp() of the super class is used","commit_id":"727257f45bb42fb553d960e42f56899650cdf88a"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"e3b884a2a2f7c02a81f0aebf3cd0f22bd57e7657","unresolved":false,"context_lines":[{"line_number":800,"context_line":""},{"line_number":801,"context_line":"class TestNeutronv2(TestNeutronv2Base):"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    def setUp(self):"},{"line_number":804,"context_line":"        super(TestNeutronv2, self).setUp()"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"    def test_get_instance_nw_info_1(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_00010e38","line":803,"in_reply_to":"3a71b18c_cf4e693a","updated":"2016-12-06 09:53:46.000000000","message":"Done","commit_id":"727257f45bb42fb553d960e42f56899650cdf88a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"6bdac457bb9322ad232636cba82282af5dea8528","unresolved":false,"context_lines":[{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    def test_allocate_for_instance_1(self):"},{"line_number":1094,"context_line":"        # Allocate one port in one network env."},{"line_number":1095,"context_line":"        neutronapi.get_client(mox.IgnoreArg()).MultipleTimes().AndReturn("},{"line_number":1096,"context_line":"            self.moxed_client)"},{"line_number":1097,"context_line":"        self._allocate_for_instance(1)"},{"line_number":1098,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_0f2f81a1","line":1095,"updated":"2016-12-06 08:54:05.000000000","message":"hmm, I wonder why this (and below) stills says \"MultipleTimes\", don\u0027t we want to make sure allocate_for_instace() call uses only one instance of a neutron client?","commit_id":"727257f45bb42fb553d960e42f56899650cdf88a"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"e3b884a2a2f7c02a81f0aebf3cd0f22bd57e7657","unresolved":false,"context_lines":[{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    def test_allocate_for_instance_1(self):"},{"line_number":1094,"context_line":"        # Allocate one port in one network env."},{"line_number":1095,"context_line":"        neutronapi.get_client(mox.IgnoreArg()).MultipleTimes().AndReturn("},{"line_number":1096,"context_line":"            self.moxed_client)"},{"line_number":1097,"context_line":"        self._allocate_for_instance(1)"},{"line_number":1098,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_e08c12dc","line":1095,"in_reply_to":"3a71b18c_0f2f81a1","updated":"2016-12-06 09:53:46.000000000","message":"right, removed that in the next ps. Thanks!","commit_id":"727257f45bb42fb553d960e42f56899650cdf88a"}]}