)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7a9406f07b7726dd5bcfc396eb38e5b9115c8699","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we create instance snapshot, Nova is using disk size in"},{"line_number":10,"context_line":"flavor to set min_disk property in image even if it\u0027s a"},{"line_number":11,"context_line":"volume-backend instance. If disk size is bigger then volume"},{"line_number":12,"context_line":"size, Nova will raise exception when using this image to"},{"line_number":13,"context_line":"create a new one."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_bda04af5","line":11,"updated":"2016-12-07 10:30:42.000000000","message":"s/then/than","commit_id":"aa6420af022e5069828bb4ad330a6643352a0b00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"9453b8c678dfca2cc51fd3bd0e11edee229a8b74","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we create instance snapshot, Nova is using disk size in"},{"line_number":10,"context_line":"flavor to set min_disk property in image even if it\u0027s a"},{"line_number":11,"context_line":"volume-backend instance. If disk size is bigger then volume"},{"line_number":12,"context_line":"size, Nova will raise exception when using this image to"},{"line_number":13,"context_line":"create a new one."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_3e5dedec","line":11,"in_reply_to":"3a71b18c_bda04af5","updated":"2016-12-08 00:57:23.000000000","message":"Done","commit_id":"aa6420af022e5069828bb4ad330a6643352a0b00"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7a9406f07b7726dd5bcfc396eb38e5b9115c8699","unresolved":false,"context_lines":[{"line_number":12,"context_line":"size, Nova will raise exception when using this image to"},{"line_number":13,"context_line":"create a new one."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To fix this issue by setting min_disk in image meta based on"},{"line_number":16,"context_line":"the root volume\u0027s size."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I89bd7b049ffcb8317053cd8f47a58448854bfd8a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_5db8162a","line":15,"updated":"2016-12-07 10:30:42.000000000","message":"Fixing this issue","commit_id":"aa6420af022e5069828bb4ad330a6643352a0b00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"9453b8c678dfca2cc51fd3bd0e11edee229a8b74","unresolved":false,"context_lines":[{"line_number":12,"context_line":"size, Nova will raise exception when using this image to"},{"line_number":13,"context_line":"create a new one."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To fix this issue by setting min_disk in image meta based on"},{"line_number":16,"context_line":"the root volume\u0027s size."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I89bd7b049ffcb8317053cd8f47a58448854bfd8a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_5e62a9ae","line":15,"in_reply_to":"3a71b18c_5db8162a","updated":"2016-12-08 00:57:23.000000000","message":"Done","commit_id":"aa6420af022e5069828bb4ad330a6643352a0b00"}],"nova/compute/api.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"f0870d6572f58a5393c341732f90076541d1d6ee","unresolved":false,"context_lines":[{"line_number":2791,"context_line":"                # NOTE(wanghao): If instance is volume backend, we should set"},{"line_number":2792,"context_line":"                #                the min_disk in the image meta based on the"},{"line_number":2793,"context_line":"                #                root volume\u0027s size."},{"line_number":2794,"context_line":"                if mapping_dict[\u0027boot_index\u0027] \u003d\u003d 0:"},{"line_number":2795,"context_line":"                    image_meta[\u0027min_disk\u0027] \u003d volume[\u0027size\u0027]"},{"line_number":2796,"context_line":"            else:"},{"line_number":2797,"context_line":"                mapping_dict \u003d bdm.get_image_mapping()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_117c401e","line":2794,"updated":"2017-02-14 07:57:17.000000000","message":"For the reason to simplify reading of the code i\u0027d propose to do this above the loop near other image_meta attributes are assigned. We might have smth like:\n\n image_meta[\u0027min_disk\u0027] \u003d bdms.root_bdm().volume_size","commit_id":"50eaf05ebf885c19b19e771ae7da82f4d676f986"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"6dcb7449d94804fa88332c8ed11f73a7694b44fe","unresolved":false,"context_lines":[{"line_number":2791,"context_line":"                # NOTE(wanghao): If instance is volume backend, we should set"},{"line_number":2792,"context_line":"                #                the min_disk in the image meta based on the"},{"line_number":2793,"context_line":"                #                root volume\u0027s size."},{"line_number":2794,"context_line":"                if mapping_dict[\u0027boot_index\u0027] \u003d\u003d 0:"},{"line_number":2795,"context_line":"                    image_meta[\u0027min_disk\u0027] \u003d volume[\u0027size\u0027]"},{"line_number":2796,"context_line":"            else:"},{"line_number":2797,"context_line":"                mapping_dict \u003d bdm.get_image_mapping()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_f411d3b0","line":2794,"in_reply_to":"fa31d9ce_117c401e","updated":"2017-02-20 08:53:42.000000000","message":"Now we try to fix it in system_metadata, so this should be useless.","commit_id":"50eaf05ebf885c19b19e771ae7da82f4d676f986"}],"nova/utils.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"9f28f955bb4864e8732f47702bcd540120c55791","unresolved":false,"context_lines":[{"line_number":997,"context_line":"        # NOTE(wanghao): If instance is volume backend, we should set"},{"line_number":998,"context_line":"        #                the min_disk in the image meta based on the"},{"line_number":999,"context_line":"        #                root volume\u0027s size."},{"line_number":1000,"context_line":"        if key \u003d\u003d \u0027min_disk\u0027 and image_meta.pop(\u0027volume_backend\u0027, None):"},{"line_number":1001,"context_line":"            value \u003d image_meta[\u0027min_disk\u0027]"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        if value is None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_2bfe1eae","line":1000,"updated":"2017-11-22 13:17:21.000000000","message":"We can\u0027t use pop like this here, this should be get. This will result in \u0027volume_backend\u0027 being removed from the image_meta dict, which was passed in by the caller. It\u0027s difficult to tell what the impact of this would be (which is exactly why we mustn\u0027t do it), but I suspect that when creating multiple instances this would delete volume_backend for all but the first (see boot_meta passed in a loop to create_db_entry_for_new_instance() in _provision_instances).\n\nRegardless, in general functions shouldn\u0027t modify their input parameters unless they do so explicitly.","commit_id":"2aca450ff223a27245f921677311fe984e0c7efb"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"3906162427b0802a60dec49ca677b7f4161c8863","unresolved":false,"context_lines":[{"line_number":997,"context_line":"        # NOTE(wanghao): If instance is volume backend, we should set"},{"line_number":998,"context_line":"        #                the min_disk in the image meta based on the"},{"line_number":999,"context_line":"        #                root volume\u0027s size."},{"line_number":1000,"context_line":"        if key \u003d\u003d \u0027min_disk\u0027 and image_meta.pop(\u0027volume_backend\u0027, None):"},{"line_number":1001,"context_line":"            value \u003d image_meta[\u0027min_disk\u0027]"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        if value is None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_a1c22e2c","line":1000,"in_reply_to":"ff82abbf_2bfe1eae","updated":"2018-12-18 03:10:31.000000000","message":"Thanks Matthew for reviewing this,  I will check this out.","commit_id":"2aca450ff223a27245f921677311fe984e0c7efb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3cca107f33f6e04ec562698652537939af139ec","unresolved":false,"context_lines":[{"line_number":958,"context_line":"    # available because the image backing the volume is not active,"},{"line_number":959,"context_line":"    # then the compute API trying to reserve the volume should fail."},{"line_number":960,"context_line":"    image_meta[\u0027status\u0027] \u003d \u0027active\u0027"},{"line_number":961,"context_line":"    image_meta[\u0027volume_backend\u0027] \u003d True"},{"line_number":962,"context_line":"    return image_meta"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_fc4bd083","line":961,"updated":"2019-04-06 00:40:15.000000000","message":"This wouldn\u0027t fix any existing servers that don\u0027t have this image metadata from when they were created, so it seems that https://review.openstack.org/#/c/605596/ is a simpler more targeted fix.","commit_id":"23e7ed0180f1f25d00f5f3821fcbae9733a37642"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"ba4623002932bf473d54c489e7f818a1683e19e9","unresolved":false,"context_lines":[{"line_number":958,"context_line":"    # available because the image backing the volume is not active,"},{"line_number":959,"context_line":"    # then the compute API trying to reserve the volume should fail."},{"line_number":960,"context_line":"    image_meta[\u0027status\u0027] \u003d \u0027active\u0027"},{"line_number":961,"context_line":"    image_meta[\u0027volume_backend\u0027] \u003d True"},{"line_number":962,"context_line":"    return image_meta"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_769a1dc6","line":961,"in_reply_to":"5fc1f717_fc4bd083","updated":"2019-04-11 07:18:25.000000000","message":"sure, I will see the #605596 and work on it, thanks.","commit_id":"23e7ed0180f1f25d00f5f3821fcbae9733a37642"}]}