)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b71d5f3313361ec3f6c1578f39c11279be7ba96e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: avoid starting compute service twice in sriov functional test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SRIOV functional test allowed some tests to start the compute service"},{"line_number":10,"context_line":"twice with the same hostname, which affected the correctness of the tests."},{"line_number":11,"context_line":"This patch will make sure that the compute service is started only once."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_b33d002d","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":40},"updated":"2016-12-06 16:33:08.000000000","message":"Might be worth mentioning which tests are causing this issues (it\u0027s test_create_server_with_PF_no_VF and test_create_server_with_VF_no_PF, right?)","commit_id":"e4a14791654789ce82fee2bca1d36f94fc7915c3"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b71d5f3313361ec3f6c1578f39c11279be7ba96e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def _run_build_test(self, flavor_id, filter_mock, end_status\u003d\u0027ACTIVE\u0027):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        if not self.compute_started:"},{"line_number":119,"context_line":"            self.compute \u003d self.start_service(\u0027compute\u0027, host\u003d\u0027test_compute0\u0027)"},{"line_number":120,"context_line":"            self.compute_started \u003d True"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        fake_network.set_stub_network_methods(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_53af4c7c","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":78},"updated":"2016-12-06 16:33:08.000000000","message":"Could we move this to \u0027setUp\u0027 instead?","commit_id":"e4a14791654789ce82fee2bca1d36f94fc7915c3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"da7f7742baf38f471e814b39743648808b0d58b1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def _run_build_test(self, flavor_id, filter_mock, end_status\u003d\u0027ACTIVE\u0027):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        if not self.compute_started:"},{"line_number":119,"context_line":"            self.compute \u003d self.start_service(\u0027compute\u0027, host\u003d\u0027test_compute0\u0027)"},{"line_number":120,"context_line":"            self.compute_started \u003d True"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        fake_network.set_stub_network_methods(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ca4d53c5","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":78},"in_reply_to":"3a71b18c_53af4c7c","updated":"2016-12-06 22:18:50.000000000","message":"No, because we need to setup the environment before compute starts so that it collects the fake numa info.\n\nRight?","commit_id":"e4a14791654789ce82fee2bca1d36f94fc7915c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f93ee810197d5b9ebf9a43f2430ef9dc212e0324","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def _run_build_test(self, flavor_id, filter_mock, end_status\u003d\u0027ACTIVE\u0027):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        if not self.compute_started:"},{"line_number":119,"context_line":"            self.compute \u003d self.start_service(\u0027compute\u0027, host\u003d\u0027test_compute0\u0027)"},{"line_number":120,"context_line":"            self.compute_started \u003d True"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        fake_network.set_stub_network_methods(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ceec672c","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":78},"in_reply_to":"3a71b18c_62db7c7c","updated":"2016-12-07 14:00:19.000000000","message":"Of course. Cheers :)","commit_id":"e4a14791654789ce82fee2bca1d36f94fc7915c3"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"4bc8fe9e2c10d93a9500a290fefeb67cfb7d4130","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def _run_build_test(self, flavor_id, filter_mock, end_status\u003d\u0027ACTIVE\u0027):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        if not self.compute_started:"},{"line_number":119,"context_line":"            self.compute \u003d self.start_service(\u0027compute\u0027, host\u003d\u0027test_compute0\u0027)"},{"line_number":120,"context_line":"            self.compute_started \u003d True"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        fake_network.set_stub_network_methods(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_62db7c7c","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":78},"in_reply_to":"3a71b18c_ca4d53c5","updated":"2016-12-07 04:09:43.000000000","message":"Yes, exactly :)","commit_id":"e4a14791654789ce82fee2bca1d36f94fc7915c3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4cb210895cffe282310c92f2635965de4d935795","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if not self.compute_started:"},{"line_number":117,"context_line":"            self.compute \u003d self.start_service(\u0027compute\u0027, host\u003d\u0027test_compute0\u0027)"},{"line_number":118,"context_line":"            self.compute_started \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        fake_network.set_stub_network_methods(self)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_65d7e9bf","line":118,"updated":"2016-12-07 16:21:34.000000000","message":"This gets us around this issue, it seems like we should probably make start_service explode if we start 2 services of same name on same host.","commit_id":"c719e224bc7bc75665da5b3f8ea2b58796d0b7d9"}]}