)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"c89a0604beb11048a6699c3e030342c3b32aead0","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"            LOG.exception(_LE(\u0027Failed to attach volume %volume_id .\u0027),"},{"line_number":1198,"context_line":"                          data[\u0027volume_id\u0027], instance\u003dinstance)"},{"line_number":1199,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1200,"context_line":"                self._disconnect_volume(connection_info, disk_dev)"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"        conf \u003d self._get_volume_config(connection_info, disk_info)"},{"line_number":1203,"context_line":"        self._set_cache_mode(conf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_516648ed","line":1200,"range":{"start_line":1200,"start_character":16,"end_line":1200,"end_character":66},"updated":"2016-12-07 07:42:54.000000000","message":"what if _disconnect_volume fails too, want it shadow original error?","commit_id":"cb9c05b98945398efa07b52240f47fb33363d89a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7cc7c4d311894bc5737309788336abcad7882b12","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"            LOG.exception(_LE(\u0027Failed to attach volume.\u0027),"},{"line_number":1198,"context_line":"                          instance\u003dinstance)"},{"line_number":1199,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1200,"context_line":"                self._disconnect_volume(connection_info, disk_dev)"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"        conf \u003d self._get_volume_config(connection_info, disk_info)"},{"line_number":1203,"context_line":"        self._set_cache_mode(conf)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_46ed808d","line":1200,"range":{"start_line":1200,"start_character":16,"end_line":1200,"end_character":66},"updated":"2016-12-19 13:31:54.000000000","message":"Are we actually able to do this? Surely if the connect failed then there\u0027s nothing to disconnect? Perhaps the exception handler should be more specific","commit_id":"0b660dd6be1aae8e7c743035da448e3aa9b2febc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7cc7c4d311894bc5737309788336abcad7882b12","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"        disk_info \u003d blockinfo.get_info_from_bdm("},{"line_number":1192,"context_line":"            instance, CONF.libvirt.virt_type, instance.image_meta, bdm)"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"        try:"},{"line_number":1195,"context_line":"            self._connect_volume(connection_info, disk_info)"},{"line_number":1196,"context_line":"        except Exception:"},{"line_number":1197,"context_line":"            LOG.exception(_LE(\u0027Failed to attach volume.\u0027),"},{"line_number":1198,"context_line":"                          instance\u003dinstance)"},{"line_number":1199,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1200,"context_line":"                self._disconnect_volume(connection_info, disk_dev)"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"        conf \u003d self._get_volume_config(connection_info, disk_info)"},{"line_number":1203,"context_line":"        self._set_cache_mode(conf)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_a6ec9490","line":1200,"range":{"start_line":1194,"start_character":0,"end_line":1200,"end_character":66},"updated":"2016-12-19 13:31:54.000000000","message":"This needs tests","commit_id":"0b660dd6be1aae8e7c743035da448e3aa9b2febc"}]}