)]}'
{"nova/api/openstack/compute/schemas/block_device_mapping.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1b522a784006f019f4bf6e9e1227960de0df2f22","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # image_id/snapshot_id."},{"line_number":27,"context_line":"    \u0027source_type\u0027: {"},{"line_number":28,"context_line":"        \u0027type\u0027: \u0027string\u0027,"},{"line_number":29,"context_line":"        \u0027enum\u0027: fields.BlockDeviceSourceType.ALL,"},{"line_number":30,"context_line":"    },"},{"line_number":31,"context_line":"    \u0027uuid\u0027: {"},{"line_number":32,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_39a44156","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":49},"updated":"2016-12-22 08:20:44.000000000","message":"I also had this way before, but this way seems a little dangerous against keeping the principle of microversions.\n\nOn this way, the objects layer changes would affect REST API layer unintentionally, and it would be easy to forget microversioning that.\nIn addition, we need to check available parameter values in objects layer. That seems unreadable on that.\n\nI agree with it is nice to remove duplicated code as possible, but this way seems over-optimization and sometime duplicated code will help the readability.\nSo it is nice to keep enum here and change the following destination_type to enum instead.","commit_id":"be404dc161175d72276d806152334a9a340e1fc6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"46d99ae4540add9a96957f58ab7f1f64ce2053ee","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # image_id/snapshot_id."},{"line_number":27,"context_line":"    \u0027source_type\u0027: {"},{"line_number":28,"context_line":"        \u0027type\u0027: \u0027string\u0027,"},{"line_number":29,"context_line":"        \u0027enum\u0027: fields.BlockDeviceSourceType.ALL,"},{"line_number":30,"context_line":"    },"},{"line_number":31,"context_line":"    \u0027uuid\u0027: {"},{"line_number":32,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_795b2955","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":49},"in_reply_to":"da4df55a_39a44156","updated":"2016-12-22 08:30:06.000000000","message":"Yes, this is very nice point. We should have schema as raw as possible. i will change.","commit_id":"be404dc161175d72276d806152334a9a340e1fc6"}]}