)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"ecd0e67b3916b6a4523a13180f68e3e1bff2e636","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sumanth Nagadavalli \u003csumanth.nagadavalli@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-08-19 12:14:07 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating flavor access for the tenant while creating"},{"line_number":8,"context_line":"a private flavor"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"In FlavorManage extension, a change has been made to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAARn%2F%2F%2B4w%3D","line":7,"updated":"2013-08-19 10:38:58.000000000","message":"Slightly difficult to understand the title - I\u0027d say: \"Create flavor-access for the tenant when creating a private flavor\" instead.","commit_id":"e243cc305bf749b7d04aaf09da28ed5ec48b0470"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"ecd0e67b3916b6a4523a13180f68e3e1bff2e636","unresolved":false,"context_lines":[{"line_number":11,"context_line":"create flavor-access for a corresponding tenant on"},{"line_number":12,"context_line":"creating a private flavor"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This also require the api-samples for flavor-access"},{"line_number":15,"context_line":"to be changed, since there will a flavor-access created"},{"line_number":16,"context_line":"by default on creating a private flavor"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAARn%2F%2F%2B48%3D","line":14,"updated":"2013-08-19 10:38:58.000000000","message":"s/require/requires/","commit_id":"e243cc305bf749b7d04aaf09da28ed5ec48b0470"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"ecd0e67b3916b6a4523a13180f68e3e1bff2e636","unresolved":false,"context_lines":[{"line_number":12,"context_line":"creating a private flavor"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This also require the api-samples for flavor-access"},{"line_number":15,"context_line":"to be changed, since there will a flavor-access created"},{"line_number":16,"context_line":"by default on creating a private flavor"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I7795fbd04ae9fc8b1ea6fb27203dfa5217d310ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAARn%2F%2F%2B44%3D","line":15,"updated":"2013-08-19 10:38:58.000000000","message":"s/will/will be/","commit_id":"e243cc305bf749b7d04aaf09da28ed5ec48b0470"}],"nova/api/openstack/compute/contrib/flavormanage.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"bd65b5191d388b6c3048643704f7e6005ff169b2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        rxtx_factor \u003d vals.get(\u0027rxtx_factor\u0027, 1.0)"},{"line_number":69,"context_line":"        is_public \u003d vals.get(\u0027os-flavor-access:is_public\u0027, True)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            is_public \u003d strutils.bool_from_string("},{"line_number":72,"context_line":"                is_public, strict\u003dTrue)"},{"line_number":73,"context_line":"        except ValueError:"},{"line_number":74,"context_line":"            raise exception.InvalidInput(reason\u003d_("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARH%2F%2F2KQ%3D","line":71,"updated":"2013-08-16 10:54:28.000000000","message":"Hmm since this check is already done in the nova/compute/flavors.py in create method - I can\u0027t help but feel we should be doing all of this there.","commit_id":"8e64617cf1ecfc2fea949f3e75678cccc5ca887f"}],"nova/tests/api/openstack/compute/contrib/test_flavor_manage.py":[{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"2f8b3c70b9cf2ee0bf64a88512d46c0896ec336d","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":266,"context_line":"        body \u003d jsonutils.loads(res.body)"},{"line_number":267,"context_line":"        for key in expected[\"flavor\"]:"},{"line_number":268,"context_line":"            self.assertEquals(body[\"flavor\"][key], expected[\"flavor\"][key])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_create_public_flavor_should_not_create_flavor_access(self):"},{"line_number":271,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2B%2BB0%3D","line":268,"updated":"2013-08-09 06:31:07.000000000","message":"I think you should check whether ctxt.tenant is included in the Flavor Access List.","commit_id":"b26e0c62d78369559bca9a35bf6710b62cee1567"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"aef12cab1f7d333502f2f0283be55602af17c705","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":266,"context_line":"        body \u003d jsonutils.loads(res.body)"},{"line_number":267,"context_line":"        for key in expected[\"flavor\"]:"},{"line_number":268,"context_line":"            self.assertEquals(body[\"flavor\"][key], expected[\"flavor\"][key])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_create_public_flavor_should_not_create_flavor_access(self):"},{"line_number":271,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2B9d8%3D","line":268,"in_reply_to":"AAAAQn%2F%2B%2BB0%3D","updated":"2013-08-09 13:49:21.000000000","message":"+1","commit_id":"b26e0c62d78369559bca9a35bf6710b62cee1567"}],"nova/tests/api/openstack/compute/plugins/v3/test_flavor_manage.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"d9da4aa5e18e75d2d084567a56080c06d756a4be","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        #                \"get_flavor_by_flavor_id\","},{"line_number":225,"context_line":"        #                fake_get_flavor_by_flavor_id)"},{"line_number":226,"context_line":"        # self.stubs.Set(flavors, \"destroy\", fake_destroy)"},{"line_number":227,"context_line":"        # self.stubs.Set(flavors, \"create\", fake_create)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        self.controller \u003d flavor_manage.FlavorManageController()"},{"line_number":230,"context_line":"        self.flavor_access_controller \u003d flavor_access.FlavorAccessController()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAS3%2F%2F0ng%3D","line":227,"updated":"2013-09-18 17:12:29.000000000","message":"nit: any reason to keep these comments here?","commit_id":"b45732064eaff5ebaddca847345453a211eab37f"}]}