)]}'
{"nova/objects/instance_numa_topology.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cbbdd88dc8ac790e2afd3d615ed4e9e6a8369b0e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if \u0027pagesize\u0027 not in kwargs:"},{"line_number":61,"context_line":"            self.pagesize \u003d None"},{"line_number":62,"context_line":"            self.obj_reset_changes([\u0027pagesize\u0027])"},{"line_number":63,"context_line":"        if \u0027cpu_topology\u0027 not in kwargs:"},{"line_number":64,"context_line":"            self.cpu_topology \u003d None"},{"line_number":65,"context_line":"            self.obj_reset_changes([\u0027cpu_topology\u0027])"},{"line_number":66,"context_line":"        if \u0027cpu_pinning\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ef775306","side":"PARENT","line":63,"updated":"2016-12-07 17:51:11.000000000","message":"I started by that one because it introduces the less changes.","commit_id":"357df87ff386b8f71969ed16d49f25b7aabe4fd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e6c70ef4a07eeb4cca1cad6d2629b08a586df801","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        cpu_list \u003d sorted(list(self.cpuset))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        threads \u003d 0"},{"line_number":101,"context_line":"        if self.obj_attr_is_set(\u0027cpu_topology\u0027) and self.cpu_topology:"},{"line_number":102,"context_line":"            threads \u003d self.cpu_topology.threads"},{"line_number":103,"context_line":"        if threads \u003d\u003d 1:"},{"line_number":104,"context_line":"            threads \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_baf8374b","line":101,"updated":"2016-12-07 18:14:21.000000000","message":"The way we do this now is the more compact:\n\n if \u0027cpu_topology\u0027 in self:","commit_id":"134486fee06b229e179409b43bb8dc5a3c3b018f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e40c4c4dc04e41096a2ec1e50e1c6afb8ecd53e9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        cpu_list \u003d sorted(list(self.cpuset))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        threads \u003d 0"},{"line_number":101,"context_line":"        if self.obj_attr_is_set(\u0027cpu_topology\u0027) and self.cpu_topology:"},{"line_number":102,"context_line":"            threads \u003d self.cpu_topology.threads"},{"line_number":103,"context_line":"        if threads \u003d\u003d 1:"},{"line_number":104,"context_line":"            threads \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_5e17f7ec","line":101,"in_reply_to":"3a71b18c_baf8374b","updated":"2016-12-08 11:26:07.000000000","message":"I was not aware of that new notation, it\u0027s much better yes I have updated the serie according that one.","commit_id":"134486fee06b229e179409b43bb8dc5a3c3b018f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f9efc052c678be0c12f240bd6e28a07640d198","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        cpu_list \u003d sorted(list(self.cpuset))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        threads \u003d 0"},{"line_number":101,"context_line":"        if (\u0027cpu_topology\u0027 in self) and self.cpu_topology:"},{"line_number":102,"context_line":"            threads \u003d self.cpu_topology.threads"},{"line_number":103,"context_line":"        if threads \u003d\u003d 1:"},{"line_number":104,"context_line":"            threads \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_a025570b","line":101,"range":{"start_line":101,"start_character":11,"end_line":101,"end_character":35},"updated":"2016-12-19 14:18:54.000000000","message":"nit: unnecessary brackets","commit_id":"2659bea182d4cd83720b4206434bbd317d748d57"}],"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e6c70ef4a07eeb4cca1cad6d2629b08a586df801","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"                objects.InstanceNUMACell("},{"line_number":1778,"context_line":"                    id\u003d0, cpuset\u003dset([0, 1]), memory\u003d256, pagesize\u003d2048,"},{"line_number":1779,"context_line":"                    cpu_pinning\u003d{0: 0, 1: 1},"},{"line_number":1780,"context_line":"                    cpu_topology\u003dNone),"},{"line_number":1781,"context_line":"                objects.InstanceNUMACell("},{"line_number":1782,"context_line":"                    id\u003d1, cpuset\u003dset([2]), memory\u003d256, pagesize\u003d2048,"},{"line_number":1783,"context_line":"                    cpu_pinning\u003d{2: 3},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_3a7187e1","line":1780,"updated":"2016-12-07 18:14:21.000000000","message":"Another way to do this is to make a loader on the object that defaults this to None if it\u0027s referenced and unset. Then you can avoid the \"in\" check on use and the explicit passing of None each time.\n\nHowever, that will only work for things running new code, so you we should probably still default these to None in places like this if we\u0027re going to send them (or have them loaded) by old code for the time being.","commit_id":"134486fee06b229e179409b43bb8dc5a3c3b018f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e40c4c4dc04e41096a2ec1e50e1c6afb8ecd53e9","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"                objects.InstanceNUMACell("},{"line_number":1778,"context_line":"                    id\u003d0, cpuset\u003dset([0, 1]), memory\u003d256, pagesize\u003d2048,"},{"line_number":1779,"context_line":"                    cpu_pinning\u003d{0: 0, 1: 1},"},{"line_number":1780,"context_line":"                    cpu_topology\u003dNone),"},{"line_number":1781,"context_line":"                objects.InstanceNUMACell("},{"line_number":1782,"context_line":"                    id\u003d1, cpuset\u003dset([2]), memory\u003d256, pagesize\u003d2048,"},{"line_number":1783,"context_line":"                    cpu_pinning\u003d{2: 3},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_f9245dc7","line":1780,"in_reply_to":"3a71b18c_3a7187e1","updated":"2016-12-08 11:26:07.000000000","message":"I don\u0027t know what you mean by \u0027loader\u0027 I tried to dig little bit around but that was unsuccessful.\n\nCan you give to me more information about how I could introduce such mechanism ?","commit_id":"134486fee06b229e179409b43bb8dc5a3c3b018f"}],"nova/virt/hardware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f9efc052c678be0c12f240bd6e28a07640d198","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    if numa_topology:"},{"line_number":572,"context_line":"        min_requested_threads \u003d None"},{"line_number":573,"context_line":"        cell_topologies \u003d [cell.cpu_topology for cell in numa_topology.cells"},{"line_number":574,"context_line":"                           if (cell.obj_attr_is_set(\u0027cpu_topology\u0027)"},{"line_number":575,"context_line":"                               and cell.cpu_topology)]"},{"line_number":576,"context_line":"        if cell_topologies:"},{"line_number":577,"context_line":"            min_requested_threads \u003d min("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_40cba31e","line":574,"range":{"start_line":574,"start_character":31,"end_line":574,"end_character":67},"updated":"2016-12-19 14:18:54.000000000","message":"shouldn\u0027t this also change to\n\n    \u0027cpu_topology\u0027 in cell\n\nper dansmith\u0027s comments on PS1?","commit_id":"2659bea182d4cd83720b4206434bbd317d748d57"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"29a164b384cb683c3ef143efb177232c060938dc","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    if numa_topology:"},{"line_number":572,"context_line":"        min_requested_threads \u003d None"},{"line_number":573,"context_line":"        cell_topologies \u003d [cell.cpu_topology for cell in numa_topology.cells"},{"line_number":574,"context_line":"                           if (cell.obj_attr_is_set(\u0027cpu_topology\u0027)"},{"line_number":575,"context_line":"                               and cell.cpu_topology)]"},{"line_number":576,"context_line":"        if cell_topologies:"},{"line_number":577,"context_line":"            min_requested_threads \u003d min("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_978b9f67","line":574,"in_reply_to":"1a6eadb0_40cba31e","updated":"2017-01-05 16:58:17.000000000","message":"Good catch I missed that one too... :/","commit_id":"2659bea182d4cd83720b4206434bbd317d748d57"}]}