)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"79a2beabe6501096529ee0697e2197b53416a76f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"objects: remove pagesize from __init__ of InstanceNUMATopology"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit removes the initialization of pagesize to None when"},{"line_number":10,"context_line":"creating object InstanceNUMATopology"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I365efb2dff7a0488983c62441a2cbf022bfe0dd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_3a85b5ac","line":10,"updated":"2016-12-09 10:00:26.000000000","message":"Is there a \"why\" that can go here?\n\nI assume it is probably obvious in the context of other changes, but if stumbling onto the commit without that context (as I did), it\u0027s not at all obvious why this change is being made.","commit_id":"b5bc4bd98d23aac9e5d5c1d7c440458a7af64d2d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"49ada5be055d8408206734015f817ef5ceceabce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"objects: remove pagesize from __init__ of InstanceNUMATopology"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit removes the initialization of pagesize to None when"},{"line_number":10,"context_line":"creating object InstanceNUMATopology"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I365efb2dff7a0488983c62441a2cbf022bfe0dd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_71882b23","line":10,"in_reply_to":"3a71b18c_3a85b5ac","updated":"2016-12-09 13:02:04.000000000","message":"The point of this serie is to remove the hack on __init__ which initializes some fields when we construct the object InstanceNUMATopology. We should not override the __init__ method. The objects framework already provides some mechanisms to set default values.\n\nIf I need to respin I will update the commit message based on your request, but I would like avoid calling Jenkins for a commit message change.","commit_id":"b5bc4bd98d23aac9e5d5c1d7c440458a7af64d2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d97c7d047bbf53e364d23e100c422e548470613b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"instances of InstanceNUMATopology. This necessitates checking for the"},{"line_number":11,"context_line":"presence of the field before using it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As part of this change, a bug in tests for overcommitting of NUMA cells"},{"line_number":14,"context_line":"was uncovered. The tests are reworked to resolve this and documentation"},{"line_number":15,"context_line":"added in case people find the feature as confusing as I did initially."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff0f0b1f_f8f7dff4","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":29},"updated":"2017-05-18 16:52:48.000000000","message":"is there a bug open in launch pad that should be linked or is it just fixed inline?","commit_id":"40612276b3be04c0692e5825cfbb19ced0c34918"}],"nova/tests/unit/compute/test_claims.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2332b37b24c1e80ed3a756cbf6c146efe74be60","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @staticmethod"},{"line_number":73,"context_line":"    def _instancell(id, cpuset, memory):"},{"line_number":74,"context_line":"        return objects.InstanceNUMACell("},{"line_number":75,"context_line":"            id\u003did, cpuset\u003dcpuset, memory\u003dmemory, pagesize\u003dNone)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_4303ad0d","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":19},"updated":"2016-12-19 14:24:55.000000000","message":"*instance_cell? IMO, \u0027create_instance_cell\u0027 would be a more meaningful name, if we\u0027re going this way","commit_id":"b5bc4bd98d23aac9e5d5c1d7c440458a7af64d2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2332b37b24c1e80ed3a756cbf6c146efe74be60","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @staticmethod"},{"line_number":73,"context_line":"    def _instancell(id, cpuset, memory):"},{"line_number":74,"context_line":"        return objects.InstanceNUMACell("},{"line_number":75,"context_line":"            id\u003did, cpuset\u003dcpuset, memory\u003dmemory, pagesize\u003dNone)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_c336dde6","line":73,"range":{"start_line":73,"start_character":20,"end_line":73,"end_character":22},"updated":"2016-12-19 14:24:55.000000000","message":"This is always \u00271\u0027? Maybe just hardcode it","commit_id":"b5bc4bd98d23aac9e5d5c1d7c440458a7af64d2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2332b37b24c1e80ed3a756cbf6c146efe74be60","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @staticmethod"},{"line_number":73,"context_line":"    def _instancell(id, cpuset, memory):"},{"line_number":74,"context_line":"        return objects.InstanceNUMACell("},{"line_number":75,"context_line":"            id\u003did, cpuset\u003dcpuset, memory\u003dmemory, pagesize\u003dNone)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_e31cb96c","line":73,"range":{"start_line":73,"start_character":32,"end_line":73,"end_character":38},"updated":"2016-12-19 14:24:55.000000000","message":"most of the calls to this use \u0027memory\u003d512\u0027 so a default parameter makes sense here","commit_id":"b5bc4bd98d23aac9e5d5c1d7c440458a7af64d2d"}],"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2332b37b24c1e80ed3a756cbf6c146efe74be60","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                                     topology.cells[i].cpuset)"},{"line_number":1229,"context_line":"                    self.assertEqual(testitem[\"expect\"].cells[i].memory,"},{"line_number":1230,"context_line":"                                     topology.cells[i].memory)"},{"line_number":1231,"context_line":"                    if \u0027pagesize\u0027 in testitem[\"expect\"].cells[i]:"},{"line_number":1232,"context_line":"                        # Test pagesize attribute only if set as expected"},{"line_number":1233,"context_line":"                        self.assertEqual(testitem[\"expect\"].cells[i].pagesize,"},{"line_number":1234,"context_line":"                                         topology.cells[i].pagesize)"},{"line_number":1235,"context_line":"                    self.assertEqual(testitem[\"expect\"].cells[i].cpu_pinning,"},{"line_number":1236,"context_line":"                                     topology.cells[i].cpu_pinning)"},{"line_number":1237,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_c3ab3dd5","line":1234,"range":{"start_line":1231,"start_character":0,"end_line":1234,"end_character":68},"updated":"2016-12-19 14:24:55.000000000","message":"nit: I\u0027d find this easier to read if it were moved below the next assert","commit_id":"b5bc4bd98d23aac9e5d5c1d7c440458a7af64d2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d97c7d047bbf53e364d23e100c422e548470613b","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"class VirtNUMATopologyCellUsageTestCase(test.NoDBTestCase):"},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"    def test_fit_instance_cell_success_wo_overcommit(self):"},{"line_number":1629,"context_line":"        \"\"\"Fit an instance cell in a host cell with no overcommit."},{"line_number":1630,"context_line":""},{"line_number":1631,"context_line":"        With or without an overcommit ratio defined, it should always be"},{"line_number":1632,"context_line":"        possible to fit an correctly sized instance cell on an unused host"},{"line_number":1633,"context_line":"        cell. Validate this by attempting to fit an instance cell which is the"},{"line_number":1634,"context_line":"        same size as the host cell."},{"line_number":1635,"context_line":"        \"\"\""},{"line_number":1636,"context_line":"        host_cell \u003d objects.NUMACell(id\u003d4, cpuset\u003dset([1, 2]), memory\u003d1024,"},{"line_number":1637,"context_line":"                                     cpu_usage\u003d0, memory_usage\u003d0, mempages\u003d[],"},{"line_number":1638,"context_line":"                                     siblings\u003d[], pinned_cpus\u003dset([]))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_2d7e376b","line":1635,"range":{"start_line":1629,"start_character":5,"end_line":1635,"end_character":11},"updated":"2017-05-18 16:52:48.000000000","message":"documentation in unit tests +1","commit_id":"40612276b3be04c0692e5825cfbb19ced0c34918"}],"nova/virt/hardware.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b3c3e1f91c51d174b1daf8adc0f615f7fd415b0d","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            return"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    pagesize \u003d None"},{"line_number":922,"context_line":"    "},{"line_number":923,"context_line":"    if \u0027pagesize\u0027 in instance_cell and instance_cell.pagesize:"},{"line_number":924,"context_line":"        pagesize \u003d _numa_cell_supports_pagesize_request("},{"line_number":925,"context_line":"            host_cell, instance_cell)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_50b354e9","line":922,"updated":"2016-12-08 16:19:43.000000000","message":"hum :/","commit_id":"5224cd7c14e2e96e2d6c00a9426c03ab99fbdb8d"}]}