)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc6c290ebd27cfc4642efd9521e8e20f86c2f6d1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This creates a get_schema() method for NetworkModel FieldType."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"implements bp json-schema-for-versioned-object"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c74bdf51f72cfdf814ffcce5365f1d16e9db5b7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_868e1c77","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":46},"updated":"2016-12-27 16:46:19.000000000","message":"This should be \"json-schema-for-versioned-notifications\".","commit_id":"aeda245fec8fe7cefeb709e328bc72cc50923d2c"}],"nova/objects/fields.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"aa8c20f7218274fd9f62220de0d5390972159fad","unresolved":false,"context_lines":[{"line_number":935,"context_line":"            \u0027,\u0027.join([str(vif[\u0027id\u0027]) for vif in value]))"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    def get_schema(self):"},{"line_number":938,"context_line":"        return {\u0027type\u0027: [\u0027string\u0027]}"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":""},{"line_number":941,"context_line":"class AddressBase(FieldType):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_f93fa1b1","line":938,"updated":"2016-12-10 13:05:27.000000000","message":"Hrmmm... this doesn\u0027t seem right. network_model.NetworkInfo is the actual type that stored in this field type. And network_model.NetworkInfo is a complex object type containing multiple object fields inside it (though they are not oslo_versionedobjects object models). This is one of the older and cruftier parts of the Nova codebase -- it comes from the early days of Neutron integration.\n\nI don\u0027t believe type: \u0027string\u0027 is appropriate here, but at the same time, since NetworkInfo isn\u0027t an o.vo object, I\u0027m not entirely sure what to put here.","commit_id":"aeda245fec8fe7cefeb709e328bc72cc50923d2c"}]}