)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e918f0d573b0d35fac82eb90a2e04d9fc3c1f66e","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"    _update_ovs_vif_port_mtu(dev, mtu)"},{"line_number":1295,"context_line":""},{"line_number":1296,"context_line":""},{"line_number":1297,"context_line":"def _update_ovs_vif_port_mtu(dev, mtu):"},{"line_number":1298,"context_line":"    # Note at present there is no support for setting the"},{"line_number":1299,"context_line":"    # mtu for vhost-user type ports."},{"line_number":1300,"context_line":"    if interface_type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_18e7a0ac","line":1297,"range":{"start_line":1297,"start_character":0,"end_line":1297,"end_character":39},"updated":"2016-12-16 16:39:56.000000000","message":"you need to accept the interface type here and pass it here it is invoked.","commit_id":"0cc616956a9170580839f0114805f4bf4c533ba5"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4fafd4934cc2c57e61fcf290067f9620238b8cd1","unresolved":false,"context_lines":[{"line_number":569,"context_line":"            elif port \u003d\u003d \u0027ivs\u0027:"},{"line_number":570,"context_line":"                linux_net.create_ivs_vif_port(v2_name, iface_id,"},{"line_number":571,"context_line":"                                              vif[\u0027address\u0027], instance.uuid)"},{"line_number":572,"context_line":"        elif port \u003d\u003d \u0027ovs\u0027:"},{"line_number":573,"context_line":"            # NOTE(stephenfin): Handle MTU changes on the network (for example,"},{"line_number":574,"context_line":"            # after an in-place live upgrade) by configuring it accordingly"},{"line_number":575,"context_line":"            for dev in [v1_name, v2_name]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_48d1e4cc","line":572,"range":{"start_line":572,"start_character":13,"end_line":572,"end_character":26},"updated":"2016-12-08 20:27:00.000000000","message":"is there a reason your are not also updating the mtu of the veth pair when you are using ivs?\n\ni think this should just be an else instead of an elif.","commit_id":"a5e8ac8f9469c23b92b33a7d290320c31466dc58"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8cf231205a27e9ea6224c22d635f7ee65ae91bc3","unresolved":false,"context_lines":[{"line_number":569,"context_line":"            elif port \u003d\u003d \u0027ivs\u0027:"},{"line_number":570,"context_line":"                linux_net.create_ivs_vif_port(v2_name, iface_id,"},{"line_number":571,"context_line":"                                              vif[\u0027address\u0027], instance.uuid)"},{"line_number":572,"context_line":"        elif port \u003d\u003d \u0027ovs\u0027:"},{"line_number":573,"context_line":"            # NOTE(stephenfin): Handle MTU changes on the network (for example,"},{"line_number":574,"context_line":"            # after an in-place live upgrade) by configuring it accordingly"},{"line_number":575,"context_line":"            for dev in [v1_name, v2_name]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_3f671eea","line":572,"range":{"start_line":572,"start_character":13,"end_line":572,"end_character":26},"in_reply_to":"1a6eadb0_6e034074","updated":"2016-12-15 14:32:24.000000000","message":"Yup - right you are. Got that logic wrong in my head. Fixed in PS4","commit_id":"a5e8ac8f9469c23b92b33a7d290320c31466dc58"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da6ffc5fbb0ce4be222313e55b817584ad0b9ada","unresolved":false,"context_lines":[{"line_number":569,"context_line":"            elif port \u003d\u003d \u0027ivs\u0027:"},{"line_number":570,"context_line":"                linux_net.create_ivs_vif_port(v2_name, iface_id,"},{"line_number":571,"context_line":"                                              vif[\u0027address\u0027], instance.uuid)"},{"line_number":572,"context_line":"        elif port \u003d\u003d \u0027ovs\u0027:"},{"line_number":573,"context_line":"            # NOTE(stephenfin): Handle MTU changes on the network (for example,"},{"line_number":574,"context_line":"            # after an in-place live upgrade) by configuring it accordingly"},{"line_number":575,"context_line":"            for dev in [v1_name, v2_name]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_67e9551a","line":572,"range":{"start_line":572,"start_character":13,"end_line":572,"end_character":26},"in_reply_to":"3a71b18c_48d1e4cc","updated":"2016-12-09 10:28:03.000000000","message":"It doesn\u0027t seem possible to set the MTU for IVS interfaces (note that lack of an MTU argument in \u0027create_ivs_vif_port\u0027), hence this is OVS only","commit_id":"a5e8ac8f9469c23b92b33a7d290320c31466dc58"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"15c91c251cedb0c10bf80a31a566f0932bbb9a78","unresolved":false,"context_lines":[{"line_number":569,"context_line":"            elif port \u003d\u003d \u0027ivs\u0027:"},{"line_number":570,"context_line":"                linux_net.create_ivs_vif_port(v2_name, iface_id,"},{"line_number":571,"context_line":"                                              vif[\u0027address\u0027], instance.uuid)"},{"line_number":572,"context_line":"        elif port \u003d\u003d \u0027ovs\u0027:"},{"line_number":573,"context_line":"            # NOTE(stephenfin): Handle MTU changes on the network (for example,"},{"line_number":574,"context_line":"            # after an in-place live upgrade) by configuring it accordingly"},{"line_number":575,"context_line":"            for dev in [v1_name, v2_name]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_6e034074","line":572,"range":{"start_line":572,"start_character":13,"end_line":572,"end_character":26},"in_reply_to":"3a71b18c_67e9551a","updated":"2016-12-13 01:39:16.000000000","message":"you would not be setting the mtu on the port in the indigo vswitch you would be setting the mtu on the veth pair that is then plugged into the indigo vswitch.\n\nso even if indigo vswitch has infinite mtu support effectively if you mtu on the veth is 500 for example the mtu of the ivs port will effectively be limited to the mtu of the veth as all packets transiting via the port will be bottlenecked by the veth.","commit_id":"a5e8ac8f9469c23b92b33a7d290320c31466dc58"}]}