)]}'
{"nova/cells/state.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e71d75cb2eb23bbfe1f8a6694c7883f9ab15249","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                chost \u003d compute_hosts[host]"},{"line_number":278,"context_line":"                chost[\u0027free_ram_mb\u0027] +\u003d max(0, compute.free_ram_mb)"},{"line_number":279,"context_line":"                if compute.free_disk_gb and compute.free_disk_gb \u003e 0:"},{"line_number":280,"context_line":"                    chost[\u0027free_disk_mb\u0027] +\u003d compute.free_disk_gb * 1024"},{"line_number":281,"context_line":"                chost[\u0027total_ram_mb\u0027] +\u003d max(0, compute.memory_mb)"},{"line_number":282,"context_line":"                total_disk \u003d compute.local_gb * 1024"},{"line_number":283,"context_line":"                chost[\u0027total_disk_mb\u0027] +\u003d max(0, total_disk)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_50a992de","line":280,"updated":"2016-12-13 19:46:03.000000000","message":"This is a change in behavior which could mean free_disk_mb might not be set in chost.\n\nmax(0, None) results in 0, so it would probably just be better to do like free_ram_mb above and do:\n\nfree_disk \u003d max(0, compute.free_disk_gb) * 1024","commit_id":"fb64b89b94ca2fedc6c296a692f3c49f6eac6afb"},{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"6827dd2642091f4633b8600022115f08e34e6b55","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                chost[\u0027free_ram_mb\u0027] +\u003d max(0, compute.free_ram_mb)"},{"line_number":279,"context_line":"                chost[\u0027free_disk_mb\u0027] +\u003d max(compute.free_disk_gb, 0) * 1024"},{"line_number":280,"context_line":"                chost[\u0027total_ram_mb\u0027] +\u003d max(0, compute.memory_mb)"},{"line_number":281,"context_line":"                total_disk \u003d compute.local_gb * 1024"},{"line_number":282,"context_line":"                chost[\u0027total_disk_mb\u0027] +\u003d max(0, total_disk)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        _get_compute_hosts()"},{"line_number":285,"context_line":"        if not compute_hosts:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_7f756396","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":60},"updated":"2016-12-14 09:15:10.000000000","message":"chost[\u0027total_disk_mb\u0027] +\u003d max(compute.local_gb, 0) * 1024","commit_id":"3c4bf2d43c4b7f59eda56d0e1be69b11c52f23d2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"86ca1551f22f7f5647bd8d26290753e7189d4292","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"                chost \u003d compute_hosts[host]"},{"line_number":278,"context_line":"                chost[\u0027free_ram_mb\u0027] +\u003d max(0, compute.free_ram_mb)"},{"line_number":279,"context_line":"                chost[\u0027free_disk_mb\u0027] +\u003d max(0, compute.free_disk_gb) * 1024"},{"line_number":280,"context_line":"                chost[\u0027total_ram_mb\u0027] +\u003d max(0, compute.memory_mb)"},{"line_number":281,"context_line":"                chost[\u0027total_disk_mb\u0027] +\u003d max(0, compute.local_gb) * 1024"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_c61fd007","line":279,"range":{"start_line":279,"start_character":41,"end_line":279,"end_character":76},"updated":"2016-12-19 13:24:08.000000000","message":"fwiw this, along with the existing cases, is broken in Python 3.\n\n  $ python3\n  \u003e\u003e\u003e max(123, None)\n  Traceback (most recent call last):\n    File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  TypeError: unorderable types: NoneType() \u003e int()","commit_id":"58bf5d005394d2b31bab9e8971e765c35974ca07"}]}