)]}'
{"nova/availability_zones.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"4bd25a20110084f208253e1db5cd2d6331266adb","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_instance_availability_zone(context, instance):"},{"line_number":162,"context_line":"    \"\"\"Return availability zone of specified instance.\"\"\""},{"line_number":163,"context_line":"    host \u003d instance.get(\u0027host\u0027, None)"},{"line_number":164,"context_line":"    if not host:"},{"line_number":165,"context_line":"        # Likely hasn\u0027t reached a viable compute node yet so give back the"},{"line_number":166,"context_line":"        # desired availability_zone in the instance record if the boot request"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_65f66d5e","line":163,"updated":"2016-12-12 09:29:01.000000000","message":"Ok, so looks like this calls getattr() https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L771 and indeed needs a default value to be passed.\n\nCould you please add a unit test for this?","commit_id":"76e175b3be433ecfe55881e8081f9bad5430c37f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"65b85d264ff633d8af3d792461e24ca9239b5cef","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_instance_availability_zone(context, instance):"},{"line_number":162,"context_line":"    \"\"\"Return availability zone of specified instance.\"\"\""},{"line_number":163,"context_line":"    host \u003d instance.get(\u0027host\u0027, None)"},{"line_number":164,"context_line":"    if not host:"},{"line_number":165,"context_line":"        # Likely hasn\u0027t reached a viable compute node yet so give back the"},{"line_number":166,"context_line":"        # desired availability_zone in the instance record if the boot request"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_917b507b","line":163,"range":{"start_line":163,"start_character":30,"end_line":163,"end_character":36},"updated":"2016-12-19 13:42:39.000000000","message":"I don\u0027t think this is needed - it happens by default?\n\n  \u003e\u003e\u003e x \u003d dict()\n  \u003e\u003e\u003e x.get(\u0027y\u0027, None)\n  \u003e\u003e\u003e x.get(\u0027z\u0027)\n\nIf that\u0027s not the case, the issue would presumably be with how we implement/override \u0027getattr\u0027 for the object backing \u0027instance\u0027","commit_id":"b04ef5c108431b9de69ce3509a7fe5467b848ca7"}],"nova/volume/cinder.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"4bd25a20110084f208253e1db5cd2d6331266adb","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                msg \u003d _(\"Instance %(instance)s and volume %(vol)s are not in \""},{"line_number":299,"context_line":"                        \"the same availability_zone. Instance is in \""},{"line_number":300,"context_line":"                        \"%(ins_zone)s. Volume is in %(vol_zone)s\") % {"},{"line_number":301,"context_line":"                            \"instance\": instance.display_name,"},{"line_number":302,"context_line":"                            \"vol\": volume[\u0027id\u0027],"},{"line_number":303,"context_line":"                            \u0027ins_zone\u0027: instance_az,"},{"line_number":304,"context_line":"                            \u0027vol_zone\u0027: volume[\u0027availability_zone\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_e5a0bd44","line":301,"updated":"2016-12-12 09:29:01.000000000","message":"Why not use UUID here? Names are not guaranteed to be unique and, thus, can be misleading","commit_id":"76e175b3be433ecfe55881e8081f9bad5430c37f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"65b85d264ff633d8af3d792461e24ca9239b5cef","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                msg \u003d _(\"Instance %(instance)s and volume %(vol)s are not in \""},{"line_number":299,"context_line":"                        \"the same availability_zone. Instance is in \""},{"line_number":300,"context_line":"                        \"%(ins_zone)s. Volume is in %(vol_zone)s\") % {"},{"line_number":301,"context_line":"                            \"instance\": instance.uuid,"},{"line_number":302,"context_line":"                            \"vol\": volume[\u0027id\u0027],"},{"line_number":303,"context_line":"                            \u0027ins_zone\u0027: instance_az,"},{"line_number":304,"context_line":"                            \u0027vol_zone\u0027: volume[\u0027availability_zone\u0027]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_713b149d","line":301,"range":{"start_line":301,"start_character":28,"end_line":301,"end_character":54},"updated":"2016-12-19 13:42:39.000000000","message":"unrelated change","commit_id":"b04ef5c108431b9de69ce3509a7fe5467b848ca7"}]}