)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5cfac3287a3f558c190364e2a6e067603a2d14a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Cinder v1 API is deprecated and Nova has been emitting"},{"line_number":10,"context_line":"a warning when using it since Juno, so it\u0027s time to drop the"},{"line_number":11,"context_line":"support as we start looking to supporting the new Cinder v3 API."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8eb9ca88be81cc04c4feb3bafda2d8aa79a12dc4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_26141bf4","line":11,"range":{"start_line":11,"start_character":31,"end_line":11,"end_character":41},"updated":"2016-12-12 20:04:32.000000000","message":"support","commit_id":"6c6c440fcd02b9c5a193eaa229a2e1bbe5749ea2"}],"nova/tests/unit/test_cinder.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a039e347cdb915d167522705aa76e536649a948c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        get_api_version.assert_called_once_with(get_endpoint.return_value)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class CinderV2TestCase(BaseCinderTestCase, test.NoDBTestCase):"},{"line_number":139,"context_line":"    \"\"\"Test case for cinder volume v2 api.\"\"\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    URL \u003d \"http://localhost:8776/v2/project_id\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_df1e2b6f","line":138,"updated":"2017-01-05 13:24:49.000000000","message":"I guess the split is worth keeping for when we add v3. meh.","commit_id":"84f5c6165bc94690d299ed4d025e421a651d1bb5"}],"nova/volume/cinder.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9c28e7594438110ae4b2cf6a737244741588aebd","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        d[\u0027attach_status\u0027] \u003d \u0027attached\u0027"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        d[\u0027attach_status\u0027] \u003d \u0027detached\u0027"},{"line_number":127,"context_line":"    d[\u0027display_name\u0027] \u003d vol.name"},{"line_number":128,"context_line":"    d[\u0027display_description\u0027] \u003d vol.description"},{"line_number":129,"context_line":"    # TODO(jdg): Information may be lost in this translation"},{"line_number":130,"context_line":"    d[\u0027volume_type_id\u0027] \u003d vol.volume_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_24c23a86","line":127,"range":{"start_line":127,"start_character":7,"end_line":127,"end_character":19},"updated":"2016-12-22 18:18:07.000000000","message":"could we update these to reflect their Cinder v2 names (name, description) now? I\u0027m fine with that being a separate change","commit_id":"84f5c6165bc94690d299ed4d025e421a651d1bb5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0026810d2ab5e02f8e04f9651d9f61c025c8935","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        d[\u0027attach_status\u0027] \u003d \u0027attached\u0027"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        d[\u0027attach_status\u0027] \u003d \u0027detached\u0027"},{"line_number":127,"context_line":"    d[\u0027display_name\u0027] \u003d vol.name"},{"line_number":128,"context_line":"    d[\u0027display_description\u0027] \u003d vol.description"},{"line_number":129,"context_line":"    # TODO(jdg): Information may be lost in this translation"},{"line_number":130,"context_line":"    d[\u0027volume_type_id\u0027] \u003d vol.volume_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_b66589e2","line":127,"range":{"start_line":127,"start_character":7,"end_line":127,"end_character":19},"in_reply_to":"da4df55a_24c23a86","updated":"2017-01-02 02:24:10.000000000","message":"Not without impacting the compute REST API for os-volumes which is a cinder v1 proxy:\n\nhttps://github.com/openstack/nova/blob/a74d3ae4e815e3727961ef67bd801dada0267a0b/nova/api/openstack/compute/volumes.py#L80\n\nSo it\u0027s just not really worth changing this right now probably.","commit_id":"84f5c6165bc94690d299ed4d025e421a651d1bb5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9c28e7594438110ae4b2cf6a737244741588aebd","unresolved":false,"context_lines":[{"line_number":476,"context_line":"    def update_snapshot_status(self, context, snapshot_id, status):"},{"line_number":477,"context_line":"        vs \u003d cinderclient(context).volume_snapshots"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        # \u002790%\u0027 here is used to tell Cinder that Nova is done"},{"line_number":480,"context_line":"        # with its portion of the \u0027creating\u0027 state. This can"},{"line_number":481,"context_line":"        # be removed when we are able to split the Cinder states"},{"line_number":482,"context_line":"        # into \u0027creating\u0027 and a separate state of"},{"line_number":483,"context_line":"        # \u0027creating_in_nova\u0027. (Same for \u0027deleting\u0027 state.)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        vs.update_snapshot_status("},{"line_number":486,"context_line":"            snapshot_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_84a126ac","line":483,"range":{"start_line":479,"start_character":0,"end_line":483,"end_character":58},"updated":"2016-12-22 18:18:07.000000000","message":"totally unrelated to this change, but ooooohh, MAGIC :S","commit_id":"84f5c6165bc94690d299ed4d025e421a651d1bb5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a039e347cdb915d167522705aa76e536649a948c","unresolved":false,"context_lines":[{"line_number":476,"context_line":"    def update_snapshot_status(self, context, snapshot_id, status):"},{"line_number":477,"context_line":"        vs \u003d cinderclient(context).volume_snapshots"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        # \u002790%\u0027 here is used to tell Cinder that Nova is done"},{"line_number":480,"context_line":"        # with its portion of the \u0027creating\u0027 state. This can"},{"line_number":481,"context_line":"        # be removed when we are able to split the Cinder states"},{"line_number":482,"context_line":"        # into \u0027creating\u0027 and a separate state of"},{"line_number":483,"context_line":"        # \u0027creating_in_nova\u0027. (Same for \u0027deleting\u0027 state.)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        vs.update_snapshot_status("},{"line_number":486,"context_line":"            snapshot_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_5f0b1b2a","line":483,"range":{"start_line":479,"start_character":0,"end_line":483,"end_character":58},"in_reply_to":"ba5201f7_d6620dd8","updated":"2017-01-05 13:24:49.000000000","message":"I totally forgot about this mess, eeewww.","commit_id":"84f5c6165bc94690d299ed4d025e421a651d1bb5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0026810d2ab5e02f8e04f9651d9f61c025c8935","unresolved":false,"context_lines":[{"line_number":476,"context_line":"    def update_snapshot_status(self, context, snapshot_id, status):"},{"line_number":477,"context_line":"        vs \u003d cinderclient(context).volume_snapshots"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        # \u002790%\u0027 here is used to tell Cinder that Nova is done"},{"line_number":480,"context_line":"        # with its portion of the \u0027creating\u0027 state. This can"},{"line_number":481,"context_line":"        # be removed when we are able to split the Cinder states"},{"line_number":482,"context_line":"        # into \u0027creating\u0027 and a separate state of"},{"line_number":483,"context_line":"        # \u0027creating_in_nova\u0027. (Same for \u0027deleting\u0027 state.)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        vs.update_snapshot_status("},{"line_number":486,"context_line":"            snapshot_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_d6620dd8","line":483,"range":{"start_line":479,"start_character":0,"end_line":483,"end_character":58},"in_reply_to":"da4df55a_84a126ac","updated":"2017-01-02 02:24:10.000000000","message":"Yeah, gross, and \u0027creating_in_nova\u0027 isn\u0027t something we\u0027d have in Cinder anyway. This is probably an artifact of the split out of nova-volume in the good old days.","commit_id":"84f5c6165bc94690d299ed4d025e421a651d1bb5"}]}