)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"851389b50e7a96830d8c86c0b9652ff7faa2fb96","unresolved":false,"context_lines":[{"line_number":16,"context_line":"     \u0027enum\u0027: [\u0027volume\u0027, \u0027image\u0027, \u0027snapshot\u0027, \u0027blank\u0027],"},{"line_number":17,"context_line":" },"},{"line_number":18,"context_line":" \u0027boot_index\u0027: {"},{"line_number":19,"context_line":"     \u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027],"},{"line_number":20,"context_line":"     \u0027pattern\u0027: \u0027^-?[0-9]+$\u0027,"},{"line_number":21,"context_line":" },"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a430d35_99ed36f2","line":19,"updated":"2017-02-09 19:43:18.000000000","message":"nit: this has \u0027null\u0027 in it now.","commit_id":"6c8c142e70b17feb8cf513d245bc0f1dffdf92d9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e52b8f54cc51867cfed6020c31ab8e6cf7418ed0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"     \u0027enum\u0027: [\u0027volume\u0027, \u0027image\u0027, \u0027snapshot\u0027, \u0027blank\u0027],"},{"line_number":17,"context_line":" },"},{"line_number":18,"context_line":" \u0027boot_index\u0027: {"},{"line_number":19,"context_line":"     \u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027],"},{"line_number":20,"context_line":"     \u0027pattern\u0027: \u0027^-?[0-9]+$\u0027,"},{"line_number":21,"context_line":" },"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a430d35_392442c5","line":19,"in_reply_to":"1a430d35_99ed36f2","updated":"2017-02-09 19:56:03.000000000","message":"You are right, that is the reason why this patch was necessary to be rebased","commit_id":"6c8c142e70b17feb8cf513d245bc0f1dffdf92d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"851389b50e7a96830d8c86c0b9652ff7faa2fb96","unresolved":false,"context_lines":[{"line_number":21,"context_line":" },"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"So Nova doesn\u0027t need to have the BDM code and this patch removes it."},{"line_number":24,"context_line":"In addition, this patch moves the validation test into JSON-Schema test."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I278baead330c32d39f3d6c42077e3563205eed35"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a430d35_d9633e40","line":24,"updated":"2017-02-09 19:43:18.000000000","message":"I don\u0027t see any test being moved. If the ValueError coverage already exists, please point out which test is covering it, or add one.","commit_id":"6c8c142e70b17feb8cf513d245bc0f1dffdf92d9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e52b8f54cc51867cfed6020c31ab8e6cf7418ed0","unresolved":false,"context_lines":[{"line_number":21,"context_line":" },"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"So Nova doesn\u0027t need to have the BDM code and this patch removes it."},{"line_number":24,"context_line":"In addition, this patch moves the validation test into JSON-Schema test."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I278baead330c32d39f3d6c42077e3563205eed35"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a430d35_dd35e9a8","line":24,"in_reply_to":"1a430d35_d9633e40","updated":"2017-02-09 19:56:03.000000000","message":"Nice point, I could not find the removed ValueError test case on the existing tests. So I will add it for the coverage.","commit_id":"6c8c142e70b17feb8cf513d245bc0f1dffdf92d9"}],"nova/block_device.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9c17ca0c032c3b1d5a36a6a0fa9ea9a2f5aa0a09","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                        details\u003d_(\"Missing device UUID.\"))"},{"line_number":194,"context_line":"                api_dict[source_type + \u0027_id\u0027] \u003d device_uuid"},{"line_number":195,"context_line":"            if source_type \u003d\u003d \u0027image\u0027 and destination_type \u003d\u003d \u0027local\u0027:"},{"line_number":196,"context_line":"                boot_index \u003d int(api_dict.get(\u0027boot_index\u0027, -1))"},{"line_number":197,"context_line":"                # if this bdm is generated from --image ,then"},{"line_number":198,"context_line":"                # source_type \u003d image and destination_type \u003d local is allowed"},{"line_number":199,"context_line":"                if not (image_uuid_specified and boot_index \u003d\u003d 0):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_9998117a","line":196,"updated":"2017-02-08 16:58:33.000000000","message":"FYI about https://review.openstack.org/#/c/430497/","commit_id":"c21426e9da676845cd12c755777ac4001a6e7b24"}],"nova/tests/unit/test_block_device.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"851389b50e7a96830d8c86c0b9652ff7faa2fb96","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":587,"context_line":"            \u0027destination_type\u0027: \u0027local\u0027,"},{"line_number":588,"context_line":"            \u0027uuid\u0027: \u0027fake-volume-id-1\u0027,"},{"line_number":589,"context_line":"            \u0027boot_index\u0027: \u0027aaaa0\u0027}"},{"line_number":590,"context_line":"        self.assertRaises(exception.InvalidBDMFormat,"},{"line_number":591,"context_line":"                          block_device.BlockDeviceDict.from_api, api_dict,"},{"line_number":592,"context_line":"                          False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_198786d8","side":"PARENT","line":589,"updated":"2017-02-09 19:43:18.000000000","message":"What test is covering this? I don\u0027t see anything in the nova.tests.unit.api.openstack.test_block_device_mapping module for this.","commit_id":"d4e70a4275c6c948ce1fb4cede4fceb8b53d0163"}]}