)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"40e01807c6fbd1500f1586224ad8eff31de46c57","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Seeing as nova has long since moved on from 0.9.13, this \"slow path\" can"},{"line_number":15,"context_line":"be dropped and the tests simplified to handle the single path remaining."},{"line_number":16,"context_line":"The (now unused) \u0027_get_domain_by_id\u0027 function and its respective tests"},{"line_number":17,"context_line":"are obliterated in the process."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This also fixes the \u0027listAllDomains\u0027 function of fakelibvirt.Connection,"},{"line_number":20,"context_line":"which appears not to have been called previously and was broken."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_d74c8e44","line":17,"updated":"2016-12-14 14:49:26.000000000","message":"oooh, obliterated. nice.","commit_id":"b7255cb320c662b0b3e5a8fc7e7bbe7ded945d16"}],"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"fc174ee74b4304b46c5317ec0c7a6fedc6ed9f50","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"                self.host_info.cpu_cores,"},{"line_number":1018,"context_line":"                self.host_info.cpu_threads]"},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"    def numOfDomains(self):"},{"line_number":1021,"context_line":"        return len(self._running_vms)"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"    def listDomainsID(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_2177773b","line":1020,"updated":"2016-12-13 16:40:06.000000000","message":"Nothing real calls this any more.","commit_id":"b7255cb320c662b0b3e5a8fc7e7bbe7ded945d16"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"fc174ee74b4304b46c5317ec0c7a6fedc6ed9f50","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"    def numOfDomains(self):"},{"line_number":1021,"context_line":"        return len(self._running_vms)"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"    def listDomainsID(self):"},{"line_number":1024,"context_line":"        return list(self._running_vms.keys())"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"    def lookupByID(self, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_41c2b334","line":1023,"updated":"2016-12-13 16:40:06.000000000","message":"Nothing real calls this any more.","commit_id":"b7255cb320c662b0b3e5a8fc7e7bbe7ded945d16"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"fc174ee74b4304b46c5317ec0c7a6fedc6ed9f50","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"                    error_code\u003dVIR_ERR_NO_NODE_DEVICE,"},{"line_number":1407,"context_line":"                    error_domain\u003dVIR_FROM_NODEDEV)"},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"    def listDefinedDomains(self):"},{"line_number":1410,"context_line":"        return []"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"    def listDevices(self, cap, flags):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_61124fb6","line":1409,"updated":"2016-12-13 16:40:06.000000000","message":"Nothing real calls this any more.","commit_id":"b7255cb320c662b0b3e5a8fc7e7bbe7ded945d16"}],"nova/tests/unit/virt/libvirt/test_host.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"fc174ee74b4304b46c5317ec0c7a6fedc6ed9f50","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        self.assertEqual(doms[2].name(), vm3.name())"},{"line_number":506,"context_line":"        self.assertEqual(doms[3].name(), vm4.name())"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        doms \u003d self.host.list_instance_domains(only_guests\u003dFalse)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        mock_list_all.assert_called_once_with("},{"line_number":511,"context_line":"            fakelibvirt.VIR_CONNECT_LIST_DOMAINS_ACTIVE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_c1bb2371","line":508,"updated":"2016-12-13 16:40:06.000000000","message":"The purist in me would say that this is a separate test with common initialisation.","commit_id":"b7255cb320c662b0b3e5a8fc7e7bbe7ded945d16"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"fc174ee74b4304b46c5317ec0c7a6fedc6ed9f50","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            raise exception.NovaException(msg)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def _list_instance_domains_fast(self, only_running\u003dTrue):"},{"line_number":593,"context_line":"        # The modern (\u003e\u003d 0.9.13) fast way - 1 single API call for all domains"},{"line_number":594,"context_line":"        flags \u003d libvirt.VIR_CONNECT_LIST_DOMAINS_ACTIVE"},{"line_number":595,"context_line":"        if not only_running:"},{"line_number":596,"context_line":"            flags \u003d flags | libvirt.VIR_CONNECT_LIST_DOMAINS_INACTIVE"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_e1681fbd","side":"PARENT","line":593,"updated":"2016-12-13 16:40:06.000000000","message":"ACK.\n\n  MIN_LIBVIRT_VERSION \u003d (1, 2, 1)","commit_id":"90f01d5ebb8dc28aed310ddb5564e92704a4b605"}]}