)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fbe99b88986ecc1f23c4151ebabf2cbe47ab76c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Transform missing delete notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The XXX patch only considered instance delete in the happy case"},{"line_number":10,"context_line":"when the instance is scheduled to a compute successfully and the"},{"line_number":11,"context_line":"compute is available when the delete action is executed."},{"line_number":12,"context_line":"If the instance is never scheduled to a compute or the compute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_e98f14ca","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":7},"updated":"2016-12-14 00:08:31.000000000","message":"It should be replaced with Change-Id?","commit_id":"910fcbf433e605f66f501a099f348fb42b8d5434"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9c1538d06fe50d037325f34b7a4eeb0cc6a5a7ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Transform missing delete notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The XXX patch only considered instance delete in the happy case"},{"line_number":10,"context_line":"when the instance is scheduled to a compute successfully and the"},{"line_number":11,"context_line":"compute is available when the delete action is executed."},{"line_number":12,"context_line":"If the instance is never scheduled to a compute or the compute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_e13276a6","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":7},"in_reply_to":"1a6eadb0_e98f14ca","updated":"2016-12-15 12:44:25.000000000","message":"Done","commit_id":"910fcbf433e605f66f501a099f348fb42b8d5434"}],"doc/notification_samples/instance-delete-end_compute_down.json":[{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"259af148dbfbb229ea5ecf47323608e0f8fb29c9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \"host\":\"compute\","},{"line_number":14,"context_line":"            \"host_name\":\"some-server\","},{"line_number":15,"context_line":"            \"ip_addresses\": [],"},{"line_number":16,"context_line":"            \"kernel_id\":\"\","},{"line_number":17,"context_line":"            \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":18,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":19,"context_line":"            \"metadata\":{},"},{"line_number":20,"context_line":"            \"locked\": false,"}],"source_content_type":"application/json","patch_set":19,"id":"3f1d235d_bc8c9e35","line":17,"range":{"start_line":16,"start_character":27,"end_line":17,"end_character":12},"updated":"2017-07-11 05:57:59.000000000","message":"Missing: \"key_name\": \"my-key\",","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6614fe6416dab40c6601145e6a937a7c51369365","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \"host\":\"compute\","},{"line_number":14,"context_line":"            \"host_name\":\"some-server\","},{"line_number":15,"context_line":"            \"ip_addresses\": [],"},{"line_number":16,"context_line":"            \"kernel_id\":\"\","},{"line_number":17,"context_line":"            \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":18,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":19,"context_line":"            \"metadata\":{},"},{"line_number":20,"context_line":"            \"locked\": false,"}],"source_content_type":"application/json","patch_set":19,"id":"1f1a1f67_7626e117","line":17,"range":{"start_line":16,"start_character":27,"end_line":17,"end_character":12},"in_reply_to":"3f1d235d_bc8c9e35","updated":"2017-07-17 10:20:26.000000000","message":"Done","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"259af148dbfbb229ea5ecf47323608e0f8fb29c9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":57,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":58,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":59,"context_line":"    },"},{"line_number":60,"context_line":"    \"priority\":\"INFO\","},{"line_number":61,"context_line":"    \"publisher_id\":\"nova-api:fake-mini\""}],"source_content_type":"application/json","patch_set":19,"id":"3f1d235d_dc8e3a26","line":58,"range":{"start_line":58,"start_character":31,"end_line":58,"end_character":34},"updated":"2017-07-11 05:57:59.000000000","message":"1.3","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6614fe6416dab40c6601145e6a937a7c51369365","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":57,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":58,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":59,"context_line":"    },"},{"line_number":60,"context_line":"    \"priority\":\"INFO\","},{"line_number":61,"context_line":"    \"publisher_id\":\"nova-api:fake-mini\""}],"source_content_type":"application/json","patch_set":19,"id":"1f1a1f67_561f65b6","line":58,"range":{"start_line":58,"start_character":31,"end_line":58,"end_character":34},"in_reply_to":"3f1d235d_dc8e3a26","updated":"2017-07-17 10:20:26.000000000","message":"Done","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"}],"doc/notification_samples/instance-delete-end_not_scheduled.json":[{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"259af148dbfbb229ea5ecf47323608e0f8fb29c9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \"host\":null,"},{"line_number":14,"context_line":"            \"host_name\":\"some-server\","},{"line_number":15,"context_line":"            \"ip_addresses\": [],"},{"line_number":16,"context_line":"            \"kernel_id\":\"\","},{"line_number":17,"context_line":"            \"launched_at\":null,"},{"line_number":18,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":19,"context_line":"            \"metadata\":{},"},{"line_number":20,"context_line":"            \"locked\": false,"}],"source_content_type":"application/json","patch_set":19,"id":"3f1d235d_9c98c26a","line":17,"range":{"start_line":16,"start_character":27,"end_line":17,"end_character":12},"updated":"2017-07-11 05:57:59.000000000","message":"Missing: \"key_name\": \"my-key\",","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6614fe6416dab40c6601145e6a937a7c51369365","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \"host\":null,"},{"line_number":14,"context_line":"            \"host_name\":\"some-server\","},{"line_number":15,"context_line":"            \"ip_addresses\": [],"},{"line_number":16,"context_line":"            \"kernel_id\":\"\","},{"line_number":17,"context_line":"            \"launched_at\":null,"},{"line_number":18,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":19,"context_line":"            \"metadata\":{},"},{"line_number":20,"context_line":"            \"locked\": false,"}],"source_content_type":"application/json","patch_set":19,"id":"1f1a1f67_361ce9bf","line":17,"range":{"start_line":16,"start_character":27,"end_line":17,"end_character":12},"in_reply_to":"3f1d235d_9c98c26a","updated":"2017-07-17 10:20:26.000000000","message":"Done","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"259af148dbfbb229ea5ecf47323608e0f8fb29c9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":57,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":58,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":59,"context_line":"    },"},{"line_number":60,"context_line":"    \"priority\":\"INFO\","},{"line_number":61,"context_line":"    \"publisher_id\":\"nova-api:fake-mini\""}],"source_content_type":"application/json","patch_set":19,"id":"3f1d235d_5ca22a9c","line":58,"range":{"start_line":58,"start_character":31,"end_line":58,"end_character":34},"updated":"2017-07-11 05:57:59.000000000","message":"1.3","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6614fe6416dab40c6601145e6a937a7c51369365","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":57,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":58,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":59,"context_line":"    },"},{"line_number":60,"context_line":"    \"priority\":\"INFO\","},{"line_number":61,"context_line":"    \"publisher_id\":\"nova-api:fake-mini\""}],"source_content_type":"application/json","patch_set":19,"id":"1f1a1f67_f67f91dd","line":58,"range":{"start_line":58,"start_character":31,"end_line":58,"end_character":34},"in_reply_to":"3f1d235d_5ca22a9c","updated":"2017-07-17 10:20:26.000000000","message":"Done","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"}],"doc/notification_samples/instance-delete-start_compute_down.json":[{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"259af148dbfbb229ea5ecf47323608e0f8fb29c9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                    \"device_name\": \"tapce531f90-19\""},{"line_number":27,"context_line":"                }"},{"line_number":28,"context_line":"            }],"},{"line_number":29,"context_line":"            \"kernel_id\":\"\","},{"line_number":30,"context_line":"            \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":31,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":32,"context_line":"            \"metadata\":{},"},{"line_number":33,"context_line":"            \"locked\": false,"}],"source_content_type":"application/json","patch_set":19,"id":"3f1d235d_dcb75ad8","line":30,"range":{"start_line":29,"start_character":27,"end_line":30,"end_character":12},"updated":"2017-07-11 05:57:59.000000000","message":"Missing: \"key_name\": \"my-key\",","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6614fe6416dab40c6601145e6a937a7c51369365","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                    \"device_name\": \"tapce531f90-19\""},{"line_number":27,"context_line":"                }"},{"line_number":28,"context_line":"            }],"},{"line_number":29,"context_line":"            \"kernel_id\":\"\","},{"line_number":30,"context_line":"            \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":31,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":32,"context_line":"            \"metadata\":{},"},{"line_number":33,"context_line":"            \"locked\": false,"}],"source_content_type":"application/json","patch_set":19,"id":"1f1a1f67_d68015c2","line":30,"range":{"start_line":29,"start_character":27,"end_line":30,"end_character":12},"in_reply_to":"3f1d235d_dcb75ad8","updated":"2017-07-17 10:20:26.000000000","message":"Done","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"259af148dbfbb229ea5ecf47323608e0f8fb29c9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":70,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":71,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":72,"context_line":"    },"},{"line_number":73,"context_line":"    \"priority\":\"INFO\","},{"line_number":74,"context_line":"    \"publisher_id\":\"nova-api:fake-mini\""}],"source_content_type":"application/json","patch_set":19,"id":"3f1d235d_3cc64e4b","line":71,"range":{"start_line":71,"start_character":31,"end_line":71,"end_character":34},"updated":"2017-07-11 05:57:59.000000000","message":"1.3","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6614fe6416dab40c6601145e6a937a7c51369365","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":70,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":71,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":72,"context_line":"    },"},{"line_number":73,"context_line":"    \"priority\":\"INFO\","},{"line_number":74,"context_line":"    \"publisher_id\":\"nova-api:fake-mini\""}],"source_content_type":"application/json","patch_set":19,"id":"1f1a1f67_b68599d1","line":71,"range":{"start_line":71,"start_character":31,"end_line":71,"end_character":34},"in_reply_to":"3f1d235d_3cc64e4b","updated":"2017-07-17 10:20:26.000000000","message":"Done","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"}],"doc/notification_samples/instance-delete-start_not_scheduled.json":[{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"259af148dbfbb229ea5ecf47323608e0f8fb29c9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \"host\":null,"},{"line_number":14,"context_line":"            \"host_name\":\"some-server\","},{"line_number":15,"context_line":"            \"ip_addresses\": [],"},{"line_number":16,"context_line":"            \"kernel_id\":\"\","},{"line_number":17,"context_line":"            \"launched_at\":null,"},{"line_number":18,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":19,"context_line":"            \"metadata\":{},"},{"line_number":20,"context_line":"            \"locked\": false,"}],"source_content_type":"application/json","patch_set":19,"id":"3f1d235d_1cc5d23c","line":17,"range":{"start_line":16,"start_character":27,"end_line":17,"end_character":12},"updated":"2017-07-11 05:57:59.000000000","message":"Missing: \"key_name\": \"my-key\",","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6614fe6416dab40c6601145e6a937a7c51369365","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \"host\":null,"},{"line_number":14,"context_line":"            \"host_name\":\"some-server\","},{"line_number":15,"context_line":"            \"ip_addresses\": [],"},{"line_number":16,"context_line":"            \"kernel_id\":\"\","},{"line_number":17,"context_line":"            \"launched_at\":null,"},{"line_number":18,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":19,"context_line":"            \"metadata\":{},"},{"line_number":20,"context_line":"            \"locked\": false,"}],"source_content_type":"application/json","patch_set":19,"id":"1f1a1f67_567405fe","line":17,"range":{"start_line":16,"start_character":27,"end_line":17,"end_character":12},"in_reply_to":"3f1d235d_1cc5d23c","updated":"2017-07-17 10:20:26.000000000","message":"Done","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"259af148dbfbb229ea5ecf47323608e0f8fb29c9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":57,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":58,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":59,"context_line":"    },"},{"line_number":60,"context_line":"    \"priority\":\"INFO\","},{"line_number":61,"context_line":"    \"publisher_id\":\"nova-api:fake-mini\""}],"source_content_type":"application/json","patch_set":19,"id":"3f1d235d_dcdcfa19","line":58,"range":{"start_line":58,"start_character":31,"end_line":58,"end_character":34},"updated":"2017-07-11 05:57:59.000000000","message":"1.3","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6614fe6416dab40c6601145e6a937a7c51369365","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":57,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":58,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":59,"context_line":"    },"},{"line_number":60,"context_line":"    \"priority\":\"INFO\","},{"line_number":61,"context_line":"    \"publisher_id\":\"nova-api:fake-mini\""}],"source_content_type":"application/json","patch_set":19,"id":"1f1a1f67_16644d49","line":58,"range":{"start_line":58,"start_character":31,"end_line":58,"end_character":34},"in_reply_to":"3f1d235d_dcdcfa19","updated":"2017-07-17 10:20:26.000000000","message":"Done","commit_id":"f99d0dadd2a1f805f490a1ae8a8fe0c58ddfd323"}],"nova/compute/api.py":[{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"8a01a920f26ce6d1bcee92658d156bbcf5301137","unresolved":false,"context_lines":[{"line_number":1828,"context_line":"                    compute_utils.notify_about_instance_usage("},{"line_number":1829,"context_line":"                            self.notifier, context, instance,"},{"line_number":1830,"context_line":"                            \"%s.start\" % delete_type)"},{"line_number":1831,"context_line":"                    if delete_type \u003d\u003d \u0027delete\u0027:"},{"line_number":1832,"context_line":"                        compute_utils.notify_about_instance_action("},{"line_number":1833,"context_line":"                            context,"},{"line_number":1834,"context_line":"                            instance,"},{"line_number":1835,"context_line":"                            host\u003dCONF.host,"},{"line_number":1836,"context_line":"                            binary\u003d\u0027nova-api\u0027,"},{"line_number":1837,"context_line":"                            action\u003dfields_obj.NotificationAction.DELETE,"},{"line_number":1838,"context_line":"                            phase\u003dfields_obj.NotificationPhase.START)"},{"line_number":1839,"context_line":""},{"line_number":1840,"context_line":"                    instance.destroy()"},{"line_number":1841,"context_line":"                    compute_utils.notify_about_instance_usage("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_48cd7cb6","line":1838,"range":{"start_line":1831,"start_character":0,"end_line":1838,"end_character":69},"updated":"2017-01-10 16:05:37.000000000","message":"If the delete_type is not \u0027delete\u0027, then no require notify about instance action? (just instance usage?)\n\nAnd why? I dont understand.","commit_id":"ce8cb2122dd2bf42cbf992b6c8ad9c05ce425b40"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fc03bbe97acd7decce9505048f963a53ac978a12","unresolved":false,"context_lines":[{"line_number":1828,"context_line":"                    compute_utils.notify_about_instance_usage("},{"line_number":1829,"context_line":"                            self.notifier, context, instance,"},{"line_number":1830,"context_line":"                            \"%s.start\" % delete_type)"},{"line_number":1831,"context_line":"                    if delete_type \u003d\u003d \u0027delete\u0027:"},{"line_number":1832,"context_line":"                        compute_utils.notify_about_instance_action("},{"line_number":1833,"context_line":"                            context,"},{"line_number":1834,"context_line":"                            instance,"},{"line_number":1835,"context_line":"                            host\u003dCONF.host,"},{"line_number":1836,"context_line":"                            binary\u003d\u0027nova-api\u0027,"},{"line_number":1837,"context_line":"                            action\u003dfields_obj.NotificationAction.DELETE,"},{"line_number":1838,"context_line":"                            phase\u003dfields_obj.NotificationPhase.START)"},{"line_number":1839,"context_line":""},{"line_number":1840,"context_line":"                    instance.destroy()"},{"line_number":1841,"context_line":"                    compute_utils.notify_about_instance_usage("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_641e5571","line":1838,"range":{"start_line":1831,"start_character":0,"end_line":1838,"end_character":69},"in_reply_to":"ba5201f7_48cd7cb6","updated":"2017-01-18 09:17:45.000000000","message":"From the commit message: \"There will be subsequent patch(es) handling the same edge cases for soft_delete and force_delete.\"\nSo If I don\u0027t put the if here then I have to handle soft_delete and force_delete in this same commit and that would make the commit too big. This if will be removed as when the last missing *_delete is transformed properly.","commit_id":"ce8cb2122dd2bf42cbf992b6c8ad9c05ce425b40"}],"nova/compute/utils.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff8cbecec5d28cacb05c150f16220196a00c37e4","unresolved":false,"context_lines":[{"line_number":936,"context_line":"    try:"},{"line_number":937,"context_line":"        notify_about_instance_usage(notifier, context, instance,"},{"line_number":938,"context_line":"                                    \"%s.start\" % delete_type)"},{"line_number":939,"context_line":"        # Note(gibi): soft_delete and force_delete types will be handled in a"},{"line_number":940,"context_line":"        # subsequent patch"},{"line_number":941,"context_line":"        if delete_type \u003d\u003d \u0027delete\u0027:"},{"line_number":942,"context_line":"            notify_about_instance_action("}],"source_content_type":"text/x-python","patch_set":34,"id":"5f93b717_07957ee4","line":939,"range":{"start_line":939,"start_character":10,"end_line":939,"end_character":14},"updated":"2018-01-25 13:38:10.000000000","message":"this should be TODO :)","commit_id":"d60fbd01012fceee6ebc5d845be1a1f4b5c6758c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"71ab92fc588cf9d3a727252a76e7ea08fc72dc8b","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"    try:"},{"line_number":1070,"context_line":"        notify_about_instance_usage(notifier, context, instance,"},{"line_number":1071,"context_line":"                                    \"%s.start\" % delete_type)"},{"line_number":1072,"context_line":"        # Note(gibi): soft_delete and force_delete types will be handled in a"},{"line_number":1073,"context_line":"        # subsequent patch"},{"line_number":1074,"context_line":"        if delete_type \u003d\u003d \u0027delete\u0027:"},{"line_number":1075,"context_line":"            notify_about_instance_action("}],"source_content_type":"text/x-python","patch_set":36,"id":"9f6a8fd7_b043d33e","line":1072,"range":{"start_line":1072,"start_character":10,"end_line":1072,"end_character":20},"updated":"2018-04-26 08:31:58.000000000","message":"I guess this should be TODO :)","commit_id":"042f92730a7980a50053864e1a63b9c4824a711e"}],"nova/tests/functional/api/client.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"154ce25274f652e900b5dd9a59a559c70f68e55e","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":437,"context_line":"            \u0027forced_down\u0027: forced_down"},{"line_number":438,"context_line":"        }"},{"line_number":439,"context_line":"        return self.api_put(\u0027os-services/force-down\u0027, req).body[\u0027service\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff346bd7_0edd8a6f","line":439,"updated":"2017-07-25 16:09:25.000000000","message":"This needs to be adapted to the latest microversion:\n\"Starting with microversion 2.53 this API is superseded by PUT /os-services/{service_id}.\"[1]\n\n[1]https://developer.openstack.org/api-ref/compute/?expanded\u003dupdate-forced-down-detail","commit_id":"fd94ac18b68d536a14b6586f714ec1f6960f4106"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"67ee09722461aebbff654d545ab23ea9a4ceccee","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        for service in self.get_services():"},{"line_number":499,"context_line":"            if service[\u0027binary\u0027] \u003d\u003d binary_name:"},{"line_number":500,"context_line":"                return service[\u0027id\u0027]"},{"line_number":501,"context_line":"        raise OpenStackApiNotFoundException(\u0027Service cannot be found.\u0027)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def put_service_force_down(self, service_id, forced_down):"},{"line_number":504,"context_line":"        req \u003d {"}],"source_content_type":"text/x-python","patch_set":40,"id":"5f7c97a3_9efa9374","line":501,"range":{"start_line":501,"start_character":44,"end_line":501,"end_character":70},"updated":"2018-07-09 07:43:16.000000000","message":"nit: message\u003d\u0027Service cannot be found.\u0027?","commit_id":"bc09251bdfe7c8460d398b51bbb6722a9cc95f58"}],"nova/tests/functional/notification_sample_tests/notification_sample_base.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fbe99b88986ecc1f23c4151ebabf2cbe47ab76c2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                api_version\u003d\u0027v2.1\u0027))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.api \u003d api_fixture.api"},{"line_number":67,"context_line":"        self.api.microversion \u003d api_version_request._MAX_API_VERSION"},{"line_number":68,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":69,"context_line":"        self.admin_api.microversion \u003d api_version_request._MAX_API_VERSION"},{"line_number":70,"context_line":"        fake_notifier.stub_notifier(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_09b7f0d8","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":68},"updated":"2016-12-14 00:08:31.000000000","message":"It had better be as follows:\n\nself.api.microversion \u003d api_version_request.max_api_version().get_string()\n\nhttps://github.com/openstack/nova/blob/146b27f22327f8d60c1017c22ccf18d0e16f1eb7/nova/tests/functional/api_sample_tests/test_versions.py#L26","commit_id":"910fcbf433e605f66f501a099f348fb42b8d5434"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9c1538d06fe50d037325f34b7a4eeb0cc6a5a7ea","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                api_version\u003d\u0027v2.1\u0027))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.api \u003d api_fixture.api"},{"line_number":67,"context_line":"        self.api.microversion \u003d api_version_request._MAX_API_VERSION"},{"line_number":68,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":69,"context_line":"        self.admin_api.microversion \u003d api_version_request._MAX_API_VERSION"},{"line_number":70,"context_line":"        fake_notifier.stub_notifier(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_01dbf24f","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":68},"in_reply_to":"1a6eadb0_09b7f0d8","updated":"2016-12-15 12:44:25.000000000","message":"Done","commit_id":"910fcbf433e605f66f501a099f348fb42b8d5434"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fbe99b88986ecc1f23c4151ebabf2cbe47ab76c2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.api \u003d api_fixture.api"},{"line_number":67,"context_line":"        self.api.microversion \u003d api_version_request._MAX_API_VERSION"},{"line_number":68,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":69,"context_line":"        self.admin_api.microversion \u003d api_version_request._MAX_API_VERSION"},{"line_number":70,"context_line":"        fake_notifier.stub_notifier(self)"},{"line_number":71,"context_line":"        self.addCleanup(fake_notifier.reset)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_89cb0053","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":74},"updated":"2016-12-14 00:08:31.000000000","message":"ditto","commit_id":"910fcbf433e605f66f501a099f348fb42b8d5434"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9c1538d06fe50d037325f34b7a4eeb0cc6a5a7ea","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.api \u003d api_fixture.api"},{"line_number":67,"context_line":"        self.api.microversion \u003d api_version_request._MAX_API_VERSION"},{"line_number":68,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":69,"context_line":"        self.admin_api.microversion \u003d api_version_request._MAX_API_VERSION"},{"line_number":70,"context_line":"        fake_notifier.stub_notifier(self)"},{"line_number":71,"context_line":"        self.addCleanup(fake_notifier.reset)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_21e0eef9","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":74},"in_reply_to":"1a6eadb0_89cb0053","updated":"2016-12-15 12:44:25.000000000","message":"Done","commit_id":"910fcbf433e605f66f501a099f348fb42b8d5434"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7a40489aa37ad2711b2c308713de35f6bb88c2ce","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            expected_status\u003d\u0027ACTIVE\u0027,"},{"line_number":169,"context_line":"            extra_params\u003d{\u0027networks\u0027: [{\u0027port\u0027: self.neutron.port_1[\u0027id\u0027]}]})"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        max_version \u003d api_version_request.max_api_version().get_string()"},{"line_number":172,"context_line":"        self.admin_api.microversion \u003d max_version"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.admin_api.put_service_force_down(\u0027compute\u0027, \u0027nova-compute\u0027,"},{"line_number":175,"context_line":"                                              True)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_a06d2acd","line":172,"range":{"start_line":171,"start_character":0,"end_line":172,"end_character":49},"updated":"2017-06-27 04:45:44.000000000","message":"These lines are not necessary.\n\nhttps://github.com/openstack/nova/blob/24b275756e2ab5f7b1bcf1f31de09d28329eef3f/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L71","commit_id":"8b1dac3348f9d80c3e2d7e2ced50f140c7b602a5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7b8b48aa9a26aa0cb0070de4dcd3be6f0f2ae46c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            expected_status\u003d\u0027ACTIVE\u0027,"},{"line_number":169,"context_line":"            extra_params\u003d{\u0027networks\u0027: [{\u0027port\u0027: self.neutron.port_1[\u0027id\u0027]}]})"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        max_version \u003d api_version_request.max_api_version().get_string()"},{"line_number":172,"context_line":"        self.admin_api.microversion \u003d max_version"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.admin_api.put_service_force_down(\u0027compute\u0027, \u0027nova-compute\u0027,"},{"line_number":175,"context_line":"                                              True)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_2bf2e99a","line":172,"range":{"start_line":171,"start_character":0,"end_line":172,"end_character":49},"in_reply_to":"5f201791_a06d2acd","updated":"2017-06-28 08:30:09.000000000","message":"good catch. Done.","commit_id":"8b1dac3348f9d80c3e2d7e2ced50f140c7b602a5"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f97a0b1e689fb12e508b0aed78e886647f65b58e","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"    @mock.patch.object(compute_utils, \u0027notify_about_instance_action\u0027)"},{"line_number":1045,"context_line":"    def _test_delete(self, delete_type, mock_notify, **attrs):"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"        # reservations \u003d [\u0027fake-resv\u0027]"},{"line_number":1048,"context_line":"        inst \u003d self._create_instance_obj()"},{"line_number":1049,"context_line":"        inst.update(attrs)"},{"line_number":1050,"context_line":"        inst._context \u003d self.context"}],"source_content_type":"text/x-python","patch_set":33,"id":"9f91af0f_e869628b","line":1047,"range":{"start_line":1047,"start_character":8,"end_line":1047,"end_character":38},"updated":"2017-12-28 13:49:41.000000000","message":"Can you drop this","commit_id":"88ef03d232a031aa893717f5c2fa43276b716e1f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c27a89d34eb22df4de841391be8447d4de680e63","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"    @mock.patch.object(compute_utils, \u0027notify_about_instance_action\u0027)"},{"line_number":1045,"context_line":"    def _test_delete(self, delete_type, mock_notify, **attrs):"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"        # reservations \u003d [\u0027fake-resv\u0027]"},{"line_number":1048,"context_line":"        inst \u003d self._create_instance_obj()"},{"line_number":1049,"context_line":"        inst.update(attrs)"},{"line_number":1050,"context_line":"        inst._context \u003d self.context"}],"source_content_type":"text/x-python","patch_set":33,"id":"9f91af0f_3b91454f","line":1047,"range":{"start_line":1047,"start_character":8,"end_line":1047,"end_character":38},"in_reply_to":"9f91af0f_e869628b","updated":"2018-01-08 13:41:34.000000000","message":"Done","commit_id":"88ef03d232a031aa893717f5c2fa43276b716e1f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"58282abd5a5aac79ae3e4f8607e08db11bb4b98d","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        instance.info_cache \u003d objects.InstanceInfoCache()"},{"line_number":167,"context_line":"        instance.flavor \u003d flavor"},{"line_number":168,"context_line":"        instance.old_flavor \u003d instance.new_flavor \u003d None"},{"line_number":169,"context_line":"        instance.auto_disk_config \u003d 0"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if params:"},{"line_number":172,"context_line":"            instance.update(params)"}],"source_content_type":"text/x-python","patch_set":42,"id":"5f7c97a3_ecb15d47","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":37},"updated":"2018-07-23 13:02:53.000000000","message":"Unrelated? It\u0027s been here since PS14 but I\u0027m not sure what it\u0027s for","commit_id":"811f52d8059de30ce7fd1545d474cdb66cc73be7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cf1706af80c50ca531e68750e51c6db1747c6235","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        instance.info_cache \u003d objects.InstanceInfoCache()"},{"line_number":167,"context_line":"        instance.flavor \u003d flavor"},{"line_number":168,"context_line":"        instance.old_flavor \u003d instance.new_flavor \u003d None"},{"line_number":169,"context_line":"        instance.auto_disk_config \u003d 0"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if params:"},{"line_number":172,"context_line":"            instance.update(params)"}],"source_content_type":"text/x-python","patch_set":42,"id":"5f7c97a3_acb125e6","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":37},"in_reply_to":"5f7c97a3_4c741138","updated":"2018-07-23 13:14:02.000000000","message":"Done","commit_id":"811f52d8059de30ce7fd1545d474cdb66cc73be7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"65c2420848c96b92656319a2eb85feb162fd5410","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        instance.info_cache \u003d objects.InstanceInfoCache()"},{"line_number":167,"context_line":"        instance.flavor \u003d flavor"},{"line_number":168,"context_line":"        instance.old_flavor \u003d instance.new_flavor \u003d None"},{"line_number":169,"context_line":"        instance.auto_disk_config \u003d 0"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if params:"},{"line_number":172,"context_line":"            instance.update(params)"}],"source_content_type":"text/x-python","patch_set":42,"id":"5f7c97a3_4c741138","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":37},"in_reply_to":"5f7c97a3_ecb15d47","updated":"2018-07-23 13:12:59.000000000","message":"It seems unrelated. Tests pass without this change.","commit_id":"811f52d8059de30ce7fd1545d474cdb66cc73be7"}]}