)]}'
{"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7d34fa6b006bbabcea316f9e41aafb048264c7fc","unresolved":false,"context_lines":[{"line_number":2336,"context_line":"        self.assertIsNone(obj.os_root)"},{"line_number":2337,"context_line":"        self.assertIsNone(obj.os_init_path)"},{"line_number":2338,"context_line":"        self.assertEqual([], obj.os_boot_dev)"},{"line_number":2339,"context_line":"        self.assertFalse(obj.os_bootmenu)"},{"line_number":2340,"context_line":"        self.assertIsNone(obj.os_smbios)"},{"line_number":2341,"context_line":""},{"line_number":2342,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_e525ccc3","line":2339,"updated":"2017-03-27 11:28:19.000000000","message":"Its tempting for this to be None I guess, to say its not set, but thats probably making the users of the parser do too much.","commit_id":"8b0aaa6788c5d455039f1aeb0c365b054d8ed6d8"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"03021917dfa3e5ae98ba504bf2f58812cd47b338","unresolved":false,"context_lines":[{"line_number":2150,"context_line":"        return root"},{"line_number":2151,"context_line":""},{"line_number":2152,"context_line":"    def _parse_os(self, xmldoc):"},{"line_number":2153,"context_line":"        # smbios is skipped just because LibvirtConfigGuestSMBIOS"},{"line_number":2154,"context_line":"        # does not implement parse_dom method"},{"line_number":2155,"context_line":"        for c in xmldoc.getchildren():"},{"line_number":2156,"context_line":"            if c.tag \u003d\u003d \u0027type\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_b92b8cea","line":2153,"updated":"2016-12-23 15:31:59.000000000","message":"Hum so why to do not add a parse_dom method here ?","commit_id":"6157bb966329e5a6432bef2b5a441b42aca2b2a0"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"338c0d16380e32adfcb68ff685844d521fe3c7db","unresolved":false,"context_lines":[{"line_number":2150,"context_line":"        return root"},{"line_number":2151,"context_line":""},{"line_number":2152,"context_line":"    def _parse_os(self, xmldoc):"},{"line_number":2153,"context_line":"        # smbios is skipped just because LibvirtConfigGuestSMBIOS"},{"line_number":2154,"context_line":"        # does not implement parse_dom method"},{"line_number":2155,"context_line":"        for c in xmldoc.getchildren():"},{"line_number":2156,"context_line":"            if c.tag \u003d\u003d \u0027type\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_142a9f2c","line":2153,"in_reply_to":"da4df55a_b92b8cea","updated":"2016-12-23 16:25:22.000000000","message":"No one needs it at the moment. A separate object property seemed to me a good border to limit changes and do not implement all absent parsing.","commit_id":"6157bb966329e5a6432bef2b5a441b42aca2b2a0"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"03021917dfa3e5ae98ba504bf2f58812cd47b338","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"                    self.os_bootmenu \u003d True"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":2181,"context_line":"        self.virt_type \u003d xmldoc.get(\u0027type\u0027)"},{"line_number":2182,"context_line":"        # Note: This cover only for: LibvirtConfigGuestDisks"},{"line_number":2183,"context_line":"        #                            LibvirtConfigGuestHostdevPCI"},{"line_number":2184,"context_line":"        #                            LibvirtConfigGuestInterface"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_d97cd0ed","line":2181,"updated":"2016-12-23 15:31:59.000000000","message":"I think I could be agree with you to add this. I don\u0027t really know why it has not been done previously. From my point of view we should never be in a case where virt_type is different than the compute node.\n\nIt would be preferable to have this change done in a separate and isolated commit so we can have other contributors to review it.","commit_id":"6157bb966329e5a6432bef2b5a441b42aca2b2a0"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"296bc0821f70697f58038d6cb7cf6e3f8a132786","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"                    self.os_bootmenu \u003d True"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":2181,"context_line":"        self.virt_type \u003d xmldoc.get(\u0027type\u0027)"},{"line_number":2182,"context_line":"        # Note: This cover only for: LibvirtConfigGuestDisks"},{"line_number":2183,"context_line":"        #                            LibvirtConfigGuestHostdevPCI"},{"line_number":2184,"context_line":"        #                            LibvirtConfigGuestInterface"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_334b2689","line":2181,"in_reply_to":"da4df55a_d97cd0ed","updated":"2016-12-25 08:28:01.000000000","message":"Done","commit_id":"6157bb966329e5a6432bef2b5a441b42aca2b2a0"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"338c0d16380e32adfcb68ff685844d521fe3c7db","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"                    self.os_bootmenu \u003d True"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":2181,"context_line":"        self.virt_type \u003d xmldoc.get(\u0027type\u0027)"},{"line_number":2182,"context_line":"        # Note: This cover only for: LibvirtConfigGuestDisks"},{"line_number":2183,"context_line":"        #                            LibvirtConfigGuestHostdevPCI"},{"line_number":2184,"context_line":"        #                            LibvirtConfigGuestInterface"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_14453f16","line":2181,"in_reply_to":"da4df55a_d97cd0ed","updated":"2016-12-23 16:25:22.000000000","message":"ok, will split","commit_id":"6157bb966329e5a6432bef2b5a441b42aca2b2a0"}]}