)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1c73fa59685a4e971904487a7e2bd66639b7ec4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Signed-off-by: Francesco Santoro \u003cfrancesco.santoro@6wind.com\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie232c4f1c2b6573cdf492930730645d2d4fb9d01"},{"line_number":12,"context_line":"Depends-on: I782111ef47d15321804e5b0e1b6f04a0fbfd8dfe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a3c09a3_277873f2","line":12,"updated":"2017-01-13 21:38:33.000000000","message":"I think this is actually the wrong dependency, it should be Ia5da5b3ef28d1b23b217adc5196199df47b54ed9 which raises the minimum required os-vif, and that change depends on the u-c bump.","commit_id":"cfe3c570c60a38adccfee007c619737138af404a"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3174961e2a591e33793e52e8186a263452f50a66","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    elif vif[\u0027details\u0027].get(model.VIF_DETAILS_VHOSTUSER_OVS_PLUG, False):"},{"line_number":318,"context_line":"        profile \u003d objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":319,"context_line":"            interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027])"},{"line_number":320,"context_line":"        vif_name \u003d (\u0027vhu\u0027 + vif[\u0027id\u0027])[:model.NIC_NAME_LEN]"},{"line_number":321,"context_line":"        obj \u003d _get_vif_instance(vif, objects.vif.VIFVHostUser,"},{"line_number":322,"context_line":"                                port_profile\u003dprofile, plugin\u003d\"ovs\","},{"line_number":323,"context_line":"                                vif_name\u003dvif_name)"},{"line_number":324,"context_line":"        if vif[\"network\"][\"bridge\"] is not None:"},{"line_number":325,"context_line":"            obj.bridge_name \u003d vif[\"network\"][\"bridge\"]"},{"line_number":326,"context_line":"        obj.mode \u003d vif[\u0027details\u0027].get("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_ca60e5a7","line":323,"range":{"start_line":320,"start_character":7,"end_line":323,"end_character":50},"updated":"2016-12-16 21:45:31.000000000","message":"this is correct as it is how we compute it now however\nwe should try to pass this from neutron in the future.\n\nthe vif name must exactly match the socket name for the ovs implementation.","commit_id":"01ce2dfd315aa318f87fec97d6261e1f65ebb667"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c77400b53443f8b7ff93a5788539705e24597dbf","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    if vif[\u0027details\u0027].get(model.VIF_DETAILS_VHOSTUSER_OVS_PLUG, False):"},{"line_number":285,"context_line":"        profile \u003d objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":286,"context_line":"            interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027])"},{"line_number":287,"context_line":"        vif_name \u003d (\u0027vhu\u0027 + vif[\u0027id\u0027])[:model.NIC_NAME_LEN]"},{"line_number":288,"context_line":"        obj \u003d _get_vif_instance(vif, objects.vif.VIFVHostUser,"},{"line_number":289,"context_line":"                                port_profile\u003dprofile, plugin\u003d\"ovs\","},{"line_number":290,"context_line":"                                vif_name\u003dvif_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_7f7c54b5","line":287,"updated":"2017-01-17 14:30:56.000000000","message":"Why don\u0027t we use _get_vif_name() for this? I can see it\u0027s not going to return the same thing as a name with the vhu prefix.\n\nWe could add some logic to _get_vif_name such that it checks the vif type to determine the prefix.","commit_id":"4c165dc4bc1d5a76f848cb1fef87d1990f63547a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"73b46db9a12f9720a20e092b23dd8c2de9d7d5b0","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    if vif[\u0027details\u0027].get(model.VIF_DETAILS_VHOSTUSER_OVS_PLUG, False):"},{"line_number":285,"context_line":"        profile \u003d objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":286,"context_line":"            interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027])"},{"line_number":287,"context_line":"        vif_name \u003d (\u0027vhu\u0027 + vif[\u0027id\u0027])[:model.NIC_NAME_LEN]"},{"line_number":288,"context_line":"        obj \u003d _get_vif_instance(vif, objects.vif.VIFVHostUser,"},{"line_number":289,"context_line":"                                port_profile\u003dprofile, plugin\u003d\"ovs\","},{"line_number":290,"context_line":"                                vif_name\u003dvif_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_c2e3abd7","line":287,"in_reply_to":"7a3c09a3_7f7c54b5","updated":"2017-01-17 14:40:56.000000000","message":"Looking at a CI run the vif does have a devname but it\u0027s not what you\u0027re looking to use here I guess:\n\n\"devname\":\"tap96429488-f7\"\n\n{\"profile\": {}, \"ovs_interfaceid\": \"96429488-f7ff-43b0-ae13-ca26996ffcad\", \"preserve_on_delete\": false, \"network\": {\"bridge\": \"br-int\", \"subnets\": [{\"ips\": [{\"version\": 4, \"vif_mac\": \"fa:16:3e:ab:2e:ca\", \"floating_ips\": [{\"meta\": {}, \"version\": 4, \"type\": \"floating\", \"address\": \"172.24.5.10\"}], \"label\": \"tempest-network-smoke--1248009837\", \"meta\": {}, \"address\": \"10.1.0.7\", \"type\": \"fixed\"}], \"version\": 4, \"meta\": {\"dhcp_server\": \"10.1.0.2\"}, \"dns\": [], \"routes\": [], \"cidr\": \"10.1.0.0/28\", \"gateway\": {\"meta\": {}, \"version\": 4, \"type\": \"gateway\", \"address\": \"10.1.0.1\"}}], \"meta\": {\"injected\": false, \"tenant_id\": \"a9a3ca5af79844c0bc873f053b510f16\", \"mtu\": 1350}, \"id\": \"b72174d1-67c5-4a71-b704-90e151c9a91a\", \"label\": \"tempest-network-smoke--1248009837\"}, \"devname\": \"tap96429488-f7\", \"vnic_type\": \"normal\", \"qbh_params\": null, \"meta\": {}, \"details\": {\"port_filter\": false, \"vhostuser_ovs_plug\": true, \"vhostuser_socket\": \"/var/run/openvswitch/vhu96429488-f7\", \"vhostuser_mode\": \"client\"}, \"address\": \"fa:16:3e:ab:2e:ca\", \"active\": false, \"type\": \"vhostuser\", \"id\": \"96429488-f7ff-43b0-ae13-ca26996ffcad\", \"qbg_params\": null}","commit_id":"4c165dc4bc1d5a76f848cb1fef87d1990f63547a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"619ac504d7572035f814a03ea65779fd108ae8c2","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    if vif[\u0027details\u0027].get(model.VIF_DETAILS_VHOSTUSER_OVS_PLUG, False):"},{"line_number":285,"context_line":"        profile \u003d objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":286,"context_line":"            interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027])"},{"line_number":287,"context_line":"        vif_name \u003d (\u0027vhu\u0027 + vif[\u0027id\u0027])[:model.NIC_NAME_LEN]"},{"line_number":288,"context_line":"        obj \u003d _get_vif_instance(vif, objects.vif.VIFVHostUser,"},{"line_number":289,"context_line":"                                port_profile\u003dprofile, plugin\u003d\"ovs\","},{"line_number":290,"context_line":"                                vif_name\u003dvif_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_9da82879","line":287,"in_reply_to":"7a3c09a3_c2e3abd7","updated":"2017-01-17 14:59:04.000000000","message":"currently we are not useing the vif_name for vhost-user interfaces.\n\nthe vif_name must match the last section of the vhost-user socket path i.g. the vif_name must equal the socket file name and the ovs port name.\n\nother vhost-user backend may not have this limitation.\n\nsince neutron must provide the full socket path\ni would also like to have neutron set the vif_name when we adapt neutron to use os-vif objects in the future so that we cant introduce an error where nova and neutron expect different names.","commit_id":"4c165dc4bc1d5a76f848cb1fef87d1990f63547a"}],"requirements.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c77400b53443f8b7ff93a5788539705e24597dbf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"psutil\u003c2.0.0,\u003e\u003d1.1.1 # BSD"},{"line_number":55,"context_line":"oslo.versionedobjects\u003e\u003d1.17.0 # Apache-2.0"},{"line_number":56,"context_line":"os-brick\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":57,"context_line":"os-vif\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":58,"context_line":"os-win\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":59,"context_line":"castellan\u003e\u003d0.4.0 # Apache-2.0"},{"line_number":60,"context_line":"microversion-parse\u003e\u003d0.1.2 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"7a3c09a3_7f729412","line":57,"updated":"2017-01-17 14:30:56.000000000","message":"This is no longer needed, I\u0027m not sure if it will cause a merge conflict later or not.","commit_id":"4c165dc4bc1d5a76f848cb1fef87d1990f63547a"}]}