)]}'
{"api-ref/source/servers.inc":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"603bd934dffd3a475c3e0cb36c92fbbc8e62f94e","unresolved":false,"context_lines":[{"line_number":719,"context_line":"Deletes a server."},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"By default, the instance is going to be (hard) deleted immediately from"},{"line_number":722,"context_line":"the system, but you can set CONF.reclaim_instance_interval \u003e 0 to make"},{"line_number":723,"context_line":"the API soft delete the instance, so that the instance\u0027s vm won\u0027t be"},{"line_number":724,"context_line":"deleted until the CONF.reclaim_instance_interval has expired since the"},{"line_number":725,"context_line":"instance was soft deleted. The instance marked as ``SOFT_DELETED`` can"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"1a6eadb0_2950a2d3","line":722,"range":{"start_line":722,"start_character":28,"end_line":722,"end_character":62},"updated":"2016-12-16 11:18:12.000000000","message":"this is API book, I am not sure whether it make sense to let API developer worry about it","commit_id":"0ba00df0632e2118ba2791b58d43aa4f53d66cb2"},{"author":{"_account_id":21479,"name":"int32bit","email":"krystism@gmail.com","username":"int32bit"},"change_message_id":"412cf11f496a535156aee5f63a9f4312dc0359c3","unresolved":false,"context_lines":[{"line_number":719,"context_line":"Deletes a server."},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"By default, the instance is going to be (hard) deleted immediately from"},{"line_number":722,"context_line":"the system, but you can set CONF.reclaim_instance_interval \u003e 0 to make"},{"line_number":723,"context_line":"the API soft delete the instance, so that the instance\u0027s vm won\u0027t be"},{"line_number":724,"context_line":"deleted until the CONF.reclaim_instance_interval has expired since the"},{"line_number":725,"context_line":"instance was soft deleted. The instance marked as ``SOFT_DELETED`` can"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"1a6eadb0_1f187474","line":722,"range":{"start_line":722,"start_character":28,"end_line":722,"end_character":62},"in_reply_to":"1a6eadb0_2950a2d3","updated":"2016-12-16 12:02:33.000000000","message":"I guess you mean we shouldn\u0027t refer to this config option, but in fact I found many places do like that, like:\n\nhttps://github.com/openstack/nova/blob/master/api-ref/source/servers.inc#L445-L447","commit_id":"0ba00df0632e2118ba2791b58d43aa4f53d66cb2"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"603bd934dffd3a475c3e0cb36c92fbbc8e62f94e","unresolved":false,"context_lines":[{"line_number":736,"context_line":""},{"line_number":737,"context_line":"**Asynchronous postconditions**"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"- With correct permissions, you can see the server status as"},{"line_number":740,"context_line":"  ``DELETED`` through API calls."},{"line_number":741,"context_line":"- The port attached to the server is deleted."},{"line_number":742,"context_line":"- The server does not appear in the list servers response."},{"line_number":743,"context_line":"- The server managed by OpenStack Compute is deleted on the compute"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"1a6eadb0_8925365d","line":740,"range":{"start_line":739,"start_character":0,"end_line":740,"end_character":32},"updated":"2016-12-16 11:18:12.000000000","message":"this should be changed as well to avoid confusion","commit_id":"0ba00df0632e2118ba2791b58d43aa4f53d66cb2"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"9950bd4db94726848ecfeddcacf9a5c0e77ae78b","unresolved":false,"context_lines":[{"line_number":719,"context_line":"Deletes a server."},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"By default, the instance is going to be (hard) deleted immediately from"},{"line_number":722,"context_line":"the system, but you can set CONF.reclaim_instance_interval \u003e 0 to make"},{"line_number":723,"context_line":"the API soft delete the instance, so that the instance\u0027s vm won\u0027t be"},{"line_number":724,"context_line":"deleted until the CONF.reclaim_instance_interval has expired since the"},{"line_number":725,"context_line":"instance was soft deleted. The instance marked as ``SOFT_DELETED`` can"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1a6eadb0_afbd8d03","line":722,"range":{"start_line":722,"start_character":28,"end_line":722,"end_character":32},"updated":"2016-12-16 13:40:17.000000000","message":"\"CONF\" is a nova variable name that won\u0027t mean anything to API consumers. I would just go with ``reclaim_instance_interval``.\n\nI also grepped the api-ref dir and there are no other instances of \"CONF\" in the api-ref.\n\nHave a great weekend!","commit_id":"ef6de391e71792f29c4d77c2737ce9298f64acea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"14a82960ac6753b6499c2959a8ac17e8144b8d2b","unresolved":false,"context_lines":[{"line_number":719,"context_line":"Deletes a server."},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"By default, the instance is going to be (hard) deleted immediately from"},{"line_number":722,"context_line":"the system, but you can set ``reclaim_instance_interval`` \u003e 0 to make"},{"line_number":723,"context_line":"the API soft delete the instance, so that the instance\u0027s vm won\u0027t be"},{"line_number":724,"context_line":"deleted until the ``reclaim_instance_interval`` has expired since the"},{"line_number":725,"context_line":"instance was soft deleted. The instance marked as ``SOFT_DELETED`` can"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"da4df55a_b2f81e4b","line":722,"range":{"start_line":722,"start_character":30,"end_line":722,"end_character":55},"updated":"2016-12-23 03:35:48.000000000","message":"I would try to qualify this as a configuration option somewhere in here so people don\u0027t confuse it as a request parameter in the REST API.","commit_id":"5eb8297f6144f2f941cab92c6298f6eaebafa202"}],"nova/conf/compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d98e2f7f6a4703ad4f44ca14aa3904a72c42e76c","unresolved":false,"context_lines":[{"line_number":435,"context_line":"reclaim_instance_interval). The server can be recovered from the"},{"line_number":436,"context_line":"delete queue by using recover action. If the deleted server remains"},{"line_number":437,"context_line":"longer than the value of reclaim_instance_interval, it will be"},{"line_number":438,"context_line":"deleted by compute service automatically. Note that the"},{"line_number":439,"context_line":"reclaim_instance_interval config option needs to be set to the same"},{"line_number":440,"context_line":"value in all nodes, both API and computes, because the API needs check"},{"line_number":441,"context_line":"this value to decide whether to soft delete or not, and the compute"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_5bddc0de","line":438,"updated":"2016-12-15 19:34:02.000000000","message":"Just rebase your change for the api-ref on top of mine:\n\nhttps://review.openstack.org/#/c/411425/\n\nWhich already has the config option help text updated.","commit_id":"42f10e879a5aea7f177bb42a594fdab7f423f0e0"}]}